Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004019DoomseekerUIpublic2022-07-30 11:082023-02-19 14:14
Reporterauratoostronk 
Assigned ToZalewa 
PrioritynoneSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.3.3 
Target Version1.4.0Fixed in Version1.4.0 
Summary0004019: When trying to join a server without a game executable path specified, Doomseeker should try to find it automatically
DescriptionI can't believe that until after 5 years of using doomseeker I didn't know that there was a little magnifying glass by the game executable path that tries to find it for you (see attached image). Why not make Doomseeker use this function when joining a server in instances where the game executable can't be found?
Attached Filespng file icon THERE IS A FIND BUTTON.png [^] (32,700 bytes) 2022-07-30 11:08


png file icon 2022-07-30-132432_maim.png [^] (11,090 bytes) 2022-07-30 13:25


png file icon 2022-07-30-132721_maim.png [^] (13,725 bytes) 2022-07-30 13:27


jpg file icon ds-20230115-configure-game-when-joining.jpg [^] (12,395 bytes) 2023-01-15 14:58


jpg file icon ds-20230115-configure-game-when-showing-cmd.jpg [^] (16,705 bytes) 2023-01-15 14:58

- Relationships

-  Notes
User avatar (0022296)
WubTheCaptain (reporter)
2022-07-30 13:21

I don't want the configuration and its executable paths to be changed automatically unprompted without approval from the user. Consider unmounted filesystems / disks and such.
User avatar (0022298)
WubTheCaptain (reporter)
2022-07-30 13:39

But the copy of the relevant error text could be improved, and direct the user directly to that plugin's Configuration with a "Configure" button. As a more graceful and friendly alternative, it could go through a proposed new configuration wizard for that game to set its executable before connecting (to reduce the amount of steps required to connect), instead of representing an error and refusing to solve it for you.
User avatar (0022299)
WubTheCaptain (reporter)
2022-07-30 13:55

There's also an extra consideration for UNIX-like operating systems: I don't think the current system searches in $PATH environment, but instead looks for the paths hard-configured in PathFinder::genericPathFinder function (src/core/pathfinder/pathfinder.cpp), so the game client search function is not always be precise. Ideally it should utilize $PATH to be more helpful.
User avatar (0022300)
WubTheCaptain (reporter)
2022-07-30 13:58

Quote from WubTheCaptain
There's also an extra consideration for UNIX-like operating systems

Microsoft Windows too, but I expect hardly any user to deviate from the default Path environment value on that operating system, really. Except developers and server administrators, who may use command-line interface tools.
User avatar (0022301)
auratoostronk (reporter)
2022-07-31 20:35
edited on: 2022-07-31 20:40

I agree with prompting the user before changing their path for their exe. Anything that makes it easier for players to join is fine in my book.

User avatar (0022527)
Zalewa (developer)
2022-12-17 20:39
edited on: 2022-12-17 20:40

The fun thing is that Doomseeker was already opening the config box if you couldn't join the game due to it not being configured. However, due to a bug, the config page for the game wasn't selected properly. This should be fixed here.

Now, as far as the auto-config goes, I agree with Wub here that Doomseeker shouldn't meddle with the configuration like this or try to launch auto-guessed executables on its own. But, to help with the configuration issue, I decided to make the UI more explicit for the user.

So, the config box won't auto-open anymore, and instead a configure game button is displayed in the error message box. This should help with leading the user towards the proper solution of the "lack of game setup" problem.

I also made an attempt at making the error messages themselves sound more human, but I don't know if that was successful.

User avatar (0022645)
Zalewa (developer)
2023-01-05 12:15

Beta package for Windows available at the beta auto-update channel and at:'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please test if the "Configure game" button appears in the error box whenever user tries to join a game (or obtain a command line) when the game isn't configured or is configured improperly.

User avatar (0022700)
Zalewa (developer)
2023-01-15 14:59

When the client executable is misconfigured and the user tries to join a server or obtain its command line, they will get one a message box with the "Configure game" button as shown on:
- ds-20230115-configure-game-when-joining.jpg
- ds-20230115-configure-game-when-showing-cmd.jpg
User avatar (0022702)
Zalewa (developer)
2023-01-15 22:26

As pointed out by Wub in mail, saying "file" instead of "executable" (screenshots from 0004019:0022700) was inconsistent and imprecise.

Adjusted that here:'https://bitbucket.org/Doomseeker/doomseeker/commits/06240249c7135935311679563800c7e289d922dd [^]'

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: WubTheCaptain

- Issue History
Date Modified Username Field Change
2022-07-30 11:08 auratoostronk New Issue
2022-07-30 11:08 auratoostronk File Added: THERE IS A FIND BUTTON.png
2022-07-30 13:21 WubTheCaptain Note Added: 0022296
2022-07-30 13:25 WubTheCaptain File Added: 2022-07-30-132432_maim.png
2022-07-30 13:25 WubTheCaptain Note Added: 0022297
2022-07-30 13:26 WubTheCaptain Note Edited: 0022297 View Revisions
2022-07-30 13:27 WubTheCaptain File Added: 2022-07-30-132721_maim.png
2022-07-30 13:29 WubTheCaptain Note Edited: 0022297 View Revisions
2022-07-30 13:32 WubTheCaptain Note Edited: 0022297 View Revisions
2022-07-30 13:36 WubTheCaptain Note Edited: 0022297 View Revisions
2022-07-30 13:38 WubTheCaptain Note Edited: 0022297 View Revisions
2022-07-30 13:39 WubTheCaptain Note Deleted: 0022297
2022-07-30 13:39 WubTheCaptain Note Added: 0022298
2022-07-30 13:55 WubTheCaptain Note Added: 0022299
2022-07-30 13:58 WubTheCaptain Note Added: 0022300
2022-07-30 17:42 WubTheCaptain Priority low => none
2022-07-31 20:35 auratoostronk Note Added: 0022301
2022-07-31 20:40 auratoostronk Note Edited: 0022301 View Revisions
2022-08-01 19:08 Zalewa Status new => acknowledged
2022-09-10 14:37 Zalewa Target Version => 1.4.0
2022-12-14 17:46 Zalewa Assigned To => Zalewa
2022-12-14 17:46 Zalewa Status acknowledged => assigned
2022-12-17 20:39 Zalewa Note Added: 0022527
2022-12-17 20:39 Zalewa Status assigned => needs review
2022-12-17 20:40 Zalewa Note Edited: 0022527 View Revisions
2023-01-05 12:15 Zalewa Note Added: 0022645
2023-01-05 12:15 Zalewa Status needs review => needs testing
2023-01-15 14:58 Zalewa File Added: ds-20230115-configure-game-when-joining.jpg
2023-01-15 14:58 Zalewa File Added: ds-20230115-configure-game-when-showing-cmd.jpg
2023-01-15 14:59 Zalewa Note Added: 0022700
2023-01-15 14:59 Zalewa Status needs testing => resolved
2023-01-15 14:59 Zalewa Fixed in Version => 1.4.0
2023-01-15 14:59 Zalewa Resolution open => fixed
2023-01-15 22:26 Zalewa Note Added: 0022702
2023-01-15 22:26 Zalewa Status resolved => needs review
2023-01-16 20:29 Zalewa Summary When trying to join a server without a game executeable path specified, Doomseeker should try to find it automatically => When trying to join a server without a game executable path specified, Doomseeker should try to find it automatically
2023-02-19 14:14 Zalewa Status needs review => resolved






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker