Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004010DoomseekerIP2Cpublic2022-06-01 20:352022-06-01 21:42
ReporterWubTheCaptain 
Assigned To 
PrioritylowSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOSOS Version
Product Version1.3.3 
Target VersionFixed in Version 
Summary0004010: IPv4 Unicast Extensions Project may reduce the size of the IPv4 local loopback network ("localnet") from /8 to /16, affecting us
DescriptionIn the future, 127.0.0.0/8 may no longer be reserved for localhost networks but 127.0.0.0/16 will be. Doomseeker has special treatment for 127.0.0.0/8 in the IP2C code, which may become incorrect.
Steps To Reproduce
Quote from src/core/ip2c/ip2c.h
inline bool isLocalhostAddress(unsigned ipv4Address)
{
        const static unsigned LOCALHOST_BEGIN = QHostAddress("127.0.0.0").toIPv4Address();
        
const static unsigned LOCALHOST_END = QHostAddress("127.255.255.255").toIPv4Address();

        return ipv4Address >= LOCALHOST_BEGIN && ipv4Address <= LOCALHOST_END;
}
Additional InformationAPNIC: Cutting down on IP address waste
IETF: draft-schoen-intarea-unicast-127
Attached Filespatch file icon 0001-ip2c-Reduce-the-IPv4-local-loopback-network-from-8-t.patch [^] (1,577 bytes) 2022-06-01 21:04 [Show Content]
patch file icon 0002-CHANGELOG-Add-4010-IPv4-Unicast-Extensions-Project.patch [^] (872 bytes) 2022-06-01 21:13 [Show Content]
patch file icon v2-0001-ip2c-Reduce-the-IPv4-local-loopback-network-from-.patch [^] (1,702 bytes) 2022-06-01 21:41 [Show Content]

- Relationships

-  Notes
User avatar (0022258)
WubTheCaptain (developer)
2022-06-01 20:47

So, how this affects Doomseeker is that some servers may get displayed a special "Localhost" flag incorrectly instead of the country flag from IP2C data or the server info.
IP2C::countryInfoForIPv4 in src/core/ip2c/ip2c.cpp, if you're curious. Two lines of code. Nothing else uses this.
User avatar (0022259)
WubTheCaptain (developer)
2022-06-01 21:05

Patch attached without a changelog. I suggest not merging this until we know a target version for Doomseeker (then comes the changelog), and pending the results of IETF submission process.
User avatar (0022260)
WubTheCaptain (developer)
2022-06-01 21:14

Actually it would not hurt (much) to merge it earlier, so I've added a changelog patch too. It could make some obscure configurations worse, but be readier for the Internet's future use earlier if accepted.
I don't need this to target version 1.4 so I've not set an explicit target version, but I've documented the changes in the "unreleased" version changelogs (which is currently version 1.4).
I'm still okay with waiting and I want an acknowledgement/confirmation on this issue before tagging this in need of a review.
User avatar (0022261)
WubTheCaptain (developer)
2022-06-01 21:42

PATCH v2 1/2 attached, crediting the other authors of the project. Based on the IETF submission names and slide 7:
https://lpc.events/event/4/contributions/457/attachments/219/390/IPv4_Unicast_Extensions4.pdf#page=7 [^]

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2022-06-01 20:35 WubTheCaptain New Issue
2022-06-01 20:37 WubTheCaptain Summary IPv4 Unicast Extensions Project may require changes to treat only 127.0.0.0/16 as a localhost network address => IPv4 Unicast Extensions Project may introduce changes to treat only 127.0.0.0/16 as a localhost network address
2022-06-01 20:40 WubTheCaptain Summary IPv4 Unicast Extensions Project may introduce changes to treat only 127.0.0.0/16 as a localhost network address => IPv4 Unicast Extensions Project may reduce the size of the IPv4 local loopback network ("localnet") from /8 to /16, affecting us
2022-06-01 20:47 WubTheCaptain Note Added: 0022258
2022-06-01 20:55 WubTheCaptain Assigned To => WubTheCaptain
2022-06-01 20:55 WubTheCaptain Status new => assigned
2022-06-01 21:04 WubTheCaptain File Added: 0001-ip2c-Reduce-the-IPv4-local-loopback-network-from-8-t.patch
2022-06-01 21:05 WubTheCaptain Note Added: 0022259
2022-06-01 21:05 WubTheCaptain Assigned To WubTheCaptain =>
2022-06-01 21:05 WubTheCaptain Status assigned => new
2022-06-01 21:13 WubTheCaptain File Added: 0002-CHANGELOG-Add-4010-IPv4-Unicast-Extensions-Project.patch
2022-06-01 21:14 WubTheCaptain Note Added: 0022260
2022-06-01 21:41 WubTheCaptain File Added: v2-0001-ip2c-Reduce-the-IPv4-local-loopback-network-from-.patch
2022-06-01 21:42 WubTheCaptain Note Added: 0022261






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2022 MantisBT Team
Powered by Mantis Bugtracker