Anonymous | Login | Signup for a new account | 2024-04-18 21:59 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003934 | Doomseeker | [All Projects] Cleanup | public | 2021-12-09 03:16 | 2023-01-12 19:03 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Zalewa | ||||||||
Priority | none | Severity | feature | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 1.3.2 | ||||||||
Target Version | 1.4.0 | Fixed in Version | 1.4.0 | ||||||
Summary | 0003934: Old LZMA SDK version (16.04) at src/wadseeker/lzma | ||||||||
Description | Wadseeker uses LZMA SDK to decompress downloaded .7z files. Currently Doomseeker & Wadseeker distribute an old SDK version from 2016, version 16.04. Main 16.04 vs 21.06 changes which may be relevant for Doomseeker/Wadseeker:
Whatever that means. | ||||||||
Steps To Reproduce | $ head -n 4 src/wadseeker/lzma/lzma-history.txt HISTORY of the LZMA SDK ----------------------- 16.04 2016-10-04 There are no copyright notices for year 2017 or newer, so this really is 16.04. $ egrep -r "2017|2018|2019|2020|2021" src/wadseeker/lzma | wc -l 0 | ||||||||
Additional Information | 'https://www.7-zip.org/sdk.html [^]' | ||||||||
Attached Files | |||||||||
Notes | |
(0021866) WubTheCaptain (reporter) 2021-12-09 03:21 |
To respond to a theoretical argument if optimizing this is better than it not existing in the first place: I don't like bundled dependencies in the first place, but there's not much of an alternative to retain support for .7z downloads. There's also not a sensible way to use system dependencies for this if available (previously discussed somewhere on this issue tracker); Debian has lzma-dev version 9.22 and "It is experimental" according to the Debian maintainer, and seems to be either unmaintained or abandoned (the preference is xz-utils, but Doom is all about the legacy crud). |
(0021867) WubTheCaptain (reporter) 2021-12-09 03:25 |
To be honest and in my opinion, it could be pretty nice if this update could be done by removing the LZMA SDK stuff out of Wadseeker distribution and replaced with a git submodule or something, hosting the LZMA SDK at the Doomseeker project's git organization. |
(0022379) Zalewa (developer) 2022-09-10 10:12 |
I upgraded the LZMA SDK to version 22.01. Our own code in un7zip had to be adapted too. 'https://bitbucket.org/Doomseeker/doomseeker/commits/a7d88765790810bece71f26b3019cd4a039d0abf#chg-src/wadseeker/lzma/CMakeLists.txt [^]' |
(0022638) Zalewa (developer) 2023-01-05 12:07 edited on: 2023-01-05 12:07 |
Beta package for Windows available at the beta auto-update channel and at: 'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]' Please test if Wadseeker can unpack WADs packed in 7z archives. |
(0022689) Zalewa (developer) 2023-01-12 19:03 |
I checked download & unpacking WADs from my 2016 test archives and from a newly created archive with the newest 7-zip. All seems ok. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2021-12-09 03:16 | WubTheCaptain | New Issue | |
2021-12-09 03:21 | WubTheCaptain | Note Added: 0021866 | |
2021-12-09 03:25 | WubTheCaptain | Note Added: 0021867 | |
2022-09-10 07:52 | Zalewa | Assigned To | => Zalewa |
2022-09-10 07:52 | Zalewa | Status | new => assigned |
2022-09-10 10:12 | Zalewa | Note Added: 0022379 | |
2022-09-10 10:12 | Zalewa | Status | assigned => needs review |
2022-09-10 14:30 | Zalewa | Target Version | => 1.4.0 |
2023-01-05 12:07 | Zalewa | Note Added: 0022638 | |
2023-01-05 12:07 | Zalewa | Status | needs review => needs testing |
2023-01-05 12:07 | Zalewa | Note Edited: 0022638 | View Revisions |
2023-01-12 19:03 | Zalewa | Note Added: 0022689 | |
2023-01-12 19:03 | Zalewa | Status | needs testing => resolved |
2023-01-12 19:03 | Zalewa | Fixed in Version | => 1.4.0 |
2023-01-12 19:03 | Zalewa | Resolution | open => fixed |
Copyright © 2000 - 2024 MantisBT Team |