Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003908Doomseeker[All Projects] Bugpublic2021-09-24 17:292021-09-27 11:45
ReporterWubTheCaptain 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusacknowledgedResolutionopen 
PlatformOSOS Version
Product Version1.3.2 
Target VersionFixed in Version 
Summary0003908: zandronumbinaries.cpp does not make sure the downloaded Zandronum testing binaries are supported by the CPU architecture
DescriptionA theoretical scenario: An user is running on GNU/Linux using an ARM processor (32-bit or 64-bit). They try to download Zandronum testing binaries. Instead of Doomseeker refusing to download anything or theoretically attempt to download a file appropriate for the architecture build (such as ARM), Doomseeker will always download the x86 (32-bit) binaries.

On Windows (if ever on non-x86), they would always get 32-bit x86 Windows binaries for Zandronum.

The issue is the program didn't check the build or CPU architecture.
Steps To Reproduce
Quote from src/plugins/zandronum/zandronumbinaries.cpp
#ifdef Q_OS_WIN32
#define TESTING_BINARY_URL TESTING_BINARY_URL_BASE "windows.zip"
#define ZANDRONUM_BINARY_NAME "zandronum.exe"
#define SCRIPT_FILE_EXTENSION ".bat"
#else

#ifndef __x86_64__
#define TESTING_BINARY_URL TESTING_BINARY_URL_BASE "linux-x86.tar.bz2"
#else
#define TESTING_BINARY_URL TESTING_BINARY_URL_BASE "linux-x86_64.tar.bz2"
#endif

#ifndef Q_OS_DARWIN
#define ZANDRONUM_BINARY_NAME "zandronum"
#else
#define ZANDRONUM_BINARY_NAME "Zandronum.app"
#define ZANDRONUM_APP_BUNDLE_BIN "/Contents/MacOS/zandronum"
#endif
#define SCRIPT_FILE_EXTENSION ".sh"
#endif
Additional Information
  • QSysInfo::buildCpuArchitecture()
  • QSysInfo::currentCpuArchitecture()
Attached Files

- Relationships
related to 0003905confirmed zandronumbinaries.cpp OS-dependent macro hell is quite ugly (and broken) 

-  Notes
User avatar (0021770)
WubTheCaptain (reporter)
2021-09-24 17:30

 As of 2021-09-24, Zandronum.com does not have desired non-x86/non-x86_64 binaries for Zandronum (e.g. ARM).
User avatar (0021771)
WubTheCaptain (reporter)
2021-09-24 17:33

 The Zandronumq plugin (engine) does not support downloading test binaries, so that plugin is not affected.
User avatar (0021776)
Zalewa (developer)
2021-09-27 11:45

 We should treat this case the same as we treat the Mac case - fail miserably, but properly with an error message :D

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2021-09-24 17:29 WubTheCaptain New Issue
2021-09-24 17:30 WubTheCaptain Note Added: 0021770
2021-09-24 17:30 WubTheCaptain Description Updated View Revisions
2021-09-24 17:33 WubTheCaptain Note Added: 0021771
2021-09-24 17:36 WubTheCaptain Relationship added related to 0003905
2021-09-27 11:45 Zalewa Note Added: 0021776
2021-09-27 11:45 Zalewa Status new => acknowledged




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker