0003872: LineAttack Always from Activator instead of Documented TID

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003872

Zandronum

[All Projects] Bug

public

2021-01-07 02:46

2024-04-07 22:17

Reporter

Gen420

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

3.0

Target Version

3.1

Fixed in Version

3.1

Summary

0003872: LineAttack Always from Activator instead of Documented TID

Description

This is a reminder that the fork Zan 3.0 took over from [520-gd83f048 and older] has an incorrection on the ACS Command LineAttack - on the first argument, it's documented as tid, but in the source code, it's been copy pasted to still be the activator of the script.

This causes confusion when scripting. Possibly, a hell of a waste of time, and an outright lie. Thanks, DavidPH!

Steps To Reproduce

1. Make ACS Script with LineAttack, specify TID.
2. Notice the Hitscan attack isn't coming from the TID, but from the activator.
3. Change the activator via SetActivator, to already mentioned TID.
4. The hitscan attack now comes from the 'TID'.

Additional Information

Graf Zahl's statement: "Indeed. That line's just flat out wrong."

Attached Files

3072.wad [^] (1,897 bytes) 2024-04-07 22:17

Relationships

Notes
(0021702) Kaminsky (developer) 2021-08-08 20:46	This GZDoom commit:'https://github.com/coelckers/gzdoom/commit/400a573e6505f4759d98774726a40ac701187d04 [^]' got backported into Zandronum, so LineAttack's TID parameter should now behave properly.

(0023541) Ru5tK1ng (updater) 2024-04-07 22:17	Tried testwad with 3.1 online and offline and the lineattack worked properly.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2021-01-07 02:46	Gen420	New Issue
2021-08-08 20:46	Kaminsky	Note Added: 0021702
2021-08-08 20:46	Kaminsky	Status	new => needs testing
2024-04-07 22:17	Ru5tK1ng	File Added: 3072.wad
2024-04-07 22:17	Ru5tK1ng	Note Added: 0023541
2024-04-07 22:17	Ru5tK1ng	Status	needs testing => resolved
2024-04-07 22:17	Ru5tK1ng	Resolution	open => fixed
2024-04-07 22:17	Ru5tK1ng	Fixed in Version	=> 3.1
2024-04-07 22:17	Ru5tK1ng	Target Version	=> 3.1

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.