Zandronum Chat on our Discord Server Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003821Doomseeker[All Projects] Epicpublic2020-06-08 02:302021-08-17 00:43
ReporterWubTheCaptain 
Assigned ToBlzut3 
PrioritylowSeverityfeatureReproducibilityN/A
Statusneeds testingResolutionopen 
PlatformOSOS Version
Product Version1.3.1 
Target Version1.4Fixed in Version 
Summary0003821: Replacing Eili Reilin's JSON library (qt-json) with JSON support in Qt
Description0003794:0021408:
Quote from Blzut3
Given that Qt JSON was added years before we added support for Qt5 much less dropped Qt4 support, should we instead have a ticket for switching to Qt 5's own JSON classes?

Maintaining that copy of Eili Reilin's qt-json library has proved burdensome. It seems sensible to me to drop qt-json and switch to Qt5's JSON support.
Additional Informationhttps://doc.qt.io/qt-5/json.html [^]
Attached Files

- Relationships
parent of 0003900acknowledged Translations have remnant strings of now removed Eeli Reilin's QtJson library 
related to 0003794closedWubTheCaptain qt-json is older than aa0930a (stray #include <iostream>) 
related to 0003795closedBlzut3 qt-json isn't a Git submodule 
related to 0003796resolvedWubTheCaptain qt-json dependency is duplicated to different files (2nd report) 
child of 0003895needs testingBlzut3 Add support for Qt 6.2+ 
Not all the children of this issue are yet resolved or closed.

-  Notes
User avatar (0021416)
WubTheCaptain (developer)
2020-06-08 02:34

This is theoretically an epic category issue, because the GUI options to display Eili Reilin's JSON library license text would need to be stripped out too. And strip the build system too.
I'm not sure how to categorize a new child issue for that, so here's a note.
User avatar (0021436)
Zalewa (developer)
2020-06-08 13:46

Despite this having no apparent functional benefit, I support this change. Dropping external dependency that can be fully replaced by another dependency we need either way is always good, and in this case the costs should be minimal.
User avatar (0021703)
Blzut3 (administrator)
2021-08-08 21:54

Technically this still compiles with Qt 6, but some stuff is deprecated so marking this as part of that effort.
User avatar (0021726)
Blzut3 (administrator)
2021-08-15 03:16

https://bitbucket.org/Doomseeker/doomseeker/commits/fc903e1a484a3ac314d9205727eee63ea3828b59 [^]

QJsonDocument was more or less drop in.
User avatar (0021729)
WubTheCaptain (developer)
2021-08-16 18:37

0003821:0021726: Code review found 0003900.
User avatar (0021737)
WubTheCaptain (developer)
2021-08-16 20:10

I have no idea if the autoupdater will remove LICENSE-json.txt with the next update, but it is so "trivial", "have not tried" and I have no intent or means of trying it to have an issue closed as "won't fix" I'm not reporting a new issue; only making a note here.
User avatar (0021738)
WubTheCaptain (developer)
2021-08-16 20:47
edited on: 2021-08-16 20:59

I spent a fair amount trying to understand if /usr/share/doc/doomseeker/LICENSE-json will be removed on Debian systems via DRD Team Debian Package Repository on upgrade, and while I have no definitive answer, I was almost about to create a "have not tried" issue for this due to complications arising from lack of a Debian source package (0003246) to have an easy answer with dh_installdocs(1). But I may trust dpkg to handle this gracefully, even though debian/rules / Debian maintainer script does not exist.

$ cd /tmp
$ mkdir doomseeker/ && cd doomseeker/
$ apt source doomseeker
Reading package lists... Done
E: Unable to find a source package for doomseeker
$ apt download doomseeker
Get:1http://debian.drdteam.org [^] stable/multiverse amd64 doomseeker amd64 1.3.2 [2015 kB]
Fetched 2015 kB in 1s (1591 kB/s)
$ ls -l
total 1968
-rw-r--r-- 1 wub wub 2014914 Aug  8 06:30 doomseeker_1.3.2_amd64.deb
$ ar x doomseeker_1.3.2_amd64.deb
$ ls -l
total 3944
-rw-r--r-- 1 wub wub    1057 Aug 16 20:42 control.tar.gz
-rw-r--r-- 1 wub wub 2013664 Aug 16 20:42 data.tar.xz
-rw-r--r-- 1 wub wub       4 Aug 16 20:42 debian-binary
-rw-r--r-- 1 wub wub 2014914 Aug  8 06:30 doomseeker_1.3.2_amd64.deb
$ tar --list -zf control.tar.gz
control
md5sums
$ tar zxfO control.tar.gz control
Architecture: amd64
Depends: libc6 (>= 2.14), libgcc1 (>= 1:3.0), libqt5core5a (>= 5.9.0~beta), libqt5gui5 (>= 
5.8.0), libqt5multimedia5 (>= 5.6.0~beta), libqt5network5 (>= 5.0.2), libqt5widgets5 (>= 5.6.0~beta), 
libqt5xml5 (>= 5.0.2), libstdc++6 (>= 5.2), libwadseeker2 (>= 2.1), zlib1g (>= 1:1.1.4)

Description: Universal cross-platform server browser designed primarily for Doom.
  This package provides the core program which should be complimented with one or
 more plugins providing support for querying their respective servers.
Homepage:https://doomseeker.drdteam.org [^]
Maintainer: Doomseeker Team <admin@maniacsvault.net>
Package: doomseeker
Priority: optional
Section: devel
Version: 1.3.2
Installed-Size: 6052

$ tar --list -Jf data.tar.xz
./usr/
./usr/bin/
./usr/bin/doomseeker
./usr/share/
./usr/share/applications/
./usr/share/applications/org.drdteam.Doomseeker.desktop
./usr/share/doc/
./usr/share/doc/doomseeker/
./usr/share/doc/doomseeker/LICENSE-json
./usr/share/doomseeker/
./usr/share/doomseeker/IpToCountry.dat
./usr/share/doomseeker/theme/
./usr/share/doomseeker/theme/slots/
./usr/share/doomseeker/theme/slots/marines/
./usr/share/doomseeker/theme/slots/marines/bot.png
./usr/share/doomseeker/theme/slots/marines/open.png
./usr/share/doomseeker/theme/slots/marines/player.png
./usr/share/doomseeker/theme/slots/marines/specopen.png
./usr/share/doomseeker/theme/slots/marines/spectator.png
./usr/share/doomseeker/translations/
./usr/share/doomseeker/translations/ca_ES.qm
./usr/share/doomseeker/translations/es_ES.qm
./usr/share/doomseeker/translations/pl_PL.qm
./usr/share/doomseeker/translations/translations.def
./usr/share/icons/
./usr/share/icons/doomseeker.png
$ rm control.tar.gz data.tar.xz debian-binary doomseeker_1.3.2_amd64.deb
$ cd /tmp; rmdir doomseeker/
$ 

(Also in package libwadseeker2 at /usr/share/doc/wadseeker/LICENSE-json.)

User avatar (0021740)
Blzut3 (administrator)
2021-08-17 00:43

Given that the license file is a file tracked by the package manager and is not marked as a config file it's supposed to be deleted by the package manager automatically.

The Windows auto updater probably won't delete it, but not really a big enough deal to do anything about it I don't think.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: Pol M Zalewa
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-06-08 02:30 WubTheCaptain New Issue
2020-06-08 02:31 WubTheCaptain Relationship added related to 0003794
2020-06-08 02:31 WubTheCaptain Description Updated View Revisions
2020-06-08 02:34 WubTheCaptain Note Added: 0021416
2020-06-08 02:34 WubTheCaptain Category Cleanup => Epic
2020-06-08 02:35 WubTheCaptain Additional Information Updated View Revisions
2020-06-08 04:21 Blzut3 Relationship added related to 0003795
2020-06-08 04:23 Blzut3 Relationship added related to 0003796
2020-06-08 05:37 WubTheCaptain Status new => acknowledged
2020-06-08 13:46 Zalewa Note Added: 0021436
2020-06-08 14:08 WubTheCaptain Status acknowledged => confirmed
2021-08-08 21:53 Blzut3 Relationship added child of 0003895
2021-08-08 21:54 Blzut3 Note Added: 0021703
2021-08-08 22:19 Blzut3 Target Version => 1.4
2021-08-10 05:42 WubTheCaptain Priority none => low
2021-08-15 02:45 Blzut3 Assigned To => Blzut3
2021-08-15 02:45 Blzut3 Status confirmed => assigned
2021-08-15 03:16 Blzut3 Note Added: 0021726
2021-08-15 03:16 Blzut3 Status assigned => needs testing
2021-08-16 18:36 WubTheCaptain Relationship added parent of 0003900
2021-08-16 18:37 WubTheCaptain Note Added: 0021729
2021-08-16 20:10 WubTheCaptain Note Added: 0021737
2021-08-16 20:47 WubTheCaptain Note Added: 0021738
2021-08-16 20:53 WubTheCaptain Note Edited: 0021738 View Revisions
2021-08-16 20:53 WubTheCaptain Note Edited: 0021738 View Revisions
2021-08-16 20:58 WubTheCaptain Note Edited: 0021738 View Revisions
2021-08-16 20:59 WubTheCaptain Note Edited: 0021738 View Revisions
2021-08-17 00:43 Blzut3 Note Added: 0021740






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker