Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003581Doomseeker[All Projects] Bugpublic2018-12-17 04:152019-07-30 10:13
ReporterWubTheCaptain 
Assigned ToPol M 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target Version1.3Fixed in Version1.3 
Summary0003581: Version::operatingSystem() knows only about three operating systems (Windows, Linux & Mac)
DescriptionVersion::operatingSystem() only has definitions for Windows, Linux and Mac. Every other operating system is reported as an "Unknown OS for Version::operatingSystem()".

Qt 5 would provide additional global definitions for at least the following additional operating systems, which could be implemented:

  1. AIX
  2. Android
  3. Any BSD 4.4 system
  4. Cygwin
  5. Darwin (macOS, iOS, watchOS, tvOS)
  6. FreeBSD
  7. HP-UX
  8. GNU Hurd
  9. iOS (see also Darwin)
  10. LynxOS
  11. macOS (see also Darwin)
  12. NetBSD
  13. OpenBSD
  14. PNX Neutrino
  15. Sun Solaris
  16. tvOS (see also Darwin)
  17. Any UNIX BSD/SYSV system
  18. watchOS (see also Darwin)
  19. Windows (64-bit or RT variants)
Steps To Reproducesrc/core/version.cpp
Additional Informationhttps://doc.qt.io/qt-5/qtglobal.html [^]
Attached Files

- Relationships
related to 0003514closedZalewa Drop support for compiling with Qt4 (in favor of Qt5+) 
child of 0003499assignedPol M Port Doomseeker to OpenBSD 

-  Notes
User avatar (0020258)
WubTheCaptain (developer)
2018-12-17 04:16

Which ones are useful to us?
User avatar (0020261)
WubTheCaptain (developer)
2018-12-17 04:34
edited on: 2018-12-17 04:35

If we can drop support for Qt 4, we could also use QSysInfo functions such as QSysInfo::prettyProductName() instead of these definitions. Those were added in Qt 5.4.

https://doc.qt.io/qt-5/qsysinfo.html [^]

User avatar (0020694)
Pol M (developer)
2019-05-26 14:36
edited on: 2019-05-26 14:42

It would be OK to use QSysInfo::prettyProductName() as a fallback option for version.
The usage of operatingSystem is quite small, but I'd still leave the current implementation to not change its output on future versions. Using QSysInfo would give a more descriptive output on openBSD and other small OS.

User avatar (0020701)
Pol M (developer)
2019-05-28 16:27

Commit
There's not much to test, it simply works on OpenBSD and so. If you want to take the time to look at it, you'll find it on IRC by selecting the "CTCP Version" option on the right-click menu (select your own nick)

:)
User avatar (0020852)
Zalewa (developer)
2019-06-30 10:43

As you said Pol, there's not much to test. Resolving as done.
User avatar (0020855)
WubTheCaptain (developer)
2019-06-30 11:31
edited on: 2019-06-30 11:32

Doesn't this need #include <QSysInfo>?

User avatar (0020856)
Zalewa (developer)
2019-06-30 11:38

Apparently not, but I added it regardless.
https://bitbucket.org/Doomseeker/doomseeker/commits/d7dfe48e5b26de8509708f4ec535eeee9c7251d7 [^]

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-12-17 04:15 WubTheCaptain New Issue
2018-12-17 04:16 WubTheCaptain Relationship added child of 0003499
2018-12-17 04:16 WubTheCaptain Note Added: 0020258
2018-12-17 04:16 WubTheCaptain Assigned To => WubTheCaptain
2018-12-17 04:16 WubTheCaptain Status new => feedback
2018-12-17 04:18 WubTheCaptain Description Updated View Revisions
2018-12-17 04:18 WubTheCaptain Severity minor => tweak
2018-12-17 04:32 WubTheCaptain Description Updated View Revisions
2018-12-17 04:34 WubTheCaptain Note Added: 0020261
2018-12-17 04:34 WubTheCaptain Status feedback => assigned
2018-12-17 04:35 WubTheCaptain Note Edited: 0020261 View Revisions
2018-12-17 04:35 WubTheCaptain Note Edited: 0020261 View Revisions
2018-12-17 04:35 WubTheCaptain Status assigned => feedback
2018-12-17 04:36 WubTheCaptain Status feedback => new
2018-12-17 04:39 WubTheCaptain Relationship added related to 0003514
2019-05-20 15:38 Pol M Assigned To WubTheCaptain => Pol M
2019-05-20 15:38 Pol M Status new => assigned
2019-05-26 14:36 Pol M Note Added: 0020694
2019-05-26 14:42 Pol M Note Edited: 0020694 View Revisions
2019-05-28 16:27 Pol M Note Added: 0020701
2019-05-28 16:27 Pol M Status assigned => needs testing
2019-05-30 06:12 WubTheCaptain Target Version => 1.3
2019-06-30 10:43 Zalewa Note Added: 0020852
2019-06-30 10:43 Zalewa Status needs testing => resolved
2019-06-30 10:43 Zalewa Fixed in Version => 1.3
2019-06-30 10:43 Zalewa Resolution open => fixed
2019-06-30 11:31 WubTheCaptain Note Added: 0020855
2019-06-30 11:31 WubTheCaptain Status resolved => needs review
2019-06-30 11:31 WubTheCaptain Resolution fixed => reopened
2019-06-30 11:32 WubTheCaptain Note Edited: 0020855 View Revisions
2019-06-30 11:38 Zalewa Note Added: 0020856
2019-06-30 11:38 Zalewa Status needs review => resolved
2019-06-30 11:38 Zalewa Resolution reopened => fixed
2019-07-30 10:13 WubTheCaptain Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker