Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003580Doomseeker[All Projects] Cleanuppublic2018-12-17 04:072018-12-17 04:58
ReporterWubTheCaptain 
Assigned ToWubTheCaptain 
PrioritynormalSeveritytweakReproducibilityalways
Statusneeds reviewResolutionopen 
PlatformOSOS Version
Product Version1.2 
Target Version1.3Fixed in Version 
Summary0003580: Deprecated use of global Qt declaration Q_OS_MAC
DescriptionAll declarations of Q_OS_MAC and Q_OS_OSX are deprecated in Qt 5 (at least since Qt 5.6). There's few of them in Doomseeker and Zandronum plugin.

We should probably use Q_OS_DARWIN instead.
Steps To ReproduceIn 1.2 source root directory:

$ grep -r "Q_OS_MAC" .
./src/plugins/zandronum/zandronumbinaries.cpp:#ifndef Q_OS_MAC
./src/plugins/zandronum/zandronumbinaries.cpp:#ifdef Q_OS_MAC
./src/plugins/zandronum/zandronumbinaries.cpp:  #ifdef Q_OS_MAC
./src/plugins/zandronum/zandronumengineplugin.cpp:#if defined(Q_OS_WIN32) || defined(Q_OS_MAC)
./src/core/gui/widgets/serversstatuswidget.cpp:#ifndef Q_OS_MAC
./src/core/apprunner.h:#ifdef Q_OS_MAC
./src/core/version.cpp: #elif defined(Q_OS_MAC)
./src/core/apprunner.cpp:#ifdef Q_OS_MAC
./src/core/apprunner.cpp:       #ifdef Q_OS_MAC
./src/core/commandline.cpp:#ifdef Q_OS_MAC
./src/core/datapaths.cpp:#ifdef Q_OS_MAC
./src/core/datapaths.cpp:#if !defined(Q_OS_MAC)
./src/core/datapaths.cpp:#ifdef Q_OS_MAC
./src/core/datapaths.cpp:#if !defined(Q_OS_MAC) && !defined(Q_OS_WIN32)
./src/core/main.cpp:#ifdef Q_OS_MAC
./src/core/updater/updatechannel.cpp:#elif defined(Q_OS_MAC)
./src/core/updater/updateinstaller.cpp:#ifdef Q_OS_MAC
./src/core/updater/updatepackagefilter.cpp:#if !defined(Q_OS_MAC) || defined(__x86_64__)
$ grep -r "Q_OS_OSX" src/ | wc -l
0
Additional Informationhttps://doc.qt.io/qt-5/qtglobal.html#Q_OS_MAC [^]
Attached Filespatch file icon 0001-Replace-deprecated-Q_OS_MAC-definitions-from-Qt.patch [^] (8,172 bytes) 2018-12-17 04:28 [Show Content]

- Relationships

-  Notes
User avatar (0020259)
WubTheCaptain (developer)
2018-12-17 04:28

Patch by me, attached.

I've not tested with Darwin-based operating systems, especially against Qt 4.
User avatar (0020260)
WubTheCaptain (developer)
2018-12-17 04:29

find src/ -type f -print0 | xargs -0 sed -i 's/Q_OS_MAC/Q_OS_DARWIN/g'

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-12-17 04:07 WubTheCaptain New Issue
2018-12-17 04:07 WubTheCaptain Assigned To => WubTheCaptain
2018-12-17 04:07 WubTheCaptain Status new => assigned
2018-12-17 04:28 WubTheCaptain File Added: 0001-Replace-deprecated-Q_OS_MAC-definitions-from-Qt.patch
2018-12-17 04:28 WubTheCaptain Note Added: 0020259
2018-12-17 04:28 WubTheCaptain Status assigned => needs review
2018-12-17 04:28 WubTheCaptain Target Version => 1.3
2018-12-17 04:29 WubTheCaptain Note Added: 0020260
2018-12-17 04:36 WubTheCaptain Description Updated View Revisions
2018-12-17 04:57 WubTheCaptain Steps to Reproduce Updated View Revisions
2018-12-17 04:58 WubTheCaptain Steps to Reproduce Updated View Revisions






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker