Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003536Doomseeker[All Projects] Bugpublic2018-10-06 10:582018-10-13 16:55
ReporterWubTheCaptain 
Assigned ToPol M 
PrioritynormalSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
Platformamd64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.2 
Target Version1.2Fixed in Version1.2 
Summary0003536: Regression: Using --rcon is no longer supported by itself
DescriptionUsing --rcon by itself was added in hg changeset 382:41ddf4377133 (Tue Apr 13 22:31:16 2010 +0000) by Blzut3.

Since sometime in 1.2~beta, it now requires two parameters to use and there's now dead code lying around. This is a regression in functionality.
Steps To Reproduce
$ doomseeker --rcon # Doomseeker 1.1
[10:55:50] Starting Doomseeker. Hello World! :)
[10:55:50] Setting up data directories.
[10:55:50] Attempting to load plugins from directory: /home/wub/.doomseeker/engines
[10:55:50] Attempting to load plugins from directory: /usr/bin/engines
[10:55:50] Attempting to load plugins from directory: engines
[10:55:50] Attempting to load plugins from directory: /usr/share/doomseeker/engines
[10:55:50] Loaded plugin: "Zandronum"!
[10:55:50] Listening to Zandronum's LAN servers broadcasts on port 15101.
[10:55:50] Initializing configuration file.
[10:55:50] Setting INI file: /home/wub/.doomseeker/doomseeker.ini
[10:55:50] Loading translations definitions
[10:55:50] Loading translation "en_EN".
[10:55:50] Translation loaded.
[10:55:50] Initializing IP2C database.
[10:55:50] Initializing passwords configuration file.
[10:55:50] Initializing configuration for plugins.
[10:55:50] Initializing IRC configuration file.
[10:55:50] Setting IRC INI file: /home/wub/.doomseeker/doomseeker-irc.ini
[10:55:50] Starting RCon client.


$ doomseeker --rcon # Doomseeker 1.2~beta-181002-1931
doomseeker: expected 2 argument(s) in option --rcon

Available command line parameters:
[...]
Additional InformationPrevents testing of rcon dialog → "block" severity.
Attached Files

- Relationships
related to 0003373resolvedZalewa "No RCon support" dialog message is not printed to stderr 

-  Notes
User avatar (0019935)
Pol M (developer)
2018-10-06 11:33
edited on: 2018-10-06 11:41

This was done in this commit done by me. I'll remove the unnecessary stuff.
EDIT: oh, I was trying to achieve that when an option that required arguments was passed without them it failed. The affected options were "--connect", "--datadir" and "--rcon".
EDIT2: Based on the "--help" page, --datadir should also not error if no path is given.

User avatar (0019937)
Pol M (developer)
2018-10-06 11:55

pr
User avatar (0019956)
Zalewa (developer)
2018-10-06 17:25

PR merged through squash & rebase:https://bitbucket.org/Doomseeker/doomseeker/commits/12c46bcc9cf04f97452e5561154398b6fff68d1e [^]

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-10-06 10:58 WubTheCaptain New Issue
2018-10-06 10:58 WubTheCaptain Relationship added related to 0003373
2018-10-06 11:27 Pol M Assigned To => Pol M
2018-10-06 11:27 Pol M Status new => assigned
2018-10-06 11:33 Pol M Note Added: 0019935
2018-10-06 11:39 Pol M Note Edited: 0019935 View Revisions
2018-10-06 11:41 Pol M Note Edited: 0019935 View Revisions
2018-10-06 11:55 Pol M Note Added: 0019937
2018-10-06 11:55 Pol M Status assigned => needs review
2018-10-06 17:25 Zalewa Note Added: 0019956
2018-10-06 17:25 Zalewa Status needs review => needs testing
2018-10-06 18:02 WubTheCaptain Target Version => 1.2
2018-10-06 18:05 WubTheCaptain Status needs testing => resolved
2018-10-06 18:05 WubTheCaptain Fixed in Version => 1.2
2018-10-06 18:05 WubTheCaptain Resolution open => fixed
2018-10-13 16:55 WubTheCaptain Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker