Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003493Doomseeker[All Projects] Bugpublic2018-09-15 22:092018-10-12 13:15
ReporterPol M 
Assigned ToPol M 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformLinuxOSArchOS Versionx86-64
Product Version1.2 
Target Version1.2Fixed in Version1.2 
Summary0003493: texts like "Server filter" and "Buddies" aren't being translated.
DescriptionWhile doing tests, I've encountered some strings that are not being translated.
There are two places where I originally noticed they are not being translated:
  • the text that appears when you put your mouse over the "Server filter" button located over the server list
  • the button in the menu "View"


Previous to the commits related to language translations, the text did translate to Polish.
Steps To Reproduce
  1. Compile the latest commit (1b09978)
  2. Open Doomseeker, change the language to Spanish/Polish
  3. Restart Doomseeker, check the two strings
Additional InformationThe following images show:
# 1: previous to the changes
# 2: after the changes
Attached Filespng file icon Doomseeker - translation #1.png [^] (667,462 bytes) 2018-09-15 22:09
png file icon Doomseeker - translation #2.png [^] (668,057 bytes) 2018-09-15 22:09

- Relationships

-  Notes
User avatar (0019528)
Pol M (developer)
2018-09-15 22:11

Ok, It seems like this affects more texts. Gonna rewrite the title.
User avatar (0019529)
Pol M (developer)
2018-09-15 22:15

Version of Qt: 5.11.1
User avatar (0019531)
Pol M (developer)
2018-09-16 09:36
edited on: 2018-09-16 09:37

Ok, It turns out that there is, in fact, lots of texts not being translated, based on the output of cmake .. -DUPDATE_TRANSLATIONS=ON; make:https://pastebin.com/ErAzzE6P [^]

I think I'm gonna make this issue "major"

User avatar (0019532)
Zalewa (developer)
2018-09-16 11:38

One thing to keep in mind here is that Wadseeker lib doesn't have translations and any strings that come out of it will be untranslated. This is something that we haven't dealt with so far, but should be considered as a "missing feature" rather than as a bug.
User avatar (0019533)
Pol M (developer)
2018-09-16 12:22
edited on: 2018-09-16 12:24

the errors mentioned come from the "core", but I'll take a quick look at the Wadseeker lib.

EDIT: For what I've had time to read, this seems like an error of the tool that generates the translation files, and it seems that there are workarounds to solve those.

User avatar (0019534)
Zalewa (developer)
2018-09-16 14:14
edited on: 2018-09-16 14:14

Another 2 things:

1. tr() will only actually work in a subclass that inherits from QObject
2. Q_OBJECT macro must be present in that class declaration.

Lack of any of those, or using a compilation workaround such as "QObject::tr()" will result in a non-functional translation.

User avatar (0019629)
Zalewa (developer)
2018-09-22 11:06

Missing tr() call found in createserverdialog.cpp here:https://bitbucket.org/Doomseeker/doomseeker/src/365d5abf3b5a3c10c1dd01114b6d21572c6cb5aa/src/core/gui/createserverdialog.cpp#lines-93 [^]
User avatar (0020075)
Pol M (developer)
2018-10-11 16:37

Okay, I've narrowed down the issue. the files that give an "tr() cannot be called without context" are:
/home/pol/Documents/doomseeker/src/core/gui/serverfilterdock.cpp:61
/home/pol/Documents/doomseeker/src/core/gui/serverfilterdock.cpp:62
/home/pol/Documents/doomseeker/src/core/gui/remoteconsole.cpp:68
/home/pol/Documents/doomseeker/src/core/gui/remoteconsole.cpp:68
/home/pol/Documents/doomseeker/src/core/gui/remoteconsole.cpp:83
/home/pol/Documents/doomseeker/src/core/gui/remoteconsole.cpp:83
/home/pol/Documents/doomseeker/src/core/gui/mainwindow.cpp:236
/home/pol/Documents/doomseeker/src/core/gui/mainwindow.cpp:238
/home/pol/Documents/doomseeker/src/core/gui/mainwindow.cpp:246
/home/pol/Documents/doomseeker/src/core/gui/mainwindow.cpp:247
/home/pol/Documents/doomseeker/src/core/gui/dockBuddiesList.cpp:84
/home/pol/Documents/doomseeker/src/core/gui/dockBuddiesList.cpp:85
/home/pol/Documents/doomseeker/src/core/gui/dockBuddiesList.cpp:86
/home/pol/Documents/doomseeker/src/core/gui/createserver/maplistpanel.cpp:52
/home/pol/Documents/doomseeker/src/core/gui/configuration/cfgwadalias.cpp:67
/home/pol/Documents/doomseeker/src/core/gui/configuration/cfgwadalias.cpp:70
/home/pol/Documents/doomseeker/src/core/gui/configuration/cfgfilepaths.cpp:48
/home/pol/Documents/doomseeker/src/core/gui/configuration/cfgfilepaths.cpp:48
Most (if not all) of these errors can be resolved specifing the class: for instance, in mainwindow.cpp: tr becomes MainWindow::tr
This happens only in constructors.
there are also warnings saying "Qualifying with unknown namespace/class" but they do get translated and I can't seem to find what is wrong with them.
I'd assume that this is simply lupdate getting a little bit confused.
User avatar (0020076)
Pol M (developer)
2018-10-11 16:58

pr
User avatar (0020079)
Zalewa (developer)
2018-10-11 18:16

Pol, did you happen to find any explanation on why this occurs? The closest I could find was a bug report for C++11 initialization lists which shouldn't affect us:https://bugreports.qt.io/browse/QTBUG-34128 [^]
User avatar (0020080)
Pol M (developer)
2018-10-11 18:40
edited on: 2018-10-11 18:40

I also did encounter that same bug report. No clue, I do not understand why it affects us.
I have not tried to update translations with an older Qt5, so the possibility of this being a recent change to lupdate is not yet discarded. I wish I knew more.

I'm gonna look into it for the moment

User avatar (0020082)
Pol M (developer)
2018-10-11 19:15

My hypothesis was correct. I've run a Pipeline (since it uses Ubuntu 14.04, we can assume it uses an older version of qt):
https://bitbucket.org/Pol_M/doomseeker/addon/pipelines/home#!/results/27 [^]

This did not used to happen (as we can see that it only gives "Qualifying with unknown namespace/class" warnings), but since 5.11 (or before), it fails.
User avatar (0020083)
Zalewa (developer)
2018-10-11 19:22

I use 5.7.0 and it happens for me too.

Well, this framework was never free of bugs. I suppose all we can do is deal with it. For now I can confirm that your patch fixes at least the "View" menu and the main toolstrip buttons.
User avatar (0020084)
Pol M (developer)
2018-10-11 19:26
edited on: 2018-10-11 19:28

Quote from Zalewa

I suppose all we can do is deal with it.

Pretty much.
Should this be reported upstream?

Quote from Zalewa

For now I can confirm that your patch fixes at least the "View" menu and the main toolstrip buttons.

And it successfuly generates the missing lines in my machine

User avatar (0020085)
Zalewa (developer)
2018-10-11 19:28

If you wish to do so then, please, be my guest.
User avatar (0020086)
Pol M (developer)
2018-10-12 13:15

commit:https://bitbucket.org/Doomseeker/doomseeker/commits/ecbd3c8cf4de45a97b68f35fc776e5e5fe95de74 [^]

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-09-15 22:09 Pol M New Issue
2018-09-15 22:09 Pol M File Added: Doomseeker - translation #1.png
2018-09-15 22:09 Pol M File Added: Doomseeker - translation #2.png
2018-09-15 22:11 Pol M Note Added: 0019528
2018-09-15 22:13 Pol M Summary "Server filter" text not being translated. => "Server filter", "Buddies" texts not being translated.
2018-09-15 22:13 Pol M Description Updated View Revisions
2018-09-15 22:13 Pol M Additional Information Updated View Revisions
2018-09-15 22:15 Pol M Note Added: 0019529
2018-09-15 22:32 Pol M Assigned To => Pol M
2018-09-15 22:32 Pol M Status new => assigned
2018-09-15 22:36 Pol M Status assigned => new
2018-09-16 09:36 Pol M Note Added: 0019531
2018-09-16 09:37 Pol M Note Edited: 0019531 View Revisions
2018-09-16 09:56 Pol M Status new => assigned
2018-09-16 09:56 Pol M Summary "Server filter", "Buddies" texts not being translated. => texts like "Server filter" and "Buddies" aren't being translated.
2018-09-16 09:56 Pol M Description Updated View Revisions
2018-09-16 09:56 Pol M Severity minor => major
2018-09-16 09:56 Pol M Assigned To Pol M =>
2018-09-16 09:57 Pol M Assigned To => Pol M
2018-09-16 09:57 Pol M Status assigned => new
2018-09-16 09:57 Pol M Assigned To Pol M =>
2018-09-16 11:38 Zalewa Note Added: 0019532
2018-09-16 12:22 Pol M Note Added: 0019533
2018-09-16 12:24 Pol M Note Edited: 0019533 View Revisions
2018-09-16 14:14 Zalewa Note Added: 0019534
2018-09-16 14:14 Zalewa Note Edited: 0019534 View Revisions
2018-09-18 11:45 WubTheCaptain Status new => confirmed
2018-09-22 11:06 Zalewa Note Added: 0019629
2018-10-11 16:37 Pol M Note Added: 0020075
2018-10-11 16:37 Pol M Assigned To => Pol M
2018-10-11 16:37 Pol M Status confirmed => assigned
2018-10-11 16:58 Pol M Note Added: 0020076
2018-10-11 16:59 Pol M Status assigned => needs review
2018-10-11 18:09 WubTheCaptain Target Version => 1.2
2018-10-11 18:10 WubTheCaptain Description Updated View Revisions
2018-10-11 18:10 WubTheCaptain Steps to Reproduce Updated View Revisions
2018-10-11 18:10 WubTheCaptain Steps to Reproduce Updated View Revisions
2018-10-11 18:16 Zalewa Note Added: 0020079
2018-10-11 18:40 Pol M Note Added: 0020080
2018-10-11 18:40 Pol M Note Edited: 0020080 View Revisions
2018-10-11 19:15 Pol M Note Added: 0020082
2018-10-11 19:22 Zalewa Note Added: 0020083
2018-10-11 19:26 Pol M Note Added: 0020084
2018-10-11 19:28 Zalewa Note Added: 0020085
2018-10-11 19:28 Pol M Note Edited: 0020084 View Revisions
2018-10-12 13:15 Pol M Note Added: 0020086
2018-10-12 13:15 Pol M Status needs review => resolved
2018-10-12 13:15 Pol M Fixed in Version => 1.2
2018-10-12 13:15 Pol M Resolution open => fixed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker