Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003473Zandronum[All Projects] Bugpublic2018-08-29 20:182024-03-01 05:37
ReporterMr. Satan 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusconfirmedResolutionbackport later 
PlatformMicrosoftOSWindowsOS Version7/8/10
Product Version3.0 
Target VersionFixed in Version 
Summary0003473: CheckClass ACS function is broken
DescriptionUsing the ACS function CheckClass in a script always return 0.
Steps To ReproduceDownload CheckClass test.pk3. Load it in Zandro. "Puke 999" in console window.
Additional InformationStill broken in Zandro 3.1
Attached Files? file icon CheckClass test.pk3 [^] (622 bytes) 2018-08-29 20:18
png file icon Screenshot_Doom_20180910_163853.png [^] (1,035,889 bytes) 2018-09-10 20:43
png file icon Screenshot_Doom_20180910_164550.png [^] (1,228,315 bytes) 2018-09-10 20:47

- Relationships

-  Notes
User avatar (0019495)
Korshun (reporter)
2018-09-07 20:50
edited on: 2018-09-07 20:51

 You are trying to use CheckClass where you should have used CheckInventory
User avatar (0019497)
Mr. Satan (reporter)
2018-09-10 09:17

 In Zdoom/GZDoom it returns 1. According to the wiki, this function should return 1 if the Class is valid/exists, 0 if it doesn't. It doesn't use a TID to check a specific player/thing. 'https://zdoom.org/wiki/CheckClass_(ACS) [^]'
User avatar (0019498)
Ivan (reporter)
2018-09-10 11:07

 Uhh you realize that still isn't the intended use for the CheckClass function right? CheckClass compares the class of the activator vs. what is given as input... None of them can be the player as they are inventory items... Add "CheckClass("PlayerPawn")" in there and it should show you 1.
User avatar (0019501)
Mr. Satan (reporter)
2018-09-10 20:54

 Check out the two screencaps one is from Zandro and the other one is from GZDoom. GZDoom returns 1 if the class exists. Zandro returns 0 for all even PlayerPawn. If CheckClass simply compared the activator's class to the the inputted class it would be the same as CheckActorClass using 0 as the TID.
User avatar (0019503)
Edward-san (developer)
2018-09-10 21:57
edited on: 2018-09-10 22:00

 Of course it'll always print 0. CheckClass isn't implemented in Zandronum 3.0 at all, anyway.
User avatar (0019504)
Korshun (reporter)
2018-09-11 14:11

 I am sorry for my misleading comments. ZDoom documentation is confusing. You are using CheckClass the right way, but it's not implemented in GZDoom 1.8.6, on which Zandronum 3.1 is based. Unimplemented ACS functions always return 0.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: Mr. Satan
Opponents: eagle Korshun

- Issue History
Date Modified Username Field Change
2018-08-29 20:18 Mr. Satan New Issue
2018-08-29 20:18 Mr. Satan File Added: CheckClass test.pk3
2018-09-07 20:50 Korshun Note Added: 0019495
2018-09-07 20:51 Korshun Note Edited: 0019495 View Revisions
2018-09-10 09:17 Mr. Satan Note Added: 0019497
2018-09-10 11:07 Ivan Note Added: 0019498
2018-09-10 20:43 Mr. Satan File Added: Screenshot_Doom_20180910_163853.png
2018-09-10 20:47 Mr. Satan File Added: Screenshot_Doom_20180910_164550.png
2018-09-10 20:54 Mr. Satan Note Added: 0019501
2018-09-10 21:57 Edward-san Note Added: 0019503
2018-09-10 21:59 Edward-san Note Edited: 0019503 View Revisions
2018-09-10 22:00 Edward-san Note Edited: 0019503 View Revisions
2018-09-11 14:11 Korshun Note Added: 0019504
2024-03-01 05:37 Ru5tK1ng Status new => confirmed
2024-03-01 05:37 Ru5tK1ng Resolution open => backport later




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker