|Anonymous | Login | Signup for a new account||2019-07-22 05:47 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003463||Doomseeker||UI||public||2018-08-24 03:08||2019-07-20 06:30|
|Assigned To||Pol M|
|Target Version||1.3||Fixed in Version|
|Summary||0003463: Engine icons have too much right margin in server view list|
|Description||Engine icons are rendered something like 15x15 or 21x21 for me, but the total size of the engine column is 26x21 with the empty 5 px wide bounding box on the right side of it. See attachment.|
|Steps To Reproduce||Load Doomseeker with any engine plugin. Receive any server from an active master server for that engine.|
|Additional Information||This may need another bug about the way those icons are handled (a probable hack, like 0003461).|
|Attached Files|| 3463.png [^] (6,722 bytes) 2018-08-24 03:08
2018-08-24-032832_402x133_scrot.png [^] (8,690 bytes) 2018-08-24 03:28
doomseeker.ini [^] (6,378 bytes) 2018-08-24 03:33
edited on: 2018-08-24 03:35
This can be even worse with a broken state (0003411), and the engine column is not resizable by default. Attaching another screenshot.
Attached doomseeker.ini config (with corrupted state) should replicate the issue (second screenshot) at least on 1.2. NB: I've not created the bug conditions consciously, it happened a long time ago.
|This issue has not seen activity in a while; can anyone confirm or acknowledge this issue?|
\I fail to understand problem here.
Picture with some paint/gimp red ring where the problem is.
Pol M (developer)
|The extra size on the right side of the icons seems to be slightly theme dependant, but it's present.|
Pol M (developer)
I merged the PR. The PR fixes the issues with fixed column sizes becoming invalid, but it doesn't fix the problem with extra space.
We actually set a 24x24 icon onto the cell, but it appears that the table widget itself is then free to shrink it to fit the row with correct aspect ratio. On Windows the icon is reduced to about 20x20 and I also have those several pixels of extra space. I'm not sure if it's possible for the icon to become upscaled by the widget to more than 24x24. If yes then our current "fixed width" mode for the icon column will result in the icon being cropped.
Pol M (developer)
|Ok, I'll look into it, maybe a QHeaderView::ResizeToContents (in serverlistview.cpp:190) will do the trick. I'll also take a look at those 20x20 icons on windows.|
|Just to be explicit here: minimal icon shrinking that is happening here is actually desirable as other factors that decide on the row height (such as text size, or OS style preferences) are more important. The icon should adjust to the row height, not the other way around.|
The PR that changes the column to fit to contents is merged here.
Even with this PR, the focus rectangle was still showing (albeit it was like 3 pixels in size). I have removed it with yet another CustomItemDelegate hack. It's also removed from the players column which fixes 0003461.
|WubTheCaptain can you have the final say on the current state of this? I was not affected by this issue (or rather, I didn't notice anything that would bother me).|
|Only registered users can voice their support. Click here to register, or here to log in.|
|Supporters:||No one explicitly supports this issue yet.|
|Opponents:||No one explicitly opposes this issue yet.|
|2018-08-24 03:08||WubTheCaptain||New Issue|
|2018-08-24 03:08||WubTheCaptain||File Added: 3463.png|
|2018-08-24 03:27||WubTheCaptain||Note Added: 0019395|
|2018-08-24 03:28||WubTheCaptain||File Added: 2018-08-24-032832_402x133_scrot.png|
|2018-08-24 03:30||WubTheCaptain||Relationship added||related to 0003411|
|2018-08-24 03:33||WubTheCaptain||File Added: doomseeker.ini|
|2018-08-24 03:34||WubTheCaptain||Note Edited: 0019395||View Revisions|
|2018-08-24 03:35||WubTheCaptain||Note Edited: 0019395||View Revisions|
|2018-09-27 03:23||WubTheCaptain||Relationship deleted||related to 0003411|
|2018-10-05 06:36||WubTheCaptain||Priority||normal => low|
|2018-12-04 00:38||WubTheCaptain||Category||Bug => UI|
|2019-04-19 18:31||WubTheCaptain||Note Added: 0020510|
|2019-04-19 18:52||Filystea||Note Added: 0020513|
|2019-04-20 12:25||Pol M||Note Added: 0020519|
|2019-04-20 12:25||Pol M||Assigned To||=> Pol M|
|2019-04-20 12:25||Pol M||Status||new => confirmed|
|2019-04-20 12:25||Pol M||Assigned To||Pol M =>|
|2019-06-05 14:14||Pol M||Assigned To||=> Pol M|
|2019-06-05 14:14||Pol M||Status||confirmed => assigned|
|2019-06-05 14:56||Pol M||Note Added: 0020724|
|2019-06-05 14:57||Pol M||Status||assigned => needs review|
|2019-06-20 10:51||Zalewa||Note Added: 0020782|
|2019-06-20 11:36||Zalewa||Status||needs review => needs testing|
|2019-06-20 21:36||Pol M||Note Added: 0020786|
|2019-06-21 14:47||Zalewa||Note Added: 0020788|
|2019-06-21 20:56||WubTheCaptain||Target Version||=> 1.3|
|2019-06-23 09:41||Zalewa||Status||needs testing => assigned|
|2019-06-25 21:41||Zalewa||Note Added: 0020839|
|2019-06-25 21:41||Zalewa||Status||assigned => needs testing|
|2019-07-20 06:30||Zalewa||Note Added: 0020897|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2019 MantisBT Team|