Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003463DoomseekerUIpublic2018-08-24 03:082019-07-30 10:13
ReporterWubTheCaptain 
Assigned ToPol M 
PrioritylowSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1 
Target Version1.3Fixed in Version1.3 
Summary0003463: Engine icons have too much right margin in server view list
DescriptionEngine icons are rendered something like 15x15 or 21x21 for me, but the total size of the engine column is 26x21 with the empty 5 px wide bounding box on the right side of it. See attachment.
Steps To ReproduceLoad Doomseeker with any engine plugin. Receive any server from an active master server for that engine.
Additional InformationThis may need another bug about the way those icons are handled (a probable hack, like 0003461).
Attached Filespng file icon 3463.png [^] (6,722 bytes) 2018-08-24 03:08


png file icon 2018-08-24-032832_402x133_scrot.png [^] (8,690 bytes) 2018-08-24 03:28


? file icon doomseeker.ini [^] (6,378 bytes) 2018-08-24 03:33

- Relationships

-  Notes
User avatar (0019395)
WubTheCaptain (reporter)
2018-08-24 03:27
edited on: 2018-08-24 03:35

 This can be even worse with a broken state (0003411), and the engine column is not resizable by default. Attaching another screenshot.

Attached doomseeker.ini config (with corrupted state) should replicate the issue (second screenshot) at least on 1.2. NB: I've not created the bug conditions consciously, it happened a long time ago.
User avatar (0020510)
WubTheCaptain (reporter)
2019-04-19 18:31

 This issue has not seen activity in a while; can anyone confirm or acknowledge this issue?
User avatar (0020513)
Filystea (reporter)
2019-04-19 18:52

 \I fail to understand problem here.

Picture with some paint/gimp red ring where the problem is.
User avatar (0020519)
Pol M (developer)
2019-04-20 12:25

 The extra size on the right side of the icons seems to be slightly theme dependant, but it's present.
User avatar (0020724)
Pol M (developer)
2019-06-05 14:56

 PR
User avatar (0020782)
Zalewa (developer)
2019-06-20 10:51

 I merged the PR. The PR fixes the issues with fixed column sizes becoming invalid, but it doesn't fix the problem with extra space.

We actually set a 24x24 icon onto the cell, but it appears that the table widget itself is then free to shrink it to fit the row with correct aspect ratio. On Windows the icon is reduced to about 20x20 and I also have those several pixels of extra space. I'm not sure if it's possible for the icon to become upscaled by the widget to more than 24x24. If yes then our current "fixed width" mode for the icon column will result in the icon being cropped.
User avatar (0020786)
Pol M (developer)
2019-06-20 21:36

 Ok, I'll look into it, maybe a QHeaderView::ResizeToContents (in serverlistview.cpp:190) will do the trick. I'll also take a look at those 20x20 icons on windows.
User avatar (0020788)
Zalewa (developer)
2019-06-21 14:47

 Just to be explicit here: minimal icon shrinking that is happening here is actually desirable as other factors that decide on the row height (such as text size, or OS style preferences) are more important. The icon should adjust to the row height, not the other way around.
User avatar (0020839)
Zalewa (developer)
2019-06-25 21:41

 The PR that changes the column to fit to contents is merged here.

Even with this PR, the focus rectangle was still showing (albeit it was like 3 pixels in size). I have removed it with yet another CustomItemDelegate hack. It's also removed from the players column which fixes 0003461.
User avatar (0020897)
Zalewa (developer)
2019-07-20 06:30

 WubTheCaptain can you have the final say on the current state of this? I was not affected by this issue (or rather, I didn't notice anything that would bother me).
User avatar (0020903)
WubTheCaptain (reporter)
2019-07-22 09:09

 The focus rectangle is gone, so that part doesn't bother me anymore. The underlying problem in OP might still be an issue; consider a sub-issue of this resolved for the time being (create a new issue for this, if you'd like).

Pol M (having taken responsibility) should decide if this issue is resolved.
User avatar (0020907)
Pol M (developer)
2019-07-22 11:45
edited on: 2019-07-22 11:46

 I've decided to re-add the code that setted the minimumSectionSize of the table because while testing I found that with some themes it liked to get big sizes.
PR

The underlying problem with this is gone. If this gets approved, I'll set this to resolved.
User avatar (0020910)
Pol M (developer)
2019-07-22 19:01

 Approved by Zalewa, setting as resolved

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-08-24 03:08 WubTheCaptain New Issue
2018-08-24 03:08 WubTheCaptain File Added: 3463.png
2018-08-24 03:27 WubTheCaptain Note Added: 0019395
2018-08-24 03:28 WubTheCaptain File Added: 2018-08-24-032832_402x133_scrot.png
2018-08-24 03:30 WubTheCaptain Relationship added related to 0003411
2018-08-24 03:33 WubTheCaptain File Added: doomseeker.ini
2018-08-24 03:34 WubTheCaptain Note Edited: 0019395 View Revisions
2018-08-24 03:35 WubTheCaptain Note Edited: 0019395 View Revisions
2018-09-27 03:23 WubTheCaptain Relationship deleted related to 0003411
2018-10-05 06:36 WubTheCaptain Priority normal => low
2018-12-04 00:38 WubTheCaptain Category Bug => UI
2019-04-19 18:31 WubTheCaptain Note Added: 0020510
2019-04-19 18:52 Filystea Note Added: 0020513
2019-04-20 12:25 Pol M Note Added: 0020519
2019-04-20 12:25 Pol M Assigned To => Pol M
2019-04-20 12:25 Pol M Status new => confirmed
2019-04-20 12:25 Pol M Assigned To Pol M =>
2019-06-05 14:14 Pol M Assigned To => Pol M
2019-06-05 14:14 Pol M Status confirmed => assigned
2019-06-05 14:56 Pol M Note Added: 0020724
2019-06-05 14:57 Pol M Status assigned => needs review
2019-06-20 10:51 Zalewa Note Added: 0020782
2019-06-20 11:36 Zalewa Status needs review => needs testing
2019-06-20 21:36 Pol M Note Added: 0020786
2019-06-21 14:47 Zalewa Note Added: 0020788
2019-06-21 20:56 WubTheCaptain Target Version => 1.3
2019-06-23 09:41 Zalewa Status needs testing => assigned
2019-06-25 21:41 Zalewa Note Added: 0020839
2019-06-25 21:41 Zalewa Status assigned => needs testing
2019-07-20 06:30 Zalewa Note Added: 0020897
2019-07-22 08:55 WubTheCaptain Assigned To Pol M => WubTheCaptain
2019-07-22 09:09 WubTheCaptain Note Added: 0020903
2019-07-22 09:09 WubTheCaptain Assigned To WubTheCaptain => Pol M
2019-07-22 09:09 WubTheCaptain Status needs testing => needs review
2019-07-22 11:45 Pol M Note Added: 0020907
2019-07-22 11:46 Pol M Note Edited: 0020907 View Revisions
2019-07-22 19:01 Pol M Note Added: 0020910
2019-07-22 19:02 Pol M Status needs review => resolved
2019-07-22 19:02 Pol M Fixed in Version => 1.3
2019-07-22 19:02 Pol M Resolution open => fixed
2019-07-30 10:13 WubTheCaptain Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker