Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003461DoomseekerUIpublic2018-08-24 01:292018-12-04 00:40
ReporterWubTheCaptain 
Assigned To 
PrioritylowSeveritytrivialReproducibilityalways
StatusnewResolutionopen 
Platformx86_64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target VersionFixed in Version 
Summary0003461: Right aligning decoration images/user roles (player slot styles) is done with a CustomItemDelegate hack
DescriptionThe issue related to this hack is probably best to be explained with a screenshot, attached.

For an introduction: Player slots are right-aligned in the server list view table ("Servers"). Some ancient code in Doomseeker handles this with CustomItemDelegate painting.

The width of player block slots is 168 px wide in this case (second column in the screenshot), or 24 players. The "bounding box" (for a lack of better word... the small border around it) for this is 289 px wide, both aligned to right. There is approximately 174 px of free space on the left side of that in the screenshot, which is not part of the bounding box that would normally fill the whole width of the selected column. Coincidentally, this free space happens to be the width of the player block slot plus margin/padding.

In other words, 2-player slots experience very wide "bounding box" while larger, up to 64-player slots receive very small ones (sometimes not visible) – the very reverse of what's intended, although full width would make more sense too. A server which cannot be reached (0 player slots, not shown in screenshot) has the full width, as expected.
Steps To ReproduceTo reproduce the effects similar to the one in the screenshot:

  1. (Make sure Doomseeker is built with a recent enough Qt, probably Qt5 at least.)
  2. Start Doomseeker.
  3. (If the Servers list is not visible for whatever the reason, right click in the top navigation or main toolbar and check "Servers". This should not happen, as it should always be enabled and normally cannot be unchecked.)
  4. Click on the players column for any server received from a master server (Internet connection), or a Custom Server (any, added from configuration). The server must be reachable.
Additional InformationThis is a hack from a very long ago (2009–2011 or earlier).

Quote from src/core/gui/widgets/serverlistview.cpp
// If the row is selected and we are using the right aligned feature
// we must now redraw the decoration.  The rectangle that was used
// in the previous function will cause the image to clip.
//
// The only other way I can think of for fixing that problem would
// be to completely rewrite this class, which I really don't want
// to do.


Qt 5.11 used in the screenshot. Found in Doomseeker 1.1 and 1.2~beta-180821-1617M.
Attached Filespng file icon 3461.png [^] (7,933 bytes) 2018-08-24 01:30


png file icon 3461-hint.png [^] (13,059 bytes) 2018-08-24 02:16


png file icon 3461-hint-2.png [^] (17,900 bytes) 2018-08-24 02:24

- Relationships
related to 0003462new Right aligned player slots are missing 3 px right margin in server list view's column 

-  Notes
User avatar (0019393)
WubTheCaptain (developer)
2018-08-24 02:17
edited on: 2018-08-24 02:33

For better accessibility, I've also attached a photo manipulation (3461-hint.png) which displays the "bounding box" with a gradient of stripes.

3461-hint-2.png shows the left margin of the bounding box is the same as the width of the slots (as if they were left-aligned).

For clarification, the stripes should be the full width of the column but this hack paints them wrongly.

User avatar (0019394)
WubTheCaptain (developer)
2018-08-24 02:39
edited on: 2018-08-24 02:41

Also there's no margin whatsoever on the right side of slots due to this hack (?). Expected 3 px.


Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-08-24 01:29 WubTheCaptain New Issue
2018-08-24 01:30 WubTheCaptain File Added: 3461.png
2018-08-24 01:30 WubTheCaptain Additional Information Updated View Revisions
2018-08-24 01:32 WubTheCaptain Description Updated View Revisions
2018-08-24 01:35 WubTheCaptain Description Updated View Revisions
2018-08-24 01:38 WubTheCaptain Description Updated View Revisions
2018-08-24 01:38 WubTheCaptain Description Updated View Revisions
2018-08-24 01:40 WubTheCaptain Additional Information Updated View Revisions
2018-08-24 02:15 WubTheCaptain File Added: 3461-hint.png
2018-08-24 02:15 WubTheCaptain File Deleted: 3461-hint.png
2018-08-24 02:16 WubTheCaptain File Added: 3461-hint.png
2018-08-24 02:17 WubTheCaptain Note Added: 0019393
2018-08-24 02:17 WubTheCaptain Note Edited: 0019393 View Revisions
2018-08-24 02:24 WubTheCaptain File Added: 3461-hint-2.png
2018-08-24 02:26 WubTheCaptain Note Edited: 0019393 View Revisions
2018-08-24 02:26 WubTheCaptain Note Edited: 0019393 View Revisions
2018-08-24 02:33 WubTheCaptain Note Edited: 0019393 View Revisions
2018-08-24 02:39 WubTheCaptain Note Added: 0019394
2018-08-24 02:41 WubTheCaptain Note Edited: 0019394 View Revisions
2018-08-24 02:48 WubTheCaptain Description Updated View Revisions
2018-08-24 02:52 WubTheCaptain Relationship added related to 0003462
2018-10-05 06:36 WubTheCaptain Priority normal => low
2018-12-04 00:40 WubTheCaptain Category Bug => UI






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker