|Anonymous | Login | Signup for a new account||2019-03-20 15:21 UTC|
|My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003433||Zandronum||[All Projects] Bug||public||2018-06-02 22:52||2018-10-19 21:52|
|Assigned To||Torr Samaho|
|Target Version||Fixed in Version|
|Summary||0003433: Backport of GZDoom's model interpolation fixes. (Patch supplied)|
|Description||In GZDoom, dpJudas committed some fixes to the horribly broken interpolation code it inherited from Zandronum. (The interpolation was incredibly jittery and only operated at 35fps)|
I backported those fixes, adjusted them to work with Zan's older code, and made a patch. It'll be attached to this report.
|Attached Files||InterpolationFix.patch [^] (6,386 bytes) 2018-06-02 22:52 [Show Content]|
edited on: 2018-06-03 23:03
Argh, forgot to remove GetTimeFloat in gl_models.cpp. It's not needed anymore.
Aside from that, the patch worked as I intended, the models will interpolate at the full uncapped framerate.
Also, in the patch, I listed all gzdoom commits I pulled changes from.
Torr Samaho (administrator)
|Thanks for the patch. One quick question: There is an existing call to I_GetTimeFrac in gl_scene.cpp that doesn't seem to be adjusted by your patch. Is this intentional?|
|Not sure. Where at? Got a line number?|
Torr Samaho (administrator)
|It's line 1029 in gl_scene.cpp.|
edited on: 2018-10-02 22:15
The only thing I can find is this commit:https://github.com/coelckers/gzdoom/commit/cf44d2e37a85fa1f4687be135256680e6e055e5e [^]
I haven't seen any ill behavior from not having this (I wasn't aware of it, thus why it was missing in the patch), but it might be a good idea to have it as well, just in case.
If you'd like, I can try to bring in this change, and test it, and if it's good, add it to my patch. Shall I do this?
|Awaiting a response. (Not to be impatient, just want to know what I should be doing.)|
|Only registered users can voice their support. Click here to register, or here to log in.|
|Opponents:||No one explicitly opposes this issue yet.|
|2018-06-02 22:52||StrikerMan780||New Issue|
|2018-06-02 22:52||StrikerMan780||File Added: InterpolationFix.patch|
|2018-06-02 23:40||StrikerMan780||Note Added: 0019263|
|2018-06-03 10:11||StrikerMan780||Note Edited: 0019263||View Revisions|
|2018-06-03 23:03||StrikerMan780||Note Edited: 0019263||View Revisions|
|2018-06-24 13:39||Torr Samaho||Note Added: 0019281|
|2018-06-24 13:39||Torr Samaho||Assigned To||=> Torr Samaho|
|2018-06-24 13:39||Torr Samaho||Status||new => feedback|
|2018-07-14 03:08||StrikerMan780||Note Added: 0019289|
|2018-07-14 03:08||StrikerMan780||Status||feedback => assigned|
|2018-07-22 19:05||Torr Samaho||Note Added: 0019291|
|2018-08-05 20:40||StrikerMan780||Note Added: 0019311|
|2018-08-05 20:42||StrikerMan780||Note Edited: 0019311||View Revisions|
|2018-10-02 22:15||StrikerMan780||Note Edited: 0019311||View Revisions|
|2018-10-19 21:52||StrikerMan780||Note Added: 0020138|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2019 MantisBT Team|