Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003433Zandronum[All Projects] Bugpublic2018-06-02 22:522020-04-29 01:20
ReporterStrikerMan780 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusassignedResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0 
Target VersionFixed in Version 
Summary0003433: Backport of GZDoom's model interpolation fixes. (Patch supplied)
DescriptionIn GZDoom, dpJudas committed some fixes to the horribly broken interpolation code it inherited from Zandronum. (The interpolation was incredibly jittery and only operated at 35fps)

I backported those fixes, adjusted them to work with Zan's older code, and made a patch. It'll be attached to this report.
Attached Filespatch file icon InterpolationFix.patch [^] (6,386 bytes) 2018-06-02 22:52 [Show Content]
patch file icon InterpolationFix_v2.patch [^] (6,929 bytes) 2019-10-15 05:11 [Show Content]
patch file icon InterpolationFix_v3.patch [^] (1,324 bytes) 2019-11-05 21:14 [Show Content]
patch file icon InterpolationFix_v3_commented.patch [^] (1,399 bytes) 2020-04-19 22:39 [Show Content]

- Relationships

-  Notes
User avatar (0019263)
StrikerMan780 (reporter)
2018-06-02 23:40
edited on: 2018-06-03 23:03

Argh, forgot to remove GetTimeFloat in gl_models.cpp. It's not needed anymore.

Aside from that, the patch worked as I intended, the models will interpolate at the full uncapped framerate.

Also, in the patch, I listed all gzdoom commits I pulled changes from.

User avatar (0019281)
Torr Samaho (administrator)
2018-06-24 13:39

Thanks for the patch. One quick question: There is an existing call to I_GetTimeFrac in gl_scene.cpp that doesn't seem to be adjusted by your patch. Is this intentional?
User avatar (0019289)
StrikerMan780 (reporter)
2018-07-14 03:08

Not sure. Where at? Got a line number?
User avatar (0019291)
Torr Samaho (administrator)
2018-07-22 19:05

It's line 1029 in gl_scene.cpp.
User avatar (0019311)
StrikerMan780 (reporter)
2018-08-05 20:40
edited on: 2018-10-02 22:15

The only thing I can find is this commit:https://github.com/coelckers/gzdoom/commit/cf44d2e37a85fa1f4687be135256680e6e055e5e [^]

I haven't seen any ill behavior from not having this (I wasn't aware of it, thus why it was missing in the patch), but it might be a good idea to have it as well, just in case.

If you'd like, I can try to bring in this change, and test it, and if it's good, add it to my patch. Shall I do this?

User avatar (0020138)
StrikerMan780 (reporter)
2018-10-19 21:52

Awaiting a response. (Not to be impatient, just want to know what I should be doing.)
User avatar (0021074)
StrikerMan780 (reporter)
2019-10-15 05:11

Uploaded a V2 of the patch. Hope it does what is needed.
User avatar (0021075)
StrikerMan780 (reporter)
2019-11-05 21:14
edited on: 2019-12-14 19:34

Attached a V3 of the patch. Should be a lot less invasive, as it only modifies gl_models.cpp, but is lacking some of the extra precision brought about from the timer changes. (Which is basically a non-issue)

User avatar (0021268)
StrikerMan780 (reporter)
2020-04-19 19:33

Since you guys are ramping to a 3.1 release, could you look into the latest patch I submitted?
User avatar (0021270)
Torr Samaho (administrator)
2020-04-19 20:38

Sorry for the insane delay. V3 looks non-invasive and easy to include, good job! Would you mind adding your initials with a short comment to the changed lines? Then, I'll add it for the upcoming 3.1 beta.
User avatar (0021272)
StrikerMan780 (reporter)
2020-04-19 22:39

Attached a version with comments. Hopefully it's what you're meaning.
User avatar (0021281)
Torr Samaho (administrator)
2020-04-25 16:18

Yes, that's exactly what I meant. Thanks! Can you also give me a line for "zandronum-history.txt"? Then, I'll add your patch. You don't need to make a new patch file, putting the history line here as note is sufficient.
User avatar (0021283)
StrikerMan780 (reporter)
2020-04-27 04:51
edited on: 2020-04-27 04:55

+ Fixed jittery model interpolation, partly based on dpJudas's fix for GZDoom. [StrikerMan780]

User avatar (0021286)
Torr Samaho (administrator)
2020-04-27 17:42

Thanks! I pushed this tohttps://bitbucket.org/zandronum/zandronum-sandbox-stable [^] so you can have a quick test. I plan to push it to the stable repo in the next days, before we release the new 3.1 beta.
User avatar (0021291)
StrikerMan780 (reporter)
2020-04-29 01:20

Looks good.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: StrikerMan780
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-06-02 22:52 StrikerMan780 New Issue
2018-06-02 22:52 StrikerMan780 File Added: InterpolationFix.patch
2018-06-02 23:40 StrikerMan780 Note Added: 0019263
2018-06-03 10:11 StrikerMan780 Note Edited: 0019263 View Revisions
2018-06-03 23:03 StrikerMan780 Note Edited: 0019263 View Revisions
2018-06-24 13:39 Torr Samaho Note Added: 0019281
2018-06-24 13:39 Torr Samaho Assigned To => Torr Samaho
2018-06-24 13:39 Torr Samaho Status new => feedback
2018-07-14 03:08 StrikerMan780 Note Added: 0019289
2018-07-14 03:08 StrikerMan780 Status feedback => assigned
2018-07-22 19:05 Torr Samaho Note Added: 0019291
2018-08-05 20:40 StrikerMan780 Note Added: 0019311
2018-08-05 20:42 StrikerMan780 Note Edited: 0019311 View Revisions
2018-10-02 22:15 StrikerMan780 Note Edited: 0019311 View Revisions
2018-10-19 21:52 StrikerMan780 Note Added: 0020138
2019-10-15 05:11 StrikerMan780 File Added: InterpolationFix_v2.patch
2019-10-15 05:11 StrikerMan780 Note Added: 0021074
2019-11-05 21:14 StrikerMan780 Note Added: 0021075
2019-11-05 21:14 StrikerMan780 File Added: InterpolationFix_v3.patch
2019-12-14 19:32 StrikerMan780 Note Edited: 0021075 View Revisions
2019-12-14 19:34 StrikerMan780 Note Edited: 0021075 View Revisions
2020-04-19 19:33 StrikerMan780 Note Added: 0021268
2020-04-19 20:38 Torr Samaho Note Added: 0021270
2020-04-19 22:39 StrikerMan780 File Added: InterpolationFix_v3_commented.patch
2020-04-19 22:39 StrikerMan780 Note Added: 0021272
2020-04-25 16:18 Torr Samaho Note Added: 0021281
2020-04-27 04:51 StrikerMan780 Note Added: 0021283
2020-04-27 04:55 StrikerMan780 Note Edited: 0021283 View Revisions
2020-04-27 17:42 Torr Samaho Note Added: 0021286
2020-04-29 01:20 StrikerMan780 Note Added: 0021291






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker