Anonymous | Login | Signup for a new account | 2024-04-20 03:09 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003411 | Doomseeker | UI | public | 2018-04-11 14:53 | 2019-08-23 18:51 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Zalewa | ||||||||
Priority | normal | Severity | minor | Reproducibility | random | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | Debian GNU/Linux | OS Version | buster/sid | ||||
Product Version | 1.1 | ||||||||
Target Version | 1.2 | Fixed in Version | 1.2 | ||||||
Summary | 0003411: IDHiddenGroup and IDHiddenServerPointer are seen as visible columns | ||||||||
Description | Doomseeker's server list has sortable columns, to allow sorting by player count, ping, etc. The last two columns in the interface:
were not intended to appear, but for some reason now do. See attachment. | ||||||||
Steps To Reproduce |
| ||||||||
Additional Information | This issue is recent. Caused by Qt5 update?
Affects both Doomseeker 1.1 and 1.2~beta-180305-2314M. src/core/gui/models/serverlistcolumn.cpphas relevant HIDDEN declarations for IDHiddenGroup and IDHiddenServerPointer. Additionally, the table column widths may reset on every start of Doomseeker. | ||||||||
Attached Files | 2018-04-11-143553_1032x247_scrot.png [^] (63,621 bytes) 2018-04-11 14:53
dpkg-qt5-qt-libc.log [^] (24,213 bytes) 2018-08-20 18:20 doomseeker.ini [^] (6,268 bytes) 2018-08-20 21:11 SORT_GROUP.png [^] (202,334 bytes) 2019-08-21 08:03 moresortgroup.PNG [^] (338,662 bytes) 2019-08-22 19:19 | ||||||||
Relationships | ||||||
|
Notes | |
(0019164) WubTheCaptain (reporter) 2018-04-11 15:03 |
As far as I remember, Qt 5.9 is fine. |
(0019332) Pol M (developer) 2018-08-14 13:15 |
I can't reproduce this :( Maybe a Qt update fixed it? the current version I'm running is: 5.11.1 |
(0019333) Zalewa (developer) 2018-08-14 19:33 |
Quote I hope so. These columns were explicitly marked as hidden by us, so if Qt suddenly decided to show them then I'm sure it wasn't an intended behavior. |
(0019335) Zalewa (developer) 2018-08-15 08:38 |
I'll mark this as "needs further testing" with Qt 5.11.1 for the time being. |
(0019341) WubTheCaptain (reporter) 2018-08-20 18:17 |
I'm still experiencing this issue as of commit aafacb71daee (1.2~beta-180816-2126M) in both Doomseeker 1.1 and 1.2~beta. My Qt5 package version on Debian is now 5.11.1-5, so I don't know. |
(0019342) WubTheCaptain (reporter) 2018-08-20 18:26 |
Attached dpkg-qt5-qt-libc.log has some relevant output from dpkg -l from the host system experiencing the issue. |
(0019343) WubTheCaptain (reporter) 2018-08-20 18:36 edited on: 2018-08-20 18:36 |
After the following commands, I'm no longer able to reproduce:mv $HOME/.doomseeker/ $HOME/.doomseeker.bak/ # Doomseeker 1.1 directory mv $HOME/.config/doomseeker/ $HOME/.config/doomseeker.bak/ mv $HOME/.local/share/doomseeker/ $HOME/.local/share/doomseeker.bak/ mv $HOME/.cache/doomseeker/ $HOME/.cache/doomseeker.bak/ Some kind of a data corruption bug in Doomseeker? |
(0019344) Zalewa (developer) 2018-08-20 18:55 |
This is an useful hint. The state of the table's header is saved in config and then restored, which most likely pinpoints the error to the 'else' block in
The hidden state for those columns needs to be enforced there too. |
(0019354) WubTheCaptain (reporter) 2018-08-20 20:55 |
@Zalewa: Yes, another issue (surprisingly not mentioned yet) related to this bug is that the table column widths reset on every start of Doomseeker when the bug is present. |
(0019355) WubTheCaptain (reporter) 2018-08-20 21:14 edited on: 2018-08-20 21:19 |
Attached doomseeker.ini reproduces the issue. Place it in Doomseeker configuration directory, which on GNU/Linux should be:
The cause of this is still unknown or random. |
(0019368) WubTheCaptain (reporter) 2018-08-20 22:58 |
Unrelated note: Doomseeker 1.2~beta (aafacb71daee) just segfaulted on me on quit while testing this with broken state. I couldn't get a dump. |
(0019378) Zalewa (developer) 2018-08-21 16:21 edited on: 2018-08-21 16:22 |
I was able to reproduce this with Wub's config also in Qt 5.7. Should be fixed with these 2 commits: 1.'https://bitbucket.org/Doomseeker/doomseeker/commits/a2ed1f062be45feec33c7a52c5ba4e8863ae4eb2 [^]' 2.'https://bitbucket.org/Doomseeker/doomseeker/commits/3e1cbeb2dba8c72c3646923bab1c263b0bc4935d [^]' Please test. |
(0019390) WubTheCaptain (reporter) 2018-08-24 00:29 edited on: 2018-08-24 00:36 |
If we have a corrupted state .ini, going from patched Doomseeker 1.2 to unpatched 1.1 the bug may still be reproduced. It's only seen as a non-issue in Doomseeker 1.2 visually, but we don't actually fix/reset the broken state (in the .ini), as Doomseeker:
What could cause the corrupted state where a column suddenly becomes unhidden, I've not found yet. Switching between clean 1.2 and 1.1 configs and migrating them between the two (multiple times) shouldn't cause this issue – and doesn't in my experience with some testing. Is there something more we could still do on the issue to prevent this? Practically this issue is kind of resolved now, although it may be seen as some sort of a small hack. All the better if the hidden status was not part of the saved state (because we don't allow hiding any other columns, anyway), but I almost doubt Qt does not allow. |
(0019391) WubTheCaptain (reporter) 2018-08-24 00:46 |
Quote from WubTheCaptain And I'm kind of okay with this. |
(0019405) Zalewa (developer) 2018-08-26 10:10 |
Quote from "WubTheCaptain" No. The config should be saved with proper values when there's a reason to save the config. Try opening the config dialog and pressing the "Apply" button. The user must expect that config saved by a new version of the program may not be fully backwards compatible with the old version of the program. The user may open the config in a text editor and remove the broken setting manually, letting Doomseeker to recreate it. That's the reason why config is a text file - so that people can modify it with a text editor when they feel it's necessary. Unless there's still some problem with this issue in the current HEAD, I don't plan to spend any more time on it. |
(0020970) Zalewa (developer) 2019-08-21 08:06 |
The SORT_GROUP.png is a screenshot from someone who is reportedly using Doomseeker 1.3. The "hidden" columns are visible. There's no clear indiciation whether that's actually 1.3 or not, but if you look at the log everything indicates that it is: a) Auto-updater states that there's nothing to update. b) IP2C checksum is current. |
(0020971) DrinkyBird (reporter) 2019-08-22 19:20 edited on: 2019-08-22 19:22 |
I'm also experiencing this issue, screenshot (with version) attached. Interestingly, it disappears if I restart Doomseeker - and I have no idea how to make it appear again, it just sometimes appears. edit: Turns out that changing the filter will make these two columns appear. |
(0020972) Zalewa (developer) 2019-08-22 21:42 |
Yeah, refreshing a server list and then filtering by server name causes the columns to appear. |
(0020973) Zalewa (developer) 2019-08-23 09:49 |
I cured the problem by cutting it out. The columns will never appear again because they're gone:'https://bitbucket.org/Doomseeker/doomseeker/commits/d97bb2af82d5820a1e6c962821e5b6c3182b9186 [^]' |
(0020978) WubTheCaptain (reporter) 2019-08-23 17:53 |
Lovely, "red" commits. (Fyi: I'd have preferred if the closed tickets stay closed, with a new ticket for reintroduced issues. The original issue no longer shows up on the tracker as fixed in 1.2, despite the fix being incomplete.) |
(0020979) WubTheCaptain (reporter) 2019-08-23 18:04 |
See 0003703. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2018-04-11 14:53 | WubTheCaptain | New Issue | |
2018-04-11 14:53 | WubTheCaptain | File Added: 2018-04-11-143553_1032x247_scrot.png | |
2018-04-11 15:03 | WubTheCaptain | Note Added: 0019164 | |
2018-08-14 13:15 | Pol M | Note Added: 0019332 | |
2018-08-14 19:33 | Zalewa | Note Added: 0019333 | |
2018-08-15 08:38 | Zalewa | Note Added: 0019335 | |
2018-08-15 08:38 | Zalewa | Assigned To | => Zalewa |
2018-08-15 08:38 | Zalewa | Status | new => needs testing |
2018-08-20 18:17 | WubTheCaptain | Note Added: 0019341 | |
2018-08-20 18:17 | WubTheCaptain | Status | needs testing => acknowledged |
2018-08-20 18:20 | WubTheCaptain | File Added: dpkg-qt5-qt-libc.log | |
2018-08-20 18:22 | WubTheCaptain | Status | acknowledged => new |
2018-08-20 18:26 | WubTheCaptain | Note Added: 0019342 | |
2018-08-20 18:36 | WubTheCaptain | Note Added: 0019343 | |
2018-08-20 18:36 | WubTheCaptain | Status | new => feedback |
2018-08-20 18:36 | WubTheCaptain | Note Edited: 0019343 | View Revisions |
2018-08-20 18:39 | WubTheCaptain | Assigned To | Zalewa => WubTheCaptain |
2018-08-20 18:39 | WubTheCaptain | Status | feedback => assigned |
2018-08-20 18:55 | Zalewa | Note Added: 0019344 | |
2018-08-20 18:55 | Zalewa | Assigned To | WubTheCaptain => Zalewa |
2018-08-20 20:55 | WubTheCaptain | Note Added: 0019354 | |
2018-08-20 21:01 | WubTheCaptain | Reproducibility | have not tried => random |
2018-08-20 21:11 | WubTheCaptain | File Added: doomseeker.ini | |
2018-08-20 21:14 | WubTheCaptain | Note Added: 0019355 | |
2018-08-20 21:19 | WubTheCaptain | Note Edited: 0019355 | View Revisions |
2018-08-20 21:32 | WubTheCaptain | Additional Information Updated | View Revisions |
2018-08-20 22:58 | WubTheCaptain | Note Added: 0019368 | |
2018-08-21 16:21 | Zalewa | Note Added: 0019378 | |
2018-08-21 16:21 | Zalewa | Status | assigned => needs testing |
2018-08-21 16:22 | Zalewa | Note Edited: 0019378 | View Revisions |
2018-08-24 00:29 | WubTheCaptain | Note Added: 0019390 | |
2018-08-24 00:29 | WubTheCaptain | Status | needs testing => needs review |
2018-08-24 00:36 | WubTheCaptain | Note Edited: 0019390 | View Revisions |
2018-08-24 00:46 | WubTheCaptain | Note Added: 0019391 | |
2018-08-24 03:30 | WubTheCaptain | Relationship added | related to 0003463 |
2018-08-26 10:10 | Zalewa | Note Added: 0019405 | |
2018-08-26 10:10 | Zalewa | Status | needs review => resolved |
2018-08-26 10:10 | Zalewa | Fixed in Version | => 1.2 |
2018-08-26 10:10 | Zalewa | Resolution | open => fixed |
2018-09-27 03:23 | WubTheCaptain | Relationship deleted | related to 0003463 |
2018-09-27 03:23 | WubTheCaptain | Target Version | => 1.2 |
2018-10-27 22:55 | WubTheCaptain | Status | resolved => closed |
2019-08-21 08:03 | Zalewa | File Added: SORT_GROUP.png | |
2019-08-21 08:06 | Zalewa | Note Added: 0020970 | |
2019-08-21 08:06 | Zalewa | Status | closed => new |
2019-08-22 19:19 | DrinkyBird | File Added: moresortgroup.PNG | |
2019-08-22 19:20 | DrinkyBird | Note Added: 0020971 | |
2019-08-22 19:22 | DrinkyBird | Note Edited: 0020971 | View Revisions |
2019-08-22 21:42 | Zalewa | Note Added: 0020972 | |
2019-08-22 21:42 | Zalewa | Assigned To | Zalewa => |
2019-08-22 21:42 | Zalewa | Status | new => confirmed |
2019-08-23 08:57 | Zalewa | Assigned To | => Zalewa |
2019-08-23 08:57 | Zalewa | Status | confirmed => assigned |
2019-08-23 09:49 | Zalewa | Note Added: 0020973 | |
2019-08-23 09:49 | Zalewa | Status | assigned => needs testing |
2019-08-23 09:50 | Zalewa | Reproducibility | random => sometimes |
2019-08-23 09:50 | Zalewa | Resolution | fixed => reopened |
2019-08-23 09:50 | Zalewa | Fixed in Version | 1.2 => |
2019-08-23 09:50 | Zalewa | Target Version | 1.2 => 1.3.3 |
2019-08-23 17:53 | WubTheCaptain | Note Added: 0020978 | |
2019-08-23 18:00 | WubTheCaptain | Category | Bug => UI |
2019-08-23 18:00 | WubTheCaptain | Relationship added | related to 0003703 |
2019-08-23 18:04 | WubTheCaptain | Note Added: 0020979 | |
2019-08-23 18:04 | WubTheCaptain | Status | needs testing => closed |
2019-08-23 18:04 | WubTheCaptain | Resolution | reopened => fixed |
2019-08-23 18:04 | WubTheCaptain | Fixed in Version | => 1.2 |
2019-08-23 18:04 | WubTheCaptain | Target Version | 1.3.3 => 1.2 |
2019-08-23 18:51 | WubTheCaptain | Reproducibility | sometimes => random |
Copyright © 2000 - 2024 MantisBT Team |