Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003394Doomseeker[All Projects] Suggestionpublic2018-03-03 18:512018-08-20 18:59
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
Platformx86_64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003394: Create Game: Allow hiding passwords in the "Misc." tab
DescriptionThere's some visible parts in the Create Game dialog with secrets (passwords) displayed in plaintext with no option to hide them.

Of course, they will be stored in plaintext in config files but allowing to hide the passwords may at least provide some security from an adversary learning secrets by watching over the shoulder if hidden.
Steps To Reproduce
  1. Start Doomseeker.
  2. Press the Create Game icon, or navigate to File → Create Game (Ctrl+S).
  3. Navigate to the "Misc." tab.
  4. Input any characters to three of the password dialogs ("Connect password:", "Join password:", "RCon password:").
  5. Notice how the characters are displayed as plaintext and not bullets.
  6. Notice how there is no checkbox option next to these forms to toggle hiding the passwords between plaintext and bullets.
Additional InformationI acknowledge some of these will still be visible in the "Show join command line" dialog, as intended.

Doomseeker 1.2 has an option to toggle hiding the password in the RCon client, so far.

I'm using Qt 5.9.2.
Attached Files

- Relationships

-  Notes
User avatar (0019112)
WubTheCaptain (developer)
2018-03-03 19:20

As Zalewa pointed out in ticket 0003393, there is a way to hide them from Appearance settings. (Although, this is a bit buggy and non-working in Doomseeker 1.1, possibly due to config backwards incompatibility issues with 1.1 and 1.2.)

For extra convenience, should a new checkbox "Hide" be added next to the password fields in the "Misc." tab to toggle hiding the password of each form input? Reminding this already exists for Doomseeker 1.2's RCon client.
User avatar (0019113)
WubTheCaptain (developer)
2018-03-03 19:23
edited on: 2018-03-03 19:23

Quote from WubTheCaptain
As Zalewa pointed out in ticket 0003393, there is a way to hide them from Appearance settings. (Although, this is a bit buggy and non-working in Doomseeker 1.1, possibly due to config backwards incompatibility issues with 1.1 and 1.2.)


Nevermind me on that, it has no effect on the "Misc." tab in 1.2 either with a new config and "Hide passwords" checked. A bug?

User avatar (0019322)
Zalewa (developer)
2018-08-10 19:59

Done by Pol M:https://bitbucket.org/Doomseeker/doomseeker/commits/4c84247d451349ad8b09a83b0bc6640bc7dac2f5 [^]
User avatar (0019336)
Zalewa (developer)
2018-08-15 09:00

A follow-up commit to connect the checkbox with the Appearance "Hide Passwords" configuration setting:https://bitbucket.org/Doomseeker/doomseeker/commits/dfd10629cc56e294275c5621991720ee650f558d [^]
User avatar (0019345)
WubTheCaptain (developer)
2018-08-20 18:56
edited on: 2018-08-20 18:59

This works, as long as one remembers the intended functionality:
  • The "Hide passwords" option in Appearance settings is permanent and influences the default option in Create Game.
  • The "Hide passwords" option in Create Game is temporary (toggling it here does not change the "Hide passwords" option in Appearance settings), and not saved to the Create Game configuration (as far as I understand it).

Tested with 1.2~beta-180816-2126M (aafacb71daee), which includes both patches.


Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-03-03 18:51 WubTheCaptain New Issue
2018-03-03 18:51 WubTheCaptain Additional Information Updated View Revisions
2018-03-03 18:52 WubTheCaptain Summary Create Game: Allow hiding passwords in the "Misc." tab from being displayed => Create Game: Allow hiding passwords in the "Misc." tab
2018-03-03 19:20 WubTheCaptain Note Added: 0019112
2018-03-03 19:20 WubTheCaptain Status new => feedback
2018-03-03 19:23 WubTheCaptain Note Added: 0019113
2018-03-03 19:23 WubTheCaptain Status feedback => new
2018-03-03 19:23 WubTheCaptain Note Edited: 0019113 View Revisions
2018-08-10 19:59 Zalewa Note Added: 0019322
2018-08-10 19:59 Zalewa Assigned To => Zalewa
2018-08-10 19:59 Zalewa Status new => needs review
2018-08-15 09:00 Zalewa Note Added: 0019336
2018-08-15 09:00 Zalewa Status needs review => needs testing
2018-08-20 18:56 WubTheCaptain Note Added: 0019345
2018-08-20 18:56 WubTheCaptain Note Edited: 0019345 View Revisions
2018-08-20 18:57 WubTheCaptain Status needs testing => resolved
2018-08-20 18:57 WubTheCaptain Resolution open => fixed
2018-08-20 18:57 WubTheCaptain Fixed in Version => 1.2
2018-08-20 18:57 WubTheCaptain Target Version => 1.2
2018-08-20 18:58 WubTheCaptain Note Edited: 0019345 View Revisions
2018-08-20 18:59 WubTheCaptain Note Edited: 0019345 View Revisions






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker