Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003285Doomseeker[All Projects] Suggestionpublic2017-10-03 18:292017-11-05 13:44
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeveritytweakReproducibilityN/A
StatusresolvedResolutionfixed 
Platformx86_64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003285: IRC: Add a button to remove defined IRC networks from connect dialog
DescriptionDoomseeker includes a small IRC client. Currently, it only allows to add new IRC network definitions and edit them.

Please add a way to delete defined IRC networks without editing doomseeker-irc.ini configuration manually in a text editor.
Steps To Reproduce

  1. If IRC is not already visible, to view it press Ctrl + I or access it via top crates (View → IRC) or the button (IRC).

  2. On the left side of IRC panel, click the "Connect button".

  3. Notice how there's buttons for adding and editing defined networks, but not for deleting them.

Attached Files

- Relationships
related to 0003284resolvedZalewa IRC: Defining an empty IRC network address results in that defined IRC network becoming uneditable from connect dialog 

-  Notes
User avatar (0018421)
WubTheCaptain (developer)
2017-10-03 19:56

I found out there's an option to remove them from "IRC Options → Networks", but no such option in the connect dialog.
User avatar (0018743)
Zalewa (developer)
2017-11-03 18:08

https://bitbucket.org/Doomseeker/doomseeker/commits/19a22b7503158b4cafaef6d708a628a2189c534a [^]
User avatar (0018752)
WubTheCaptain (developer)
2017-11-04 00:03
edited on: 2017-11-04 00:03

I can confirm the pencil.png icon was available under a Creative Commons Attribution 3.0 Unported license on said date at external URL, as an alternative to CC BY-2.5 licensing. Seems fine.

There's a bit of inconsistency now, because one of the dialog titles was changed from "remove network" to "remove IRC network". Polish translations are missing for this new dialog (but hey, they are also missing in a lot more places, i.e. tooltips all around Doomseeker).

Quote
Are you use you wish to remove network X?


"Are you use you...?" → "Are you sure you...?"

This also changed src/core/irc/entities/ircnetworkentity.cpp without mentioning it, which in turn resolved 0003284 (unknowingly).

User avatar (0018758)
Zalewa (developer)
2017-11-04 09:03

The translation gets the same treatment as changelog.md. I prefer to update it in bulk. Rest assured that I will update the translation eventually.

As for the wording:https://bitbucket.org/Doomseeker/doomseeker/commits/4e8594225adcd7e4b1db19f1c88a5e13d8afe6ab [^]
User avatar (0018764)
WubTheCaptain (developer)
2017-11-04 14:46
edited on: 2017-11-04 14:49

$ grep -ir "remove network" src/ | wc -l
3
$ grep -ir "remove IRC network" src/ | wc -l
2
$ grep -ir "connect to network" src/ | wc -l
1
$ grep -ir "define IRC network" src/ | wc -l
2
$ grep -ir "add network" src/ | wc -l
1


If this new inconsistency is fine, consider it resolved.

User avatar (0018773)
Zalewa (developer)
2017-11-04 16:59

Quote from "WubTheCaptain"
If this new inconsistency is fine, consider it resolved.

I'll normalize this.
User avatar (0018794)
Zalewa (developer)
2017-11-05 13:44

Actually, the cases you pointed out are okay within their contexts. I have normalized something else, though.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-10-03 18:29 WubTheCaptain New Issue
2017-10-03 18:30 WubTheCaptain Steps to Reproduce Updated View Revisions
2017-10-03 19:56 WubTheCaptain Note Added: 0018421
2017-10-03 20:00 WubTheCaptain Summary IRC: Add a button to remove defined IRC networks => IRC: Add a button to remove defined IRC networks from connect dialog
2017-11-03 12:54 WubTheCaptain Severity feature => tweak
2017-11-03 14:42 Zalewa Assigned To => Zalewa
2017-11-03 14:42 Zalewa Status new => acknowledged
2017-11-03 16:31 Zalewa Status acknowledged => assigned
2017-11-03 18:08 Zalewa Note Added: 0018743
2017-11-03 18:08 Zalewa Status assigned => needs review
2017-11-03 18:08 Zalewa Target Version => 1.2
2017-11-03 23:11 WubTheCaptain Relationship added related to 0003284
2017-11-04 00:03 WubTheCaptain Note Added: 0018752
2017-11-04 00:03 WubTheCaptain Status needs review => assigned
2017-11-04 00:03 WubTheCaptain Note Edited: 0018752 View Revisions
2017-11-04 09:03 Zalewa Note Added: 0018758
2017-11-04 14:46 WubTheCaptain Note Added: 0018764
2017-11-04 14:46 WubTheCaptain Status assigned => needs review
2017-11-04 14:47 WubTheCaptain Note Edited: 0018764 View Revisions
2017-11-04 14:48 WubTheCaptain Note Edited: 0018764 View Revisions
2017-11-04 14:49 WubTheCaptain Note Edited: 0018764 View Revisions
2017-11-04 14:49 WubTheCaptain Note Edited: 0018764 View Revisions
2017-11-04 16:59 Zalewa Note Added: 0018773
2017-11-05 00:58 WubTheCaptain Status needs review => assigned
2017-11-05 13:44 Zalewa Note Added: 0018794
2017-11-05 13:44 Zalewa Status assigned => resolved
2017-11-05 13:44 Zalewa Fixed in Version => 1.2
2017-11-05 13:44 Zalewa Resolution open => fixed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker