Anonymous | Login | Signup for a new account | 2024-04-20 02:38 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003266 | Doomseeker | [All Projects] Bug | public | 2017-09-19 06:47 | 2018-10-27 22:55 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Blzut3 | ||||||||
Priority | low | Severity | minor | Reproducibility | sometimes | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | OS Version | ||||||
Product Version | 1.1 | ||||||||
Target Version | 1.2 | Fixed in Version | 1.2 | ||||||
Summary | 0003266: cmake_policy: OLD behavior for CMP0011 and CMP0020 is deprecated | ||||||||
Description | Previously, Doomseeker set cmake policies to OLD on some files because "they're DLLs and have no main()", according to code comments. Explicitly setting an OLD policy used to previously silence policy warnings. This is no longer the case: This behavior is deprecated and will be removed from a future CMake release. Doomseeker should be fixed to work with the new behavior and the policy set to NEW (implicit) to maintain compatibility with build systems. | ||||||||
Steps To Reproduce | Use a reasonably recent version of CMake to reproduce. The oldest plausible version of CMake should be 3.3.*. Then in extracted source archive:mkdir build cmake .. stderr should be filled with CMake Deprecation Warnings with pointers to source files and lines. | ||||||||
Additional Information | I'm using cmake 3.9.1. cmake_policy documentation:'https://cmake.org/cmake/help/v3.0/command/cmake_policy.html [^]' Example of a deprecation warning code line: cmake_policy(SET CMP0020 OLD) # We have our own WinMain. | ||||||||
Attached Files | cmake-stderr.log [^] (6,168 bytes) 2017-09-19 06:47 | ||||||||
Notes | |
(0018335) WubTheCaptain (reporter) 2017-09-19 06:49 edited on: 2017-09-19 07:06 |
I forgot to fill in the operating system to the original ticket. I've used Debian GNU/Linux buster/sid. The title is slightly misleading too: OLD behaviors of all policies are deprecated, not just CMP0011 and CMP0020 which appear in Doomseeker. |
(0018336) WubTheCaptain (reporter) 2017-09-19 06:53 |
Latest cmake_policy documentation is there:'https://cmake.org/cmake/help/latest/command/cmake_policy.html [^]' |
(0018341) WubTheCaptain (reporter) 2017-09-19 09:13 edited on: 2017-09-19 09:22 |
I surveyed some CMake versions found in GNU/Linux and *BSD distributions. Debian GNU/Linux:
Arch GNU/Linux:
Ubuntu GNU/Linux:
Gentoo GNU/Linux:
OpenBSD:
FreeBSD:
NetBSD:
|
(0018344) Blzut3 (administrator) 2017-09-20 00:19 |
Actually already have this addressed on my laptop among some other CMake modernization work I was doing. (Just haven't committed it since for some reason the system clock on there is all over the place and I got into a state were CMake was fighting with itself since files were modified in the future. Don't know if my homebrew laptop is to blame or Windows, but I'm just rambling at this point.) Interestingly I can't figure out why we set CMP0020 to OLD since removing it seems to have no side effect. |
(0018358) Blzut3 (administrator) 2017-09-23 02:46 |
Should be fixed now. 'https://bitbucket.org/Doomseeker/doomseeker/commits/97b4132754469a42dd14fbe856b82dc6885fa204 [^]' |
(0019788) WubTheCaptain (reporter) 2018-09-27 03:53 |
Postscript note: The issue was introduced in commit 224428663c7a shortly after 1.0 release. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2017-09-19 06:47 | WubTheCaptain | New Issue | |
2017-09-19 06:47 | WubTheCaptain | File Added: cmake-stderr.log | |
2017-09-19 06:49 | WubTheCaptain | Note Added: 0018335 | |
2017-09-19 06:53 | WubTheCaptain | Note Added: 0018336 | |
2017-09-19 07:06 | WubTheCaptain | Note Edited: 0018335 | View Revisions |
2017-09-19 09:13 | WubTheCaptain | Note Added: 0018341 | |
2017-09-19 09:16 | WubTheCaptain | Note Edited: 0018341 | View Revisions |
2017-09-19 09:16 | WubTheCaptain | Note Edited: 0018341 | View Revisions |
2017-09-19 09:22 | WubTheCaptain | Note Edited: 0018341 | View Revisions |
2017-09-20 00:16 | Blzut3 | Assigned To | => Blzut3 |
2017-09-20 00:16 | Blzut3 | Status | new => assigned |
2017-09-20 00:19 | Blzut3 | Note Added: 0018344 | |
2017-09-23 02:46 | Blzut3 | Note Added: 0018358 | |
2017-09-23 02:46 | Blzut3 | Status | assigned => resolved |
2017-09-23 02:46 | Blzut3 | Fixed in Version | => 1.2 |
2017-09-23 02:46 | Blzut3 | Resolution | open => fixed |
2017-09-23 02:46 | Blzut3 | Target Version | => 1.2 |
2018-09-27 03:53 | WubTheCaptain | Note Added: 0019788 | |
2018-09-27 03:53 | WubTheCaptain | Product Version | => 1.1 |
2018-10-27 22:55 | WubTheCaptain | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |