|Anonymous | Login | Signup for a new account||2018-09-22 11:57 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003262||Doomseeker||[All Projects] Bug||public||2017-09-12 03:33||2018-09-04 12:30|
|Platform||x86_64||OS||Debian GNU/Linux||OS Version||buster/sid|
|Target Version||Fixed in Version|
|Summary||0003262: Allow $HOME and/or ~/ in file paths|
|Description||Doomseeker currently requires the file path to be absolute. ~/ and $HOME are not recognized as valid alternatives to /home/<username>, instead /home/<username> (e.g. /home/wub in my case) is written to each configuration. In example for IWAD paths, ~/ and $HOME fail with "Iwad Path error".|
This could possibly be extended to other user-configurable file paths, such as server executable path.
|Steps To Reproduce|
|Additional Information||Changing the path of my home folder (as a consequence of renaming my username on the local system) means all my previous configurations with IWAD paths in the "Create Game" window and various IWAD/PWAD paths subsequently need fixing to the new location.|
If I recall correctly, at worst this means the "Create Game" window fails to list the additional WADs and they will be missing. The paths still exist in the .ini configuration and need to be manually edited to the new paths in a text editor.
In reverse: If I keep my old home location, no change is required if the user wants to hard-type their old path.
|Attached Files||dpkg.log [^] (3,173 bytes) 2017-09-12 03:37|
edited on: 2017-09-12 03:38
Tested with Qt5 5.9.1 for original suggestion.
edited on: 2017-09-21 10:43
In addition to what's described in the steps to reproduce, here's some test case guidance for implementers (consider ~/ is /home/user1/):
QDir::homePath() may be useful.
After some consideration, I think this is an upstream issue with QFileDialog in Qt which requires no change in Doomseeker. The change isn't as trivial as I initially thought it would be. It'd be nice to have in Qt for sure.
Should we close this ticket?
Nevermind. This issue was fixed in Qt 4.8 six years ago:https://bugreports.qt.io/browse/QTBUG-20571 [^]
Seems like something about Doomseeker's use of QFileInfo is wrong, then. QFileInfo in Qt 5 definitely supports tilde.
|I'd still like to have a look around. Maybe I'll find out we're doing something non-standard with paths and it doesn't work everywhere. I'll also think if I want to support env vars resolution in paths.|
I've started working on this and already have a path resolver method that implements some placeholders - it's basic but it should be enough. Documentation excerpt looks like this:
That was the easy part.
The more difficult part stems partially from the fact that a thing like this needs to be done with full intent from the very first moment of development of the program. Right now, finding all places where the resolution needs to happen as we hit the filesystem and all other places where we need to keep the templated path may prove to be a challenge. This problem isn't only limited to defining the configuration defaults, because user will expect that the placeholders can be used anywhere where path can be input. This is something that can be overcomed, however we need to be careful.
Another cause of problems is QStandardPaths. As much as it has proven to be helpful so far, it will now prove to be that much obstructive. Locations returned from it are absolute. Home dir is not represented as "~", but as an explicit path. To be even more general, Qt doesn't seem to have built-in support for "~" resolution, and anyway even if it had, we still desire to also use our own placehodlers for $PROGDIR and env. variables, which means we need custom resolver anyway. When we retrieve a path from QStandardPaths, do we need to check if it begins from home dir and replace this part with '~'? Where in the code should this happen? In DataPaths? Do we need our own wrapper over QStandardPaths?
Quote from "WubTheCaptain"
Do you have any documentation on this? My tests indicate that this is not true.
|I've pushed the work done so far to a separate branch:https://bitbucket.org/Doomseeker/doomseeker/commits/5d30d232dfaba9f8ce5bc07f6f79f65342a37a8e [^]|
|Only registered users can voice their support. Click here to register, or here to log in.|
|Opponents:||No one explicitly opposes this issue yet.|
|2017-09-12 03:33||WubTheCaptain||New Issue|
|2017-09-12 03:37||WubTheCaptain||Note Added: 0018287|
|2017-09-12 03:37||WubTheCaptain||File Added: dpkg.log|
|2017-09-12 03:38||WubTheCaptain||Note Edited: 0018287||View Revisions|
|2017-09-21 10:40||WubTheCaptain||Note Added: 0018355|
|2017-09-21 10:43||WubTheCaptain||Note Edited: 0018355||View Revisions|
|2017-09-27 18:30||Zalewa||Relationship added||child of 0003246|
|2017-09-27 19:18||WubTheCaptain||Note Added: 0018398|
|2017-09-27 19:34||WubTheCaptain||Note Added: 0018399|
|2017-09-27 20:01||Zalewa||Note Added: 0018400|
|2017-09-27 21:53||WubTheCaptain||Relationship added||child of 0003279|
|2017-09-27 21:54||WubTheCaptain||Relationship deleted||child of 0003246|
|2017-10-04 19:27||WubTheCaptain||Category||Suggestion => Bug|
|2017-10-05 02:44||WubTheCaptain||Status||new => acknowledged|
|2017-12-11 16:49||Zalewa||Relationship added||related to 0003354|
|2018-08-27 03:44||WubTheCaptain||Priority||high => normal|
|2018-08-27 07:31||Zalewa||Assigned To||=> Zalewa|
|2018-08-27 07:31||Zalewa||Status||acknowledged => assigned|
|2018-09-04 11:59||Zalewa||Note Added: 0019489|
|2018-09-04 12:30||Zalewa||Note Added: 0019490|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2018 MantisBT Team|