Zandronum Chat on our Discord Server Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003189Zandronum[All Projects] Bugpublic2017-07-16 20:002017-08-11 21:44
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
PlatformOSOS Version
Product Version3.0-beta 
Target VersionFixed in Version 
Summary0003189: Skin sounds not working anymore
DescriptionFrom this post:

"I noticed in 3.0 that you can't use skin (sounds) anymore in complex doom, while you could in 2.0? Skins work perfectly in unmodded doom though. Did something change to alter this behavior or is this a bug?"

"They won't work in gzdoom either but I suspect that's because all zandroskins use skininfo and not S_SKIN lumps. I'm not sure about this though but I can't get my skins to work in 1.8.6 and the latest GZD build anyway."
Steps To ReproduceStart Zandronum with mincomplextest.pk3
Type skin "Quake 2 guy" and taunt
Attached Files? file icon GZDTestGuy.wad [^] (124,370 bytes) 2017-07-17 14:34
? file icon ZANTestGuy.wad [^] (124,374 bytes) 2017-07-17 14:34
? file icon mincomplextest.pk3 [^] (4,009,980 bytes) 2017-07-25 16:38

- Relationships

-  Notes
User avatar (0018051)
Edward-san (developer)
2017-07-16 20:03

It would be nice to have both an example wad containing SKININFO and an example wad containing S_SKIN for GZdoom.
User avatar (0018055)
Frits (reporter)
2017-07-17 14:36
edited on: 2017-07-17 14:38

Test skins(StrafeGuy) uploaded. ZANGUY with SKININFO and GZDGUY with S_SKIN.

I noticed with trial and error that you can't make a sound only skin for GZDOOM, it just won't recognize the skin unless you add new sprites.

User avatar (0018088)
Torr Samaho (administrator)
2017-07-23 16:17

Thanks for the example wads! Can you elaborate what is wrong? I just briefly tested ZANTestGuy.wad and the new jump sound seemed fine both in 2.1.2 and 3.0.
User avatar (0018097)
Frits (reporter)
2017-07-25 16:38
edited on: 2017-07-25 16:40

I stripped complex doom down to its bare minimum needed for the example wad.

In 2.1.2 choosing a custom skin works and plays the sounds in 3.0 it doesn't.

Start Zandronum with mincomplextest.pk3
Type skin "Quake 2 guy" and taunt

User avatar (0018127)
Edward-san (developer)
2017-07-30 21:59
edited on: 2017-07-30 22:01

That mincomplextest.pk3 file contains a replacement class for the player which has also the +NOSKIN flag enabled.

After a bit of debugging I think the problem happens since this commit, which added a MF4_NOSKIN check in APlayerPawn::GetSoundClass. That prevents the skinned sound from playing.

Frits, why is the +NOSKIN flag present, by the way? Can you still reproduce the problem if you remove it?

User avatar (0018147)
eagle (reporter)
2017-08-06 20:35

-NOSKIN - skins have earned.
User avatar (0018154)
Dusk (developer)
2017-08-10 08:14

This looks like a mod error to me. If you set +NOSKIN then why do you expect anything skin related to be enabled for that player class?
User avatar (0018160)
eagle (reporter)
2017-08-11 17:18

In complex doom and all his mods NOSKIN is established +. For what daedalus put this flag only he knows. But he began to work with the new zandronum version as well as is conceived, probably. When it is noticed by other modders...
User avatar (0018161)
Leonard (developer)
2017-08-11 21:44

It might have to do with the fact that complex uses the Weapon.PreferredSkin feature

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-07-16 20:00 Edward-san New Issue
2017-07-16 20:01 Edward-san Reporter Edward-san => Frits
2017-07-16 20:03 Edward-san Note Added: 0018051
2017-07-16 20:03 Edward-san Status new => feedback
2017-07-17 14:34 Frits File Added: GZDTestGuy.wad
2017-07-17 14:34 Frits File Added: ZANTestGuy.wad
2017-07-17 14:36 Frits Note Added: 0018055
2017-07-17 14:36 Frits Status feedback => new
2017-07-17 14:38 Frits Note Edited: 0018055 View Revisions
2017-07-23 16:17 Torr Samaho Note Added: 0018088
2017-07-25 16:38 Frits Note Added: 0018097
2017-07-25 16:38 Frits File Added: mincomplextest.pk3
2017-07-25 16:40 Frits Note Edited: 0018097 View Revisions
2017-07-30 19:52 Dusk Steps to Reproduce Updated View Revisions
2017-07-30 20:33 Edward-san Note Added: 0018125
2017-07-30 20:33 Edward-san Status new => feedback
2017-07-30 20:51 Edward-san Note Deleted: 0018125
2017-07-30 20:52 Edward-san Status feedback => new
2017-07-30 21:59 Edward-san Note Added: 0018127
2017-07-30 21:59 Edward-san Status new => feedback
2017-07-30 22:01 Edward-san Note Edited: 0018127 View Revisions
2017-08-06 20:35 eagle Note Added: 0018147
2017-08-10 08:14 Dusk Note Added: 0018154
2017-08-11 17:18 eagle Note Added: 0018160
2017-08-11 21:44 Leonard Note Added: 0018161

Questions or other issues? Contact Us.


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker