|Anonymous | Login | Signup for a new account||2017-12-17 15:54 UTC|
|My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002748||Zandronum||[All Projects] Bug||public||2016-06-05 05:47||2017-11-19 10:59|
|Target Version||3.1||Fixed in Version|
|Summary||0002748: Changset 9556:54c5571372c0 Isn't supposed to affect A_GunFlash, but it does.|
|Description||ZDoom introduced a change that makes the Muzzle Flashes for the stock weapons use 2 tics, to mimic vanilla Doom behavior, however, it wasn't supposed to affect A_GunFlash, which allows one to make 1-tic flashes.|
When Zandronum introduced these changes, it got fucked up and affects A_GunFlash too, breaking some weapons in mods considerably. (No muzzle flash showing, or screwing up when codepointers fire.)
See this post and the reply:http://forum.zdoom.org/viewtopic.php?p=898285#p898285 [^]
|Attached Files||TestWad_BrokenFlash.wad [^] (191,789 bytes) 2017-11-13 17:06|
edited on: 2016-06-05 06:09
the 'repeated flash state' fix was disabled here:https://bitbucket.org/Torr_Samaho/zandronum/commits/2ad9d0af90838a40076af4e7367f9954ab303d9c [^]
due to causing a weapon sync regression, as seen here:http://zandronum.com/tracker/view.php?id=2607 [^]
*sigh* Fuck me, always something.
Hopefully it can be fixed without disabling it soon. Quite a few recently created mods break because of this.
edited on: 2017-11-13 16:43
Striker, could you upload an example with the A_GunFlash problem? I need to test the fix for ticket 0002607.
|Yeah, give me a little bit, and I'll put one together.|
|Ok, the patch provided in 0002607:0018845 seems to work fine with the provided wad, both offline and online, but we need more tests to find out if anything else is broken.|
I got to test this and even with the conditions mentioned in 0002607:0018833 the example wad clearly works with the fix (and doesn't without).
On that note, I don't think we should wait further before pulling these changes, the kind of testing Torr asks for here (i.e. real world/general testing) should ideally be provided by more frequent beta releases and not delay merges IMO.
Torr Samaho (administrator)
I added the patch.
Quote from Leonard
Just to clarify: I was not asking for real world testing to be done before the patch can be pulled. I was merely asking whether such testing already has been done to get an impression on which kind of testing baseline I can rely on to decide whether to pull.
|Only registered users can voice their support. Click here to register, or here to log in.|
|Opponents:||No one explicitly opposes this issue yet.|
|2016-06-05 05:47||StrikerMan780||New Issue|
|2016-06-05 06:08||WaTaKiD||Note Added: 0015018|
|2016-06-05 06:09||WaTaKiD||Note Edited: 0015018||View Revisions|
|2016-06-05 06:58||StrikerMan780||Note Added: 0015020|
|2016-06-05 10:31||Dusk||Relationship added||child of 0002607|
|2016-12-24 22:43||Dusk||Target Version||=> 3.0|
|2017-11-09 00:02||Leonard||Status||new => assigned|
|2017-11-09 00:02||Leonard||Assigned To||=> Edward-san|
|2017-11-09 00:03||Leonard||Target Version||3.0 => 3.1|
|2017-11-13 16:43||Edward-san||Note Added: 0018873|
|2017-11-13 16:43||Edward-san||Status||assigned => feedback|
|2017-11-13 16:43||Edward-san||Note Edited: 0018873||View Revisions|
|2017-11-13 16:50||StrikerMan780||Note Added: 0018874|
|2017-11-13 16:50||StrikerMan780||Status||feedback => assigned|
|2017-11-13 17:06||StrikerMan780||File Added: TestWad_BrokenFlash.wad|
|2017-11-13 17:07||StrikerMan780||Note Added: 0018875|
|2017-11-13 17:55||Edward-san||Note Added: 0018876|
|2017-11-13 17:55||Edward-san||Status||assigned => needs testing|
|2017-11-16 16:46||Leonard||Note Added: 0018886|
|2017-11-19 10:59||Torr Samaho||Note Added: 0018892|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2017 MantisBT Team|