0002667: Server informs the client about map changes, before the client fully loaded the map.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-03-06 21:54	WaTaKiD	New Issue
2016-03-06 21:54	WaTaKiD	Relationship added	child of 0002561
2016-11-27 09:40	Torr Samaho	Note Added: 0016337
2016-11-27 09:40	Torr Samaho	Status	new => confirmed
2016-11-27 10:01	Torr Samaho	Relationship added	has duplicate 0002652
2016-11-27 10:03	Torr Samaho	Relationship added	has duplicate 0002666
2016-11-27 10:04	Torr Samaho	Relationship added	has duplicate 0002665
2016-11-27 10:05	Torr Samaho	Relationship added	related to 0002664
2016-11-27 10:06	Torr Samaho	Relationship deleted	related to 0002664
2016-11-27 10:06	Torr Samaho	Relationship added	has duplicate 0002664
2016-11-27 10:07	Torr Samaho	Product Version	3.0-beta => 2.1
2016-11-27 10:07	Torr Samaho	Summary	client_SoundActor: Couldn't find thing => Server informs the client about map changes, before the client fully loaded the map.
2016-11-27 10:10	Torr Samaho	Note Added: 0016345
2017-03-19 11:17	Torr Samaho	Relationship added	parent of 0002947
2017-03-19 11:18	Torr Samaho	Relationship added	related to 0002952
2017-03-19 11:19	Torr Samaho	Relationship added	related to 0002951
2017-03-19 11:19	Torr Samaho	Relationship deleted	related to 0002951
2017-03-19 11:19	Torr Samaho	Relationship added	parent of 0002951
2017-03-19 11:20	Torr Samaho	Relationship deleted	related to 0002952
2017-03-19 11:20	Torr Samaho	Relationship added	parent of 0002952
2017-03-19 11:21	Torr Samaho	Relationship added	parent of 0003008
2017-03-19 11:22	Torr Samaho	Relationship added	parent of 0002950
2017-03-19 14:05	Torr Samaho	Note Added: 0017016
2017-04-15 13:12	Torr Samaho	Note Added: 0017135
2017-04-15 13:12	Torr Samaho	Assigned To	=> Torr Samaho
2017-04-15 13:12	Torr Samaho	Status	confirmed => needs testing
2022-03-02 02:52	Kaminsky	Target Version	=> 3.2
2022-03-27 19:51	WaTaKiD	Note Added: 0022168
2023-03-15 16:25	DrinkyBird	Note Added: 0022806
2023-03-15 16:26	DrinkyBird	Note Edited: 0022806	View Revisions
2024-01-02 05:27	Ru5tK1ng	Relationship added	related to 0002653
2024-01-02 05:29	Ru5tK1ng	Relationship deleted	related to 0002653
2024-01-02 05:29	Ru5tK1ng	Relationship added	parent of 0002653
2024-01-02 05:46	Ru5tK1ng	Relationship added	parent of 0002953
2024-01-02 05:50	Ru5tK1ng	Relationship added	parent of 0002946
2024-01-02 06:04	Ru5tK1ng	Note Added: 0022968
2024-01-04 17:42	Ru5tK1ng	Status	needs testing => resolved
2024-01-04 17:42	Ru5tK1ng	Resolution	open => fixed
2024-01-04 17:42	Ru5tK1ng	Fixed in Version	=> 3.2
2024-01-09 04:51	Ru5tK1ng	Relationship deleted	parent of 0002946

Notes
(0016337) Torr Samaho (administrator) 2016-11-27 09:40	This one is tricky. The server already starts sending actor updates for the new map right after it asked the client to authenticate the new map, i.e. before the client loaded the map. This way the client is asked to do stuff with actors he doesn't know about yet, which causes the warnings. One would have to prevent the server from sending this kind of updates to clients who didn't load the map yet. Adding if ( !( _flags & SVCF_ONLYTHISCLIENT ) && ( SERVER_GetClient( _current )->State == CLS_SPAWNED_BUT_NEEDS_AUTHENTICATION ) ) return false; to ClientIterator::isCurrentValid seems to do the trick, but this may possibly break other stuff since it affects all net commands.

(0016345) Torr Samaho (administrator) 2016-11-27 10:10	For the record, this is also happening in 2.1.2. We just didn't notice it, because 2.1.2 doesn't have cl_showwarnings.

(0017016) Torr Samaho (administrator) 2017-03-19 14:05	I thought about 0002667:0016337 a bit more and think this needs to be handled on a command level and integrated into the code generator.'https://bitbucket.org/zandronum/zandronum-sandbox/commits/dc038f3ec5bb3592ca6cd49f8c3dbe89a6ebf6fd [^]' is a proof of concept to fix this for 0002947.

(0017135) Torr Samaho (administrator) 2017-04-15 13:12	After further thinking about this there seems to be an easier way to fix this. 'https://bitbucket.org/zandronum/zandronum-sandbox/commits/de63310eb8c3735ee1e5e10da5cd9e4bfb1de7a4 [^]' is a very experimental attempt to fix this by simply restricting to whom broadcasted packets are sent.

(0022168) WaTaKiD (updater) 2022-03-27 19:51	'https://osdn.net/projects/zandronum/scm/hg/zandronum-stable/commits/c770f5a4161209c6dfab1e1f165ea78b83229642 [^]' has been added

(0022806) DrinkyBird (developer) 2023-03-15 16:25 edited on: 2023-03-15 16:26	The issue appears to be fixed, at least using the repro instructions given in this ticket. Actually it's also probably worth checking the child tickets as well...

(0022968) Ru5tK1ng (updater) 2024-01-02 06:04	I couldn't reproduce the issue either with r231220. I'll run through the child tickets before closing this one.