Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002590Zandronum[All Projects] Suggestionpublic2016-01-24 14:152018-09-30 21:47
ReporterIvan 
Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0 
Target Version3.0Fixed in Version3.0 
Summary0002590: A little addition to vote success/fail condition
DescriptionSome servers require spectators to join the game. How about making votes to take into account only those that are eligible to vote? For example, in a duel server in GV -> Voters can only be two people. The vote will unnecessarily wait even though both voters vote yes, no, or 1 yes 1 no. It should consider only these two voters and not the rest of the server. This would speed up vote successes. Same thing applies in ctf servers where voters have to be in game as well. What do you think?
Attached Files

- Relationships
related to 0002801closed Votekicks can be avoided by disconnecting, thus resulting in not getting banned. 
related to 0002802closed prevent newly connected clients from voting too soon 
related to 0002838closedTorr Samaho sv_maxclientsperip and Votes . 

-  Notes
User avatar (0015484)
Ivan (reporter)
2016-08-18 13:39

 I find this ticket a reasonable request that would help improve the votes. Why was there no feedback on this?
User avatar (0015486)
Dusk (developer)
2016-08-18 13:56

 It just got overlooked, I guess. This is the first time I see this. I'll take a look.
User avatar (0015488)
Edward-san (developer)
2016-08-18 13:58

 Are you sure'http://wiki.zandronum.com/Server_Variables#sv_nocallvote [^]' isn't what you need?
User avatar (0015491)
Ivan (reporter)
2016-08-18 15:55

 That's not the problem, Edward-San. What I mean is, even with spectators having no word the vote countdown doesn't take into account the eligible players properly, but rather the entire player count. (Those who can't vote are included). So, in a server of 15 people where only 2 can vote, even if that two have finished voting the countdown will wait regardless.
User avatar (0015716)
Ru5tK1ng (updater)
2016-09-27 22:29

 Ignore lines 85 and below. VS was just trolling me or something.

'https://bitbucket.org/Ru5tK1ng/zandronum/commits/d367098c7e22d6fba38bc3c87741bf5ad9b197f1?at=default [^]'
User avatar (0015743)
Torr Samaho (administrator)
2016-10-03 10:50

 The patch goes in the right direction, but can be further simplified. Please see my comments on bitbucket.
User avatar (0015745)
Ru5tK1ng (updater)
2016-10-03 20:23

 Revised based on your comments.

'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/144/when-sv_nocallvote-is-2-only-consider/diff [^]'
User avatar (0015814)
Ru5tK1ng (updater)
2016-10-08 20:39

 Code was merged:'https://bitbucket.org/Torr_Samaho/zandronum/commits/0579047ebc77628c1f8d8637de2205d540a52d17 [^]'
User avatar (0017163)
Combinebobnt (reporter)
2017-04-16 22:34

 tested in r170416-0710

it worked

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: DrinkyBird StrikerMan780 Combinebobnt FascistCat
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-01-24 14:15 Ivan New Issue
2016-08-18 13:39 Ivan Note Added: 0015484
2016-08-18 13:56 Dusk Note Added: 0015486
2016-08-18 13:58 Edward-san Note Added: 0015488
2016-08-18 15:55 Ivan Note Added: 0015491
2016-09-21 02:08 Ru5tK1ng Relationship added related to 0002802
2016-09-21 02:08 Ru5tK1ng Relationship added related to 0002838
2016-09-21 02:16 Ru5tK1ng Relationship added related to 0002801
2016-09-27 22:21 Ru5tK1ng Note Added: 0015715
2016-09-27 22:21 Ru5tK1ng Status new => needs review
2016-09-27 22:23 Ru5tK1ng Status needs review => new
2016-09-27 22:23 Ru5tK1ng Note Edited: 0015715 View Revisions
2016-09-27 22:25 Ru5tK1ng Note Deleted: 0015715
2016-09-27 22:29 Ru5tK1ng Note Added: 0015716
2016-09-27 22:29 Ru5tK1ng Status new => feedback
2016-09-27 22:29 Ru5tK1ng Status feedback => needs review
2016-10-03 10:50 Torr Samaho Note Added: 0015743
2016-10-03 10:50 Torr Samaho Status needs review => feedback
2016-10-03 10:51 Torr Samaho Target Version => 3.0
2016-10-03 20:23 Ru5tK1ng Note Added: 0015745
2016-10-03 20:23 Ru5tK1ng Status feedback => needs review
2016-10-08 20:39 Ru5tK1ng Note Added: 0015814
2016-10-08 20:39 Ru5tK1ng Status needs review => needs testing
2017-04-16 22:34 Combinebobnt Note Added: 0017163
2017-04-17 14:35 Ru5tK1ng Status needs testing => resolved
2017-04-17 14:35 Ru5tK1ng Resolution open => fixed
2017-04-17 14:35 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 21:47 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker