|Anonymous | Login | Signup for a new account||2018-06-24 12:38 UTC|
|My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001852||Zandronum||[All Projects] Bug||public||2014-06-21 14:44||2017-11-10 16:36|
|Target Version||3.1||Fixed in Version|
|Summary||0001852: Clearinventory() causes faulty armor behaviour|
|Description||If you put clearinventory() in an enter script in a map, Zandronum will seem to initially have trouble tracking your armor type when you pick up green or blue armor afterwards, causing GetArmorType() to fail (I suspect other things also fail as I've been having trouble with odd armor behaviour in a mod I'm working on, but GetArmorType() failing I can reproduce 100% so far). |
I've attached a test wad to demonstrate, see the steps to reproduce section to see how GetArmorType() fails. This error does NOT occur in GZDoom 1.8.2, but does occur in Zandronum 1.3 and 2.0.
This can be annoying if a mod wants to save a player's armor and then restore it at a later time for instance, because it could cause the armor saving to fail at saving the correct type of armor. I believe, though am not yet 100% certain, that this same bug causes the decorate function A_JumpIfArmorType to fail also.
|Steps To Reproduce||Simply walk over the green or blue armor while being sure not to pick up any armor bonuses, and you'll notice your green or blue armor count wont increase, the count will work once you pick up different armor (e.g. picking up blue armor after first picking up green). On the other hand, if you comment out the clearinventory() from the script, or if you pickup an armorbonus beforehand first, then the count will show correctly as normal.|
|Attached Files||armortest.wad [^] (8,695 bytes) 2014-06-21 14:44|
|This happens in all out war.|
|What about GZDoom 1.5.0 (the current codebase of latest 2.0 beta build)?|
|It works in that build, could not reproduce the bug in it.|
edited on: 2014-10-16 00:27
The following NETWORK_InClientMode() causes this to not work.
When I comment it out like /* NETWORK_InClientMode() */ it works, but I'm unsure if there's a reason you have that there?
Offline it fails because NETSTATE is single/single with bots.
|"Probably ZDoom should do it like this as well", I think that's the only reason. The code is originated from ZDoom.|
edited on: 2014-10-16 12:24
I don't think you read my post. The problem is it being the wrong net state when being triggered which results in clearing anyways (which didn't originate from ZDoom at all).
So ZDoom does in fact still actually wipe out ABasicArmor, but picking up GreenArmor appears to return it to the inventory. I can't seem to find where it does this in ZDoom though...
Thus, to keep in line with ZDoom, is it possible to have GreenArmor picks give the player ABasicArmor if the player doesn't have it? That seems to be what ZDoom is doing.
|This is still happening in the latest beta.|
edited on: 2017-11-10 16:36
I pushed some commits for this but I would need some input regarding GZDoom delta (I left comments on the commits).
EDIT: Changed the commits link (I'm no longer going to use my old repository so away it goes).
|Only registered users can voice their support. Click here to register, or here to log in.|
|Supporters:||Hypnotoad Catastrophe WaTaKiD|
|Opponents:||No one explicitly opposes this issue yet.|
|2014-06-21 14:44||Hypnotoad||New Issue|
|2014-06-21 14:44||Hypnotoad||File Added: armortest.wad|
|2014-06-23 19:21||Catastrophe||Note Added: 0009718|
|2014-07-05 10:17||Torr Samaho||Product Version||2.0-beta => 1.3|
|2014-07-05 10:17||Torr Samaho||Product Version||1.3 => 1.2|
|2014-07-06 11:29||Edward-san||Note Added: 0009878|
|2014-07-06 12:57||Dusk||Status||new => feedback|
|2014-07-06 15:56||Hypnotoad||Note Added: 0009880|
|2014-07-06 15:56||Hypnotoad||Status||feedback => new|
|2014-10-12 17:20||Watermelon||Assigned To||=> Watermelon|
|2014-10-12 17:20||Watermelon||Status||new => assigned|
|2014-10-16 00:27||Watermelon||Note Added: 0010606|
|2014-10-16 00:27||Watermelon||Status||assigned => needs review|
|2014-10-16 00:27||Watermelon||Note Edited: 0010606||View Revisions|
|2014-10-16 07:37||ZzZombo||Note Added: 0010611|
|2014-10-16 12:24||Watermelon||Note Added: 0010612|
|2014-10-16 12:24||Watermelon||Note Edited: 0010612||View Revisions|
|2014-10-19 23:41||Watermelon||Note Added: 0010638|
|2014-10-23 16:44||Watermelon||Assigned To||Watermelon =>|
|2014-10-23 16:44||Watermelon||Status||needs review => confirmed|
|2017-06-28 19:02||Hypnotoad||Note Added: 0017949|
|2017-10-14 12:52||Leonard||Note Added: 0018555|
|2017-10-14 12:52||Leonard||Assigned To||=> Leonard|
|2017-10-14 12:52||Leonard||Status||confirmed => needs review|
|2017-10-14 12:52||Leonard||Target Version||=> 3.1|
|2017-11-10 16:36||Leonard||Note Edited: 0018555||View Revisions|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2018 MantisBT Team|