0001462: Add support for +PUFFONACTORS flag

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001462

Zandronum

[All Projects] Suggestion

public

2013-08-14 23:23

2018-09-30 23:21

Reporter

t3hdoom

Assigned To

Torr Samaho

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

1.1.1

Target Version

2.0

Fixed in Version

2.0

Summary

0001462: Add support for +PUFFONACTORS flag

Description

Perhaps this is a bug, but I'm filing this under the assumption that it's just not been implemented. Basically, +PUFFONACTORS doesn't work, and I'd like it to. Beyond aesthetics, it's useful for modifying damage properties of bullet-based weapons.

Steps To Reproduce

A minimal way to verify this behavior is to create a PK3 containing just two files, and include it via -file when starting Zandronum.

The files and contents should be:

DECORATE.TXT
#include "newpuff.txt"

NEWPUFF.TXT
ACTOR NewPuff : BulletPuff replaces BulletPuff
{
  Game Doom
  SpawnID 131
  +NOBLOCKMAP
  +NOGRAVITY
  +ALLOWPARTICLES
  +RANDOMIZE
  +PUFFONACTORS
  RenderStyle Translucent
  Alpha 0.5
  VSpeed 1
  Mass 5
  States
  {
  Spawn:
    BFS1 AB 4 Bright
    BFE1 AB 8 Bright
    //BFGG A 4 Bright
    //BFGG B 4
    // Intentional fall-through
  Melee:
    BFS1 AB 4 Bright
    Stop
  }
}

I tested this in Zdoom, where it performs as expected, spawning the BFG sprite on both walls and actors when the pistol is fired. In Zandronum, however, it only spawns the BFG sprite on walls when the pistol is fired.

Additional Information

Specifics for +PUFFONACTORS, from the Zdoom Wiki:

"PUFFONACTORS: Used on puff objects only. A puff with this flag is spawned even if the actor being hit bleeds. Normally in such a case only blood is spawned but no puff."

Attached Files

1462.pk3 [^] (565 bytes) 2013-08-16 05:30

Relationships

Notes
(0007024) t3hdoom (reporter) 2013-08-14 23:37	Actually, it looks like this is a bug. src/p_map.cpp looks like it's supposed to spawn the puff if the flag is set, but it's not happening.

(0007027) Dusk (developer) 2013-08-15 21:11	Probably a bug... PUFFONACTORS support seems identical of that of ZDoom with the exception of A_WolfAttack which isn't even in Zandronum right now.

(0007030) t3hdoom (reporter) 2013-08-16 05:31	Uploaded 1462.pk3. I tested the behavior of this in Zdoom and in Zandronum. Run it with zdoom -iwad doom2.wad -file 1462.pk3 or zandronum -iwad doom2.wad -file 1462.pk3 Shoot the pistol in ZDoom. It shows the BFG animation on both walls and actors. Shoot the pistol in Zandronum. It only shows the BFG animation on walls, not on actors.

(0007417) Dusk (developer) 2013-10-16 13:14	Quote <@Arco> It's fixed in 2.0.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-08-14 23:23	t3hdoom	New Issue
2013-08-14 23:37	t3hdoom	Note Added: 0007024
2013-08-15 21:11	Dusk	Note Added: 0007027
2013-08-15 21:11	Dusk	Status	new => confirmed
2013-08-16 05:30	t3hdoom	File Added: 1462.pk3
2013-08-16 05:31	t3hdoom	Note Added: 0007030
2013-10-15 21:26	Arco	Status	confirmed => resolved
2013-10-15 21:26	Arco	Fixed in Version	=> 2.0
2013-10-15 21:26	Arco	Resolution	open => fixed
2013-10-15 21:26	Arco	Assigned To	=> Arco
2013-10-16 13:14	Dusk	Note Added: 0007417
2013-10-16 13:14	Dusk	Assigned To	Arco =>
2013-10-16 13:15	Dusk	Assigned To	=> Torr Samaho
2013-10-22 16:59	Dusk	Target Version	=> 2.0
2018-09-30 23:21	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.