0001325: Module loaded through LOADACS missing error check

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001325

Zandronum

[All Projects] Bug

public

2013-04-16 13:36

2014-06-13 17:58

Reporter

Positron

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

feedback

Resolution

open

Platform

Linux

Ubuntu

OS Version

10.04 x86-64

Product Version

1.0

Target Version

Fixed in Version

Summary

0001325: Module loaded through LOADACS missing error check

Description

When a module is loaded through LOADACS, certain error checks are missing. A
faulty module will also run.

The following code fragment, that does the error checking and cleanup, is
missing from the code that loads a module through LOADACS:

file: p_setup.cpp
function: P_LoadBehavior
code:
   if (!FBehavior::StaticCheckAllGood ())
   {
      Printf ("ACS scripts unloaded.\n");
      FBehavior::StaticUnloadModules ();
   }

This code is only executed for maps with a BEHAVIOR lump. So if you load a
faulty library through LOADACS while using just the doom2.wad, which has maps
without the BEHAVIOR lump, the error check will be skipped.

Attached Files

Relationships

Notes
(0006287) Watermelon (developer) 2013-04-16 14:18	Is this fixed on ZDoom?

(0006289) Edward-san (developer) 2013-04-16 21:05	The code in question is still in zdoom svn, so probably it happens there, too. Can you post an example wad with this?

(0009234) Watermelon (developer) 2014-06-13 17:58	Any updates on this?

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-04-16 13:36	Positron	New Issue
2013-04-16 14:18	Watermelon	Note Added: 0006287
2013-04-16 21:05	Edward-san	Note Added: 0006289
2014-06-13 17:58	Watermelon	Note Added: 0009234
2014-06-13 17:58	Watermelon	Status	new => feedback

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.