MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000952Zandronum[All Projects] Bugpublic2012-08-05 16:502015-09-10 11:19
ReporterKlofkac 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionduplicate 
PlatformAnyOSOS Version
Product Version98d 
Target VersionFixed in Version 
Summary0000952: Changing music with pattern serverside is not working
DescriptionWhen changing the module music with set pattern serverside, music will change, but pattern number will be ignored.
This counts for both ACS setMusic and CCMD changemus.
Locally it works as intended.
Steps To Reproduce-Make a server with example WAD containing module music
-Join as client
-Use "changemus module 10" in server console/rcon
-Use same command but in client console
Additional InformationI checked 98d source code and didn't find mention about pattern in changemus serverside:
S_ChangeMusic (argv[1], argv.argc() > 2 ? atoi (argv[2]) : 0);
if ( NETWORK_GetState( ) == NETSTATE_SERVER )
{
    SERVERCOMMANDS_SetMapMusic( argv[1] );
    SERVER_SetMapMusic( argv[1] );
}
TagsNo tags attached.
Relationships
duplicate of 0002080closed Dusk Multi-tracked NSFs won't play specified tracks when called from the server. 
Attached Files? MOD_Music.wad (163,274) 2012-08-05 16:50
/tracker/file_download.php?file_id=658&type=bug
? fastcheck.wad (70,839) 2014-06-15 18:09
/tracker/file_download.php?file_id=1228&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-08-05 16:50KlofkacNew Issue
2012-08-05 16:50KlofkacFile Added: MOD_Music.wad
2013-12-26 21:11KlofkacNote Added: 0007730
2013-12-26 21:15KlofkacNote Edited: 0007730bug_revision_view_page.php?bugnote_id=7730#r4288
2014-02-19 14:24carpathiaNote Added: 0008245
2014-02-19 14:28carpathiaNote Edited: 0008245bug_revision_view_page.php?bugnote_id=8245#r4504
2014-06-15 15:23WatermelonNote Added: 0009422
2014-06-15 15:23WatermelonStatusnew => feedback
2014-06-15 18:09KlofkacNote Added: 0009473
2014-06-15 18:09KlofkacStatusfeedback => new
2014-06-15 18:09KlofkacFile Added: fastcheck.wad
2015-09-10 11:19DuskStatusnew => closed
2015-09-10 11:19DuskResolutionopen => duplicate
2015-09-10 11:19DuskRelationship addedduplicate of 0002080

Notes
(0007730)
Klofkac   
2013-12-26 21:11   
(edited on: 2013-12-26 21:15)
Confirming that this is still untouched in Zandronum 2.0 alpha, now with support of multi track formats (like NSF or GBS) this can be really ... severe for mod makers, because they wouldn't be able to use tracks other than 0 for multiplayer mods.
(0008245)
carpathia   
2014-02-19 14:24   
(edited on: 2014-02-19 14:28)
To quote the zdoom wiki
"Note for multi-track files: In MAPINFO, append a colon plus the track number to the song name(e.g. "D_NSFSNG:5"). For ACS, use the second parameter (order) of SetMusic and LocalSetMusic. For the changemus console command, add the track number as another argument after the song name."
It should work if the map itself is set to change music to another track in the same file, however rconning a different track is still broken.
Another problem with changing track in a module is that if you use a negative number (changemus module -1) it will crash zan. If rcon were to change to a negative number, it'd crash every client who has music enabled.
(0009422)
Watermelon   
2014-06-15 15:23   
Is this fixed in 2.0?
(0009473)
Klofkac   
2014-06-15 18:09   
Nope. Did a quick test with multi track NSF and ACS SetMusic, did not work.
It worked like it should when played in single player. Attaching a file to check it yourself.
Expected behaviour: When you start the map or join a server, for the next 2 seconds the music changes to 8 bit chiptune. 2 seconds later, the different 8-bit track is run.