MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000877Zandronum[All Projects] Suggestionpublic2012-06-13 08:472018-09-30 22:11
ReporterZzZombo 
Assigned ToTorr Samaho 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0000877: Add missing constants for SetPlayerProperty action special
DescriptionIn Decorate you can't use PROP_* constants for this special right now. Please, add them from ZDoom Wiki.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0002172closed Torr Samaho Upgrade GZDoom base to 1.8.6 
Attached Filestxt decorate.txt (146) 2016-02-06 12:26
/tracker/file_download.php?file_id=1729&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-06-13 08:47ZzZomboNew Issue
2012-06-13 11:28TIHanCategoryBug => Suggestion
2012-06-13 11:29TIHanNote Added: 0003757
2012-06-13 14:08DuskSummary[Bug] Add missing constants for SetPlayerProperty action special => Add missing constants for SetPlayerProperty action special
2012-06-13 14:09DuskSeveritytweak => feature
2012-06-23 11:56ZzZomboNote Added: 0003826
2012-07-08 17:06Torr SamahoNote Added: 0003922
2012-08-05 08:30Torr SamahoStatusnew => acknowledged
2012-08-05 08:30Torr SamahoResolutionopen => backport later
2014-06-15 16:58WatermelonNote Added: 0009464
2014-06-15 16:58WatermelonStatusacknowledged => feedback
2016-02-06 12:18DuskNote Added: 0014352
2016-02-06 12:21Edward-sanResolutionbackport later => open
2016-02-06 12:26DuskFile Added: decorate.txt
2016-02-06 12:26DuskNote Edited: 0014352bug_revision_view_page.php?bugnote_id=14352#r8671
2016-02-06 12:27cobaltStatusfeedback => needs testing
2016-02-06 12:27cobaltTarget Version => 3.0
2016-02-06 12:27cobaltNote Added: 0014355
2016-02-06 12:27DuskStatusneeds testing => resolved
2016-02-06 12:27DuskFixed in Version => 3.0
2016-02-06 12:27DuskResolutionopen => fixed
2016-02-06 12:27DuskAssigned To => Torr Samaho
2016-02-06 12:28DuskRelationship addedchild of 0002172
2018-09-30 22:11Blzut3Statusresolved => closed

Notes
(0003757)
TIHan   
2012-06-13 11:29   
Please be careful what you choose as the category of this post. This one is considering a feature and not a bug.
(0003826)
ZzZombo   
2012-06-23 11:56   
Since nobody was aware I thought it would help if I do it myself:'https://bitbucket.org/ZzZombo/zandronum/changeset/62929c0d8481. [^]' BTW, can it speed up process of backporting ZDoom features if users would backport them themselves to their forks? Just asking.
(0003922)
Torr Samaho   
2012-07-08 17:06   
Let me quote what I wrote regarding this on the forum:
Quote from Torr Samaho

While I appreciate your intention to contribute to Zandronum, as general policy, I don't pull or accept patches with ZDoom backports . I already announced this and detailed why back on the Skulltag forums. To make it short: Reviewing a ZDoom backport is usually as much work as doing the backport itself, so this doesn't save me any work, it just creates more work for others. Also these individual backports make upgrading the whole ZDoom base more difficult in the future.

If you want to contribute anything other than ZDoom backports though, that would be highly welcomed!
(0009464)
Watermelon   
2014-06-15 16:58   
Is this in zan 2.0?
(0014352)
Dusk   
2016-02-06 12:18   
(edited on: 2016-02-06 12:26)
The constants appear to be present in 'constants.txt' in Zandronum 3.0. Does it work now?

EDIT: Indeed the attached DECORATE patch I just attached works in 3.0 but not in 2.0. This appears to have been backported in c7097b0bed0c.
(0014355)
cobalt   
2016-02-06 12:27   
Issue addressed by commit c7097b0bed0c: - added some constant definitions for action specials to DECORATE header. SVN r2856 (trunk)
Committed by Christoph Oelckers on Wednesday 31 December 1969 23:59:59

Changes in files:

 wadsrc/static/actors/constants.txt | 28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)