MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000858Zandronum[All Projects] Suggestionpublic2012-06-04 11:162018-09-30 21:57
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0000858: Enhanced chat input
DescriptionFeatures:
* A real chat cursor that can be moved left and right, allowing modification of the chat string mid-text. Also support for home, end and delete key.
* Long chat messages are broken onto multiple lines
* Chat archive that stores up to 10 messages
* Tab completion for player names
Steps To Reproduce
Additional Information'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/127 [^]'
TagsNo tags attached.
Relationships
parent of 0001461closed  Make the up arrow show previous messages in chat 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-04 11:16DuskNew Issue
2012-06-04 11:16DuskStatusnew => assigned
2012-06-04 11:16DuskAssigned To => Dusk
2012-06-04 11:17DuskStatusassigned => needs review
2012-06-04 11:24DuskAdditional Information Updatedbug_revision_view_page.php?rev_id=2017#r2017
2012-06-09 12:59Torr SamahoNote Added: 0003700
2012-06-09 13:00Torr SamahoNote Edited: 0003700bug_revision_view_page.php?bugnote_id=3700#r2034
2012-06-09 13:01Torr SamahoNote Revision Dropped: 3700: 0002033
2013-01-05 19:15DuskNote Added: 0005694
2013-01-05 19:15DuskStatusneeds review => assigned
2013-01-05 19:15DuskNote Edited: 0005694bug_revision_view_page.php?bugnote_id=5694#r3129
2013-01-05 19:16DuskNote Edited: 0005694bug_revision_view_page.php?bugnote_id=5694#r3130
2013-01-05 19:18DuskNote Edited: 0005694bug_revision_view_page.php?bugnote_id=5694#r3131
2013-01-06 01:49ZzZomboNote Added: 0005701
2013-01-06 03:28ZzZomboNote Edited: 0005701bug_revision_view_page.php?bugnote_id=5701#r3139
2013-08-15 21:12DuskRelationship addedparent of 0001461
2013-09-02 11:08Dark-AssassinNote Added: 0007092
2013-09-02 11:24DuskNote Added: 0007093
2013-09-02 11:26DuskNote Edited: 0007093bug_revision_view_page.php?bugnote_id=7093#r3978
2013-09-02 11:37Dark-AssassinNote Added: 0007094
2013-09-02 11:41Dark-AssassinNote Edited: 0007094bug_revision_view_page.php?bugnote_id=7094#r3980
2013-09-02 11:48Dark-AssassinNote Edited: 0007094bug_revision_view_page.php?bugnote_id=7094#r3981
2013-09-02 12:03DuskNote Added: 0007095
2013-09-03 08:47FritsNote Added: 0007096
2013-09-03 08:47FritsNote Edited: 0007096bug_revision_view_page.php?bugnote_id=7096#r3983
2013-09-03 08:50FritsNote Edited: 0007096bug_revision_view_page.php?bugnote_id=7096#r3984
2013-09-03 09:04DuskNote Added: 0007097
2013-09-03 14:16FritsNote Added: 0007098
2013-09-03 19:43DuskNote Added: 0007099
2013-09-03 20:42FritsNote Added: 0007100
2016-07-17 21:18DuskNote Added: 0015366
2016-07-17 21:20DuskDescription Updatedbug_revision_view_page.php?rev_id=9349#r9349
2016-07-17 21:20DuskAdditional Information Updatedbug_revision_view_page.php?rev_id=9350#r9350
2016-07-17 21:20DuskStatusassigned => needs review
2016-07-17 21:20DuskDescription Updatedbug_revision_view_page.php?rev_id=9351#r9351
2016-07-17 21:21DuskNote Edited: 0015366bug_revision_view_page.php?bugnote_id=15366#r9353
2016-08-14 10:10Torr SamahoNote Added: 0015447
2016-08-14 10:10Torr SamahoStatusneeds review => feedback
2016-08-14 21:23DuskStatusfeedback => needs testing
2016-08-14 21:24DuskFixed in Version => 3.0
2016-08-14 21:24DuskTarget Version => 3.0
2016-08-18 01:15CombinebobntNote Added: 0015469
2016-08-18 01:26CombinebobntNote Edited: 0015469bug_revision_view_page.php?bugnote_id=15469#r9408
2016-09-18 16:07Ru5tK1ngNote Added: 0015661
2016-11-23 01:58Ru5tK1ngNote Added: 0016292
2016-11-23 01:58Ru5tK1ngStatusneeds testing => resolved
2016-11-23 01:58Ru5tK1ngResolutionopen => fixed
2018-09-30 21:57Blzut3Statusresolved => closed

Notes
(0003700)
Torr Samaho   
2012-06-09 12:59   
(edited on: 2012-06-09 13:00)
Technical remark: If you want me to be able to pull a branch from your fork, you have to base your branch on *my* latest changeset (or at least on one of my changesets), it may not be based on any of your changesets. "My" here means a changeset that exists in my Zandronum repository.

This is because pulling a changeset requires to pull every single ancestor changeset. So if I wanted to pull your chaticon branch, among other things, I would be forced to pull your neurosphere rebranding.

Regarding the feature at hand: Did anybody test how well this works? This involves quite a lot of code changes, so just judging to include this based on reading the code is difficult.
(0005694)
Dusk   
2013-01-05 19:15   
(edited on: 2013-01-05 19:18)
OK so update on this: I've been using this input on my client pretty much since I first posted this ticket here and it seems to work fine except for a couple of things:

- I added a sort of chat archive, AKA you can access messages you had already sent using the up/down keys. I'll have to test this a little bit to weed out possible problems.
- When the cursor is moved across the chat field, the underscore used for the cursor can easily be mistaken for a whitespace. Someone could have "Hi_there" and see it right yet it actually is "Hithere" when he actually posts the message. I'll have to brainstorm this a little.

This is my current diff against the 1.0 source.
(0005701)
ZzZombo   
2013-01-06 01:49   
(edited on: 2013-01-06 03:28)
Can't you make the cursor to flick like text cursors outside of the game do? Can you repeatedly replace _ with a space and back to make an illusion the cursor flicks?
(0007092)
Dark-Assassin   
2013-09-02 11:08   
IMO using | would be a better cursor than _.
Also, possibly have it a different color to the rest of the chat color, so it can easily be seen.
(0007093)
Dusk   
2013-09-02 11:24   
(edited on: 2013-09-02 11:26)
There is no '|' glyph in Doom. 'i' would drive it in the vanilla font but for one there's Heretic and Hexen which use a lowercase 'i' and there are fonts out there for Doom that have a serifed 'I'. I'm wondering if a custom graphic is the way to go here.
(0007094)
Dark-Assassin   
2013-09-02 11:37   
(edited on: 2013-09-02 11:48)
Hmm...
Would it be any possible to have the _ show under the text instead of between letters?

Edit: Well, the ! is similar between all the major IWADs.
Also, noticed that Strife uses [ instead of _.

Also, possibly the best color would be that similar of \c[] or \c+ ?
AFAIK \c[] is the default text color while \c+ is the secondary default.
(I'm just referencing from chat strings)
(0007095)
Dusk   
2013-09-02 12:03   
Quote from "#zatesting"

[14:49:16] <@Dusk> hmm
[14:49:26] <@Dusk> that'd imply replace mode
[14:49:37] <@Dusk> and it works with insert mode rather
[14:50:17] <@Dark-Assassin> About having the _ cursor show under?
[14:51:03] <@Dusk> yeah
[14:51:06] <@Dark-Assassin> Hmm
[14:51:30] <@Dark-Assassin> Well, could either use ! or [ (like strife)
[14:51:51] <@Dusk> that'd kinda look weird
[14:52:21] <@Dusk> and the problem with a custom graphic is getting it to look consistent within all iwads
[14:52:34] <@Dark-Assassin> Well, It's probably all there is that looks closest to |
[14:53:08] <@Dusk> tho eh it'd be a 2 x 8 bar
[14:53:29] <@Dusk> also keep in mind that pwads can change font glyphs into whatever they want
[14:53:41] <@Dusk> a custom graphic would be impervious to this
[14:53:42] <@Dark-Assassin> I know. But ! is the most common between all I tried.
[14:53:48] <@Dark-Assassin> True
[14:53:56] <@Dusk> unless a pwad changes it as well but at that point it's intended for such usage
[14:54:05] <@Dark-Assassin> Else, you could have the whole chat input use ConsFont.
[14:54:09] <@Dusk> using a different glyph, from this perspective, is hacky
[14:54:18] <@Dusk> eh i don't want to do that
[14:55:06] <@Dusk> inserting a graphic shouldn't be that hard to do either
(0007096)
Frits   
2013-09-03 08:47   
(edited on: 2013-09-03 08:50)
Why don't you go "Source/Goldsrc" style on the chat input (tf2, counter-strike)

like this:'http://cloud-2.steampowered.com/ugc/558699179526565824/902045494E1D9133E9A89D59E4E154F87E25112C/1024x576.resizedimage [^]'


It's like a small console popping up, free of any custom mods font changes or whatever.
(0007097)
Dusk   
2013-09-03 09:04   
That doesn't really solve anything. Some font still has to be used to draw the text and the chat would appear duplicated, once in the notify area and another time in the chat box.
(0007098)
Frits   
2013-09-03 14:16   
Not a coder but I actually ment taking the whole system as in source for zandronum.
Meaning that the chat box contains all chat related functions, including displaying the chat instead of using the upper right corner.
It's basically a tiny console with uses the (hardcoded? again idk)default font. In other words a totally independent chat system.
Advantages would be:
1)No more chat font changing between pwads (damn some unreadable fonts)
2)No mixing of chat messages and game messages (eg picking up 10 vials/frags/(dis)connecting and having to scroll up in the console)

Disadvantages would be coding it and totally not liking it.
(0007099)
Dusk   
2013-09-03 19:43   
... the heck are you talking about. That is Source, this is Doom. You don't just take stuff from source (I doubt it's open source to begin with) and slap it into Doom. The underlying code bases are almost two decades apart.
(0007100)
Frits   
2013-09-03 20:42   
I didn't mean for you to take it from source. I just pointed out its chat system is nice.
(0015366)
Dusk   
2016-07-17 21:18   
(edited on: 2016-07-17 21:21)
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/127 [^]'

This is back from the dead with a complete do-over and a few new features. The blinking cursor is gone though. I may eventually figure out how to implement it in a sane manner later on.
(0015447)
Torr Samaho   
2016-08-14 10:10   
I added your patch, but noticed a small bug when testing: Resending an archive message without changes will put an empty message into the chat history.
(0015469)
Combinebobnt   
2016-08-18 01:15   
(edited on: 2016-08-18 01:26)
ok i tested everything in the list and tried to spam every button i could, everything worked. I couldn't reproduce the empty chat message on archive

edit: good job ral found a bug. You can't hold backspace to clear your name in player setup anymore
(0015661)
Ru5tK1ng   
2016-09-18 16:07   
That's not a bug. The menu was changed to the style that G/Zdoom has and that's how backspace works there.
(0016292)
Ru5tK1ng   
2016-11-23 01:58   
No new issues reported since bob's initial test.