MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000849Zandronum[All Projects] Bugpublic2012-05-17 10:012018-09-30 19:52
ReporterDusk 
Assigned ToDusk 
PriorityhighSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0-beta 
Target VersionFixed in Version1.0 
Summary0000849: Stronghold STR20 triggers an assertion failure on server
DescriptionWhen a client connects to a Stronghold server on STR20, the server will instantly trigger an assertion failure.
Steps To ReproduceStart up a server with strnghld_v1.pk3 and change to STR20. Connect a client and the server will in most cases abort instantly, in other cases you may need to do an additional "map str20" to trigger it.
Additional Informationcompatflags changed to: 0
Connect (v0.98e-alpha): 127.0.0.1:10667
skulltag: /home/dusk/src/skulltag/src/p_sight.cpp:647: bool P_CheckSight(const AActor*, const AActor*, int): Assertion `t2 != __null' failed.
Aborted
TagsNo tags attached.
Relationships
related to 0000995closed Torr Samaho Server crash with Brutal Doom 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-17 10:01DuskNew Issue
2012-05-17 14:00DuskDescription Updatedbug_revision_view_page.php?rev_id=2003#r2003
2012-05-17 14:00DuskSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2005#r2005
2012-05-22 23:54DuskAssigned To => Dusk
2012-05-22 23:54DuskStatusnew => assigned
2012-05-23 00:52DuskNote Added: 0003653
2012-05-23 00:52DuskStatusassigned => needs testing
2012-05-23 00:52DuskStatusneeds testing => needs review
2012-05-27 06:42Torr SamahoNote Added: 0003657
2012-05-27 06:42Torr SamahoStatusneeds review => needs testing
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2012-07-29 00:14DuskNote Added: 0004118
2012-07-29 00:14DuskStatusneeds testing => resolved
2012-07-29 00:14DuskFixed in Version => 1.0-beta
2012-07-29 00:14DuskResolutionopen => fixed
2012-08-23 01:54Blzut3Fixed in Version1.0-beta => 1.0
2012-08-28 11:13DuskRelationship addedrelated to 0000995
2018-09-30 19:52Blzut3Statusresolved => closed

Notes
(0003653)
Dusk   
2012-05-23 00:52   
Fixed:'https://bitbucket.org/CrimsonDusk/notebola/changeset/ee687a1e2fa7 [^]'

There was a mispositioned player check that was done after P_CheckSight, not before it, allowing NULL to be passed to P_CheckSight, triggering the assert fail.
(0003657)
Torr Samaho   
2012-05-27 06:42   
I added your patch. It should have no effect on any of the official binaries (other than pr_newchasedir() being called less often) though, since assert should do nothing in release mode binaries. That's why I imported your patch directly and didn't update the history txt.
(0004118)
Dusk   
2012-07-29 00:14   
Didn't know that one about assertions.. anyway it doesn't happen with the latest beta build anymore (was compiled from source fwiw) and thus I'd consider it fixed.