MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000830Zandronum[All Projects] Bugpublic2012-05-02 02:152015-01-17 11:10
ReporterTIHan 
Assigned ToTIHan 
PrioritynormalSeverityminorReproducibilityalways
StatusfeedbackResolutionopen 
PlatformOSOS Version
Product Version1.0-beta 
Target Version1.0Fixed in Version 
Summary0000830: Poly objects with more than one thinker were not properly reset on map reset.
DescriptionSince I was not able to find a wad that had a case where there were two thinkers on a poly object, I wasn't able to accommodate the map reset for this particular case. I figured it out while testing a custom build that enabled hubs to work with Survival, as with Hexen map31 had poly objects with more than one thinker. I was able to spot the bug.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001022closed Edward-san Rotating polyobjects aren't reset after map resets online 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-02 02:15TIHanNew Issue
2012-05-02 02:15TIHanStatusnew => assigned
2012-05-02 02:15TIHanAssigned To => TIHan
2012-05-02 03:04TIHanNote Added: 0003554
2012-05-02 03:04TIHanStatusassigned => needs review
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2012-06-24 09:24Torr SamahoNote Added: 0003832
2012-06-24 10:48Torr SamahoStatusneeds review => feedback
2012-06-24 16:00TIHanNote Added: 0003842
2012-06-24 16:00TIHanStatusfeedback => assigned
2012-06-24 16:22Torr SamahoNote Added: 0003844
2012-06-24 16:24Torr SamahoStatusassigned => feedback
2015-01-17 11:10Edward-sanRelationship addedrelated to 0001022

Notes
(0003554)
TIHan   
2012-05-02 03:04   
Fixed.
'https://bitbucket.org/TIHan/tst/changeset/3f47758958d3 [^]'
I also fixed a minor bug in that the sequence sound did not play when a poly door started closing.
(0003832)
Torr Samaho   
2012-06-24 09:24   
Is there an example wad that allows to check the "poly objects with more than one thinker" problem?

> I also fixed a minor bug in that the sequence sound did not play when a poly door started closing.

That part of the fix possibly passes a wrong forth argument to SN_StartSequence: On the client the forth argument is always 0, on the server it is m_Close.
(0003842)
TIHan   
2012-06-24 16:00   
Thanks for the review.

> Is there an example wad that allows to check the "poly objects with more than one thinker" problem?

I really wish I had one. I tested by commenting out the hub check and running Hexen map31 in survival.

> On the client the forth argument is always 0, on the server it is m_Close.

Didn't notice that. Should we extend the server command for this argument?
(0003844)
Torr Samaho   
2012-06-24 16:22   
> I really wish I had one. I tested by commenting out the hub check and running Hexen map31 in survival.

Can somebody create an example wad for this?

> Didn't notice that. Should we extend the server command for this argument?

Depending on which values m_Close can take it may be sufficient to introduce a new NETWORK_POLYOBJSOUND_e enum and use that accordingly.