MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000814Zandronum[All Projects] Bugpublic2012-04-25 11:592018-09-30 23:38
ReporterTheMisterCat 
Assigned ToWatermelon 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target Version1.4Fixed in Version1.4 
Summary0000814: Light_Fade without any tic duration fails to fade online
Description
Quote from unknownna
Quote from TheMisterCat
Light_Fade does not function at all online.

It does function online, but Light_Fade without any tic duration will fail to fade online.
Steps To Reproduce1. skulltag.exe -file light_fade_01.wad -host
2. Connect a client to the server and join the game.
3. Push the switches.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? light_fade_01.wad (2,520) 2012-04-25 11:59
/tracker/file_download.php?file_id=579&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-04-25 11:59unknownnaNew Issue
2012-04-25 11:59unknownnaFile Added: light_fade_01.wad
2012-04-25 11:59unknownnaStatusnew => confirmed
2012-04-25 12:05unknownnaReporterunknownna => TheMisterCat
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2014-10-11 16:19WatermelonNote Added: 0010496
2014-10-11 16:19WatermelonAssigned To => Watermelon
2014-10-11 16:19WatermelonStatusconfirmed => needs review
2014-10-12 19:24Torr SamahoNote Added: 0010557
2014-10-12 21:19WatermelonStatusneeds review => assigned
2014-10-12 23:46DuskNote Added: 0010563
2014-10-13 15:26WatermelonNote Added: 0010569
2014-10-13 15:26WatermelonStatusassigned => needs review
2014-10-13 18:55cobaltStatusneeds review => needs testing
2014-10-13 18:55cobaltTarget Version => 1.4
2014-10-13 18:55cobaltDescription Updatedbug_revision_view_page.php?rev_id=5750#r5750
2014-10-13 18:55cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5752#r5752
2014-10-13 18:55cobaltNote Added: 0010571
2014-10-13 23:36ArcoNote Added: 0010577
2014-10-13 23:36ArcoStatusneeds testing => feedback
2014-10-13 23:36ArcoDescription Updatedbug_revision_view_page.php?rev_id=5756#r5756
2014-10-13 23:36ArcoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5757#r5757
2014-10-14 03:02WatermelonNote Added: 0010581
2014-10-14 16:59WatermelonNote Added: 0010583
2014-10-14 23:04WatermelonNote Added: 0010588
2014-10-14 23:04WatermelonStatusfeedback => assigned
2014-10-14 23:41WatermelonNote Added: 0010589
2014-10-14 23:41WatermelonStatusassigned => needs review
2014-10-15 06:07cobaltStatusneeds review => needs testing
2014-10-15 06:07cobaltDescription Updatedbug_revision_view_page.php?rev_id=5761#r5761
2014-10-15 06:07cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5762#r5762
2014-10-15 06:07cobaltNote Added: 0010591
2014-10-15 22:04StrikerMan780Note Added: 0010600
2015-03-16 01:26DuskStatusneeds testing => resolved
2015-03-16 01:26DuskFixed in Version => 1.4
2015-03-16 01:26DuskResolutionopen => fixed
2018-09-30 23:38Blzut3Statusresolved => closed

Notes
(0010496)
Watermelon   
2014-10-11 16:19   
Requesting code review:

'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/c2db25f44763bdcb87d9c04e832ab05121529079 [^]'
(0010557)
Torr Samaho   
2014-10-12 19:24   
The patch looks ok.
(0010563)
Dusk   
2014-10-12 23:46   
Nitpick: the comments on lines 718-720 imply that the main reason for the new code block is not to update the variable if it hasn't changed while the real reason for it is preventing wasting bandwidth.
(0010569)
Watermelon   
2014-10-13 15:26   
Fixed comments as for what Dusk said.

Pull request sent.
(0010571)
cobalt   
2014-10-13 18:55   
Issue addressed by commit d470e1b042d1: Instant light fading was not updated on the client's side (fixes 814).
Committed by WChrisK on Monday 13 October 2014 11:25:17

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/p_lights.cpp | 12 +++++++++++-
 2 files changed, 12 insertions(+), 1 deletions(-)
(0010577)
Arco   
2014-10-13 23:36   
The light in the testing map does not properly revert to its proper color after map restarts.
(0010581)
Watermelon   
2014-10-14 03:02   
That's interesting, it did for me. I will investigate further. You're on windows right?


Do you mean 'color' or light level?
(0010583)
Watermelon   
2014-10-14 16:59   
I just tested it on Linux and it worked perfectly in the wad. Are you sure you got the latest version?
(0010588)
Watermelon   
2014-10-14 23:04   
So apparently the light does not reset when countdowns are involved, but works fine in coop and other similar modes.
(0010589)
Watermelon   
2014-10-14 23:41   
Pull request sent, luckily this was a trivial fix.
(0010591)
cobalt   
2014-10-15 06:07   
Issue addressed by commit 31047954d012: A light level changed was not mark for an instant fading workaround fix, which resulted in not being reset properly (further fixes 814).
Committed by WChrisK on Tuesday 14 October 2014 19:44:43

Changes in files:
 src/p_lights.cpp | 1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
(0010600)
StrikerMan780   
2014-10-15 22:04   
Hitting the switches in light_test_01.wad seems to work fine on a server running this build:'http://l.xd.cm:8080/builders/windows-x86-stable/builds/18 [^]'