MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000769Zandronum[All Projects] Bugpublic2012-04-13 20:492018-09-30 22:47
ReporterHisymak 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.0-beta 
Target VersionFixed in Version 
Summary0000769: [Hexen] The "poison cough" sound doesn't play online when player touches poison cloud
DescriptionIn Hexen, there is a poison cloud that hurt player on monster on contact. It can be spawned with Cleric's flechette or by destroying poison mushroom. When player touches the cloud, he makes a "cough"-like sound. The sound plays offline but not online.
Steps To Reproduce- Create Hexen server
- Connect and join as Cleric
- Get a flechette
- Use it
- Go into the poison cloud
- The "cough" sound won't play
Additional Information
TagsNo tags attached.
Relationships
Attached Fileswav POIS2.wav (12,313) 2012-04-13 20:49
/tracker/file_download.php?file_id=539&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-04-13 20:49HisymakNew Issue
2012-04-13 20:49HisymakFile Added: POIS2.wav
2012-04-14 00:32DuskAssigned To => Dusk
2012-04-14 00:32DuskStatusnew => assigned
2012-04-14 00:33DuskNote Added: 0003237
2012-04-14 00:33DuskProduct Version98d => 1.0-beta
2012-04-14 01:01DuskNote Added: 0003238
2012-04-14 01:01DuskStatusassigned => feedback
2012-04-14 01:22DuskNote Edited: 0003238bug_revision_view_page.php?bugnote_id=3238#r1725
2012-04-15 11:39HisymakNote Added: 0003282
2012-04-15 11:39HisymakStatusfeedback => assigned
2012-04-15 14:07DuskNote Added: 0003283
2012-04-15 14:07DuskStatusassigned => feedback
2012-04-15 15:20Edward-sanNote Added: 0003286
2012-04-15 15:39Edward-sanNote Edited: 0003286bug_revision_view_page.php?bugnote_id=3286#r1743
2012-04-15 16:07Torr SamahoNote Added: 0003287
2012-04-15 16:09Torr SamahoNote Edited: 0003287
2012-04-15 16:09Torr SamahoNote Edited: 0003287
2012-04-15 16:10Torr SamahoNote Edited: 0003287bug_revision_view_page.php?bugnote_id=3287#r1747
2012-04-15 16:10Torr SamahoNote Revision Dropped: 3287: 0001744
2012-04-15 16:10Torr SamahoNote Revision Dropped: 3287: 0001745
2012-04-15 16:10Torr SamahoNote Revision Dropped: 3287: 0001746
2012-04-15 17:31DuskNote Added: 0003290
2012-04-15 18:51DuskNote Added: 0003295
2012-04-16 02:11DuskNote Added: 0003316
2012-04-16 02:11DuskStatusfeedback => resolved
2012-04-16 02:11DuskResolutionopen => fixed
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2018-09-30 22:47Blzut3Statusresolved => closed

Notes
(0003237)
Dusk   
2012-04-14 00:33   
Looks like there's further issues related to the poison cloud than just the sound... health gets desynced there too.
(0003238)
Dusk   
2012-04-14 01:01   
(edited on: 2012-04-14 01:22)
'https://bitbucket.org/CrimsonDusk/notebola/changeset/402d47903781 [^]'

This should fix the issues.

BTW: P_PoisonDamage is only called in the poison bag code (initial) and further down in P_PlayerThink (where the over-time poison damage is applied). Therefore, sealing clients off the whole function shouldn't cause any problems.
(0003282)
Hisymak   
2012-04-15 11:39   
I noticed another problem with sounds in Hexen.
If you play online and you are morphed into pig, some pig's sounds don't play. I noticed the "bite" sound is not playing when you bite something.
Steps to reproduce:
- Start Hexen server with cheats on
- Join and use "morphme" command
- Try to bite the pot or dead tree. The "bite" sound won't play.
I also encountered other sounds not playing, but I can't reproduce it now.
(0003283)
Dusk   
2012-04-15 14:07   
Fixed bite sound:'https://bitbucket.org/CrimsonDusk/notebola/changeset/291c0969393c [^]'
(0003286)
Edward-san   
2012-04-15 15:20   
(edited on: 2012-04-15 15:39)
Just a curiosity: why S_Sound doesn't handle the SERVERCOMMANDS_SoundActor inside the code?
Don't tell me there's a portion of code which requires S_Sound without SERVERCOMMANDS_SoundActor...
(0003287)
Torr Samaho   
2012-04-15 16:07   
(edited on: 2012-04-15 16:10)
>'https://bitbucket.org/CrimsonDusk/notebola/changeset/402d47903781 [^]'

Patch added.

>'https://bitbucket.org/CrimsonDusk/notebola/changeset/291c0969393c [^]'

Usual problem: If you adjust a code pointer to let the server inform the clients about the outcome, don't let the clients execute the code pointer.

> Don't tell me there's a portion of code which requires S_Sound without SERVERCOMMANDS_SoundActor...

There are such portions. One could add an additional optional argument to S_Sound to streamline this somewhat.
(0003290)
Dusk   
2012-04-15 17:31   
> Usual problem: If you adjust a code pointer to let the server inform the clients about the outcome, don't let the clients execute the code pointer.

Sealed A_SnoutAttack off clients:
'https://bitbucket.org/CrimsonDusk/notebola/changeset/76bb9195fe60 [^]'
(0003295)
Dusk   
2012-04-15 18:51   
After talk with Torr, a more bandwidth friendly solution:
'https://bitbucket.org/CrimsonDusk/notebola/changeset/03b8abae281d [^]'
(0003316)
Dusk   
2012-04-16 02:11   
Fix confirmed working in latest beta build.