MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000767Zandronum[All Projects] Suggestionpublic2012-04-12 11:002015-09-06 17:13
ReporterDusk 
Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
StatusconfirmedResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0000767: PLAYPAL protection
DescriptionWhy is PLAYPAL a protected lump? I see no reason for that. I've heard the reason that playpals could be used to cheat in the form of making everything appear bright.

This is not true, as playpals do not have anything to do with the actual brightnesses of the sector - only what colors get shown on your screen. If you increase the brightness of the colors of your playpal, all you get is an effect similar to bumping the gamma. I guess it can make a few full-bright objects appear brighter in the dark.. making it pretty much an eye-strain and gamma already does a greater effect than this.

It's the colormap which can be used to make everything brighter (in fact AOW's colormap does just this) and thus that should remained protected. Protecting playpal though IMO is just unnecessary and detrimental as it could be a good element for autoloaded wad addons. :)

I'm raising a question here mostly, I think I may be missing something. I don't understand why PLAYPAL is protected, though.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Fileszip brightpal.wad.zip (723) 2012-04-12 11:00
https://zandronum.com/tracker/file_download.php?file_id=537&type=bug
zip grayscalepal.wad.zip (4,508) 2012-04-14 01:08
https://zandronum.com/tracker/file_download.php?file_id=540&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-04-12 11:00DuskNew Issue
2012-04-12 11:00DuskFile Added: brightpal.wad.zip
2012-04-12 23:32Torr SamahoNote Added: 0003223
2012-04-12 23:48unknownnaNote Added: 0003226
2012-04-14 01:08DuskFile Added: grayscalepal.wad.zip
2012-04-14 01:13DuskNote Added: 0003239
2012-04-14 15:13Torr SamahoNote Added: 0003244
2014-06-11 21:22WatermelonNote Added: 0009103
2014-06-11 21:22WatermelonStatusnew => confirmed
2015-09-06 17:13DuskNote Added: 0013442

Notes
(0003223)
Torr Samaho   
2012-04-12 23:32   
Someone requested the PLAYPAL and the COLORMAP to be protected a long time ago. After a quick look I'd say you can disable the screen flashes with PLAYPAL (i.e. completely remove the blood tint on damage or the green tint when you wear a radsuit). What exactly would you use this for if it should get unprotected?
(0003226)
unknownna   
2012-04-12 23:48   
> After a quick look I'd say you can disable the screen flashes with PLAYPAL (i.e. completely remove the blood tint on damage or the green tint when you wear a radsuit).

Is it possible to disable the berserk, invisibility and invulnerability effects with a custom PLAYPAL/COLORMAP lump? If so, the lumps ought to be protected.

BTW: We do have blood_fade_scalar and there's no dmflag to enable/disable the custom flash intensity. Speaking of which, why is there not an option to adjust the pickup flash intensity as well?
(0003239)
Dusk   
2012-04-14 01:13   
Altering the palettes other than the first, primary one has no effect. You cannot knock out the radsuit/hurt effects with this. See attached grayscalepal, all palettes but the first one are made grayscale. Get hurt or grab a radsuit or an item and you will see the effects are still present.

In fact, ZDoom Wiki says here that it only reads the first palette of PLAYPAL.

COLORMAP should remain protected, you can completely disable darkness with the lump. (though GL users can do that anyway unless sv_forcegldefaults but let's not go into there) It's PLAYPAL what I'm after here.

> What exactly would you use this for if it should get unprotected?
It could be useful for autoload wads to change the appearance. The palette has a big effect on the athmosphere, and having that option disabled for no apparent valid reason feels unnecessary.
(0003244)
Torr Samaho   
2012-04-14 15:13   
> The palette has a big effect on the athmosphere, and having that option disabled for no apparent valid reason feels unnecessary.

If you can significantly change how things are looking, I'm pretty sure that there is a way to abuse it, like making black things white or something like this (I'm not talking about the lighting).
(0009103)
Watermelon   
2014-06-11 21:22   
To be hopefully fixed in the future, I know a new lump protection ticket was opened.
(0013442)
Dusk   
2015-09-06 17:13   
I still remain unconvinced that playpals can be used for cheating. You can't make things any brighter with it than what you can already make them with other ways (gamma and e.g. cl_overrideplayercolors).