MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000746Zandronum[All Projects] Bugpublic2012-03-29 14:432018-09-30 22:36
Reporterunknownna 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target VersionFixed in Version 
Summary0000746: Player keeps his custom skin color after morphing online
DescriptionThere's a difference between ST and ZDoom. ST behaves like ZDoom offline, but online however, the player keeps his/her custom skin color after morphing.
Steps To Reproduce
Additional InformationI tested ZDoom 2.5.0 online and the offline/online behavior was consistent there.
TagsNo tags attached.
Relationships
Attached Filespng Screenshot_Doom_20120329_163929.png (100,342) 2012-03-29 14:43
/tracker/file_download.php?file_id=498&type=bug
png

? morph_bug_test_08.wad (2,654) 2012-03-29 14:46
/tracker/file_download.php?file_id=499&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-03-29 14:43unknownnaNew Issue
2012-03-29 14:43unknownnaFile Added: Screenshot_Doom_20120329_163929.png
2012-03-29 14:43unknownnaStatusnew => confirmed
2012-03-29 14:46unknownnaFile Added: morph_bug_test_08.wad
2012-03-29 15:01TIHanAssigned To => TIHan
2012-03-29 15:01TIHanStatusconfirmed => assigned
2012-03-30 05:07TIHanNote Added: 0003042
2012-03-30 05:07TIHanStatusassigned => feedback
2012-03-31 16:05Torr SamahoNote Added: 0003059
2012-04-01 19:10unknownnaNote Added: 0003084
2012-04-01 19:10unknownnaStatusfeedback => assigned
2012-04-01 19:38TIHanNote Added: 0003088
2012-04-01 20:13Torr SamahoNote Added: 0003091
2012-04-01 20:18unknownnaNote Added: 0003093
2012-04-01 21:47Torr SamahoNote Added: 0003096
2012-04-01 21:57unknownnaNote Added: 0003098
2012-04-01 21:59Torr SamahoNote Added: 0003099
2012-04-01 21:59Torr SamahoStatusassigned => feedback
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2016-04-18 02:16Ru5tK1ngAssigned ToTIHan =>
2016-04-18 02:16Ru5tK1ngStatusfeedback => resolved
2016-04-18 02:16Ru5tK1ngResolutionopen => fixed
2018-09-30 22:36Blzut3Statusresolved => closed

Notes
(0003042)
TIHan   
2012-03-30 05:07   
Fixed.
'https://bitbucket.org/TIHan/tst/changeset/e87f26987a19 [^]'
(0003059)
Torr Samaho   
2012-03-31 16:05   
When adding your patch I noticed another bug using the example wad from this ticket: A morphed player possibly changed his skin back to his unmorphed custom skin online after starting to move. I added a fix for this, would be nice if somebody can check this in the next beta build before this is closed.
(0003084)
unknownna   
2012-04-01 19:10   
There's a practical side effect to this fix. In a team game, morphed players (mechs in AOW2) look neutral, i.e., green-colored.

And I noticed another unrelated issue: Morphed players turning into spectators (not disconnecting) leave a dummy player behind. This dummy player reflects the corresponding player's skin. If the corresponding player disconnects, the dummy player disappears. You can confirm this with cl_identifytarget. Should I create a new ticket for this?

> I added a fix for this, would be nice if somebody can check this in the next beta build before this is closed.

With your latest timelimit crash fix build I can confirm that you've fixed the issue.
(0003088)
TIHan   
2012-04-01 19:38   
> There's a practical side effect to this fix. In a team game, morphed players (mechs in AOW2) look neutral, i.e., green-colored.

You can handle this in two ways:
1. Backout the fix.
2. Accommodate team games to allow custom color skins when morphed.
(0003091)
Torr Samaho   
2012-04-01 20:13   
> Morphed players turning into spectators (not disconnecting) leave a dummy player behind. This dummy player reflects the corresponding player's skin. If the corresponding player disconnects, the dummy player disappears. You can confirm this with cl_identifytarget. Should I create a new ticket for this?

Yes, please make a new ticket for this.

> There's a practical side effect to this fix. In a team game, morphed players (mechs in AOW2) look neutral, i.e., green-colored.

What was the behavior before the patch in team games? Was the team color is enforced on morphed players?
(0003093)
unknownna   
2012-04-01 20:18   
> Was the team color is enforced on morphed players?

Yes.

> Yes, please make a new ticket for this.

Alright.
(0003096)
Torr Samaho   
2012-04-01 21:47   
> 2. Accommodate team games to allow custom color skins when morphed.

I think that's the way to go and tried this. Please test if this fixes the issue.
(0003098)
unknownna   
2012-04-01 21:57   
It fixed the issue from what I can tell.
(0003099)
Torr Samaho   
2012-04-01 21:59   
Ok, then I'll commit the fix. Won't hurt if this gets some more testing once the next beta build is out. So let's leave this on feedback till then.