MantisBT - Zandronum
View Issue Details
0000738Zandronum[All Projects] Bugpublic2012-03-28 19:132012-04-03 04:08
unknownna 
TIHan 
normalminoralways
acknowledgedopen 
1.0-beta 
 
0000738: "Ouch" face not displayed online
The "ouch" face isn't displayed online.
No tags attached.
jpg ouch.JPG (3,305) 2012-03-28 19:13
https://zandronum.com/tracker/file_download.php?file_id=484&type=bug
jpg

? ouch_test_01.wad (1,334) 2012-03-29 00:19
https://zandronum.com/tracker/file_download.php?file_id=488&type=bug
png Screenshot_Doom_20120329_103248.png (64,678) 2012-03-29 08:36
https://zandronum.com/tracker/file_download.php?file_id=490&type=bug
png
Issue History
2012-03-28 19:13unknownnaNew Issue
2012-03-28 19:13unknownnaFile Added: ouch.JPG
2012-03-28 19:14unknownnaStatusnew => confirmed
2012-03-28 19:52TIHanAssigned To => TIHan
2012-03-28 19:52TIHanStatusconfirmed => assigned
2012-03-28 20:01Edward-sanNote Added: 0002967
2012-03-29 00:19unknownnaFile Added: ouch_test_01.wad
2012-03-29 00:20unknownnaNote Added: 0002975
2012-03-29 02:55TIHanNote Added: 0002982
2012-03-29 02:55TIHanStatusassigned => feedback
2012-03-29 08:36unknownnaNote Added: 0002986
2012-03-29 08:36unknownnaStatusfeedback => assigned
2012-03-29 08:36unknownnaFile Added: Screenshot_Doom_20120329_103248.png
2012-03-29 09:05Edward-sanNote Edited: 0002967bug_revision_view_page.php?bugnote_id=2967#r1527
2012-03-29 13:08TIHanNote Added: 0003000
2012-03-29 13:09TIHanStatusassigned => feedback
2012-03-29 13:12unknownnaNote Added: 0003001
2012-03-29 13:12unknownnaStatusfeedback => assigned
2012-03-29 13:12unknownnaNote Edited: 0003001bug_revision_view_page.php?bugnote_id=3001#r1538
2012-03-29 14:29Edward-sanNote Added: 0003002
2012-03-29 14:33TIHanNote Added: 0003003
2012-03-30 01:47TIHanNote Added: 0003030
2012-03-30 01:47TIHanStatusassigned => feedback
2012-03-30 01:58unknownnaNote Added: 0003031
2012-03-30 01:58unknownnaStatusfeedback => assigned
2012-03-30 01:58unknownnaNote Edited: 0003031bug_revision_view_page.php?bugnote_id=3031#r1584
2012-03-30 02:19TIHanNote Added: 0003034
2012-03-30 02:27unknownnaNote Added: 0003037
2012-04-03 04:08TIHanStatusassigned => acknowledged
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug

Notes
(0002967)
Edward-san   
2012-03-28 20:01   
(edited on: 2012-03-29 09:05)
I didn't read the code, but probably:

1)declare a new integer value called healthdamage = to the actual health of the client receiving damage;
2) call the damage;
3)healthdamage -= actual health of the client;
4) if (healthdamage >= 20) ouchface;

(0002975)
unknownna   
2012-03-29 00:20   
I created a small example WAD. Just load up the map and push the switch.
(0002982)
TIHan   
2012-03-29 02:55   
I just tested the example WAD, the ouch face is already working. I also tested taking damage from myself and monsters, the ouch face is working.
(0002986)
unknownna   
2012-03-29 08:36   
> I just tested the example WAD, the ouch face is already working.

Did you test it offline only?
(0003000)
TIHan   
2012-03-29 13:08   
> Did you test it offline only?

I tested this online...
(0003001)
unknownna   
2012-03-29 13:12   
I see. Strange. The ouch face is never displayed for me online. Can anyone confirm that the ouch face is displayed online?

(0003002)
Edward-san   
2012-03-29 14:29   
Behaves the same as unknownna.
TIHan: did you host a server and connected a client? Because with multiplayer emulation on I could see the ouch face.
(0003003)
TIHan   
2012-03-29 14:33   
I guess I'm doing something wrong. Using the very latest dev build, I host a server, then I connect and press the switch - I see the ouch face.
(0003030)
TIHan   
2012-03-30 01:47   
It seems to work...'http://i.imgur.com/lNCyL.png [^]'
(0003031)
unknownna   
2012-03-30 01:58   
Weird. With "cl_capfps" set to 0 it works for me.

(0003034)
TIHan   
2012-03-30 02:19   
> With "cl_capfps" set to 0 it works for me.

This is a timing issue of FMugShot::Tick. With cl_capfps 1, FaceHealth and the actual player's health will always be the same before the ouch face check. With cl_capfps 0, FaceHealth will always be greater than the actual player's health before the ouch face check.

I'll look into this further when I have some time to dig on this minor bug.
(0003037)
unknownna   
2012-03-30 02:27   
Nice find. I'd be nice to have this fixed for the sake of consistency.