MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000734Zandronum[All Projects] Bugpublic2012-03-28 11:042018-09-30 21:24
Reporterunknownna 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target VersionFixed in Version1.1 
Summary0000734: Incorrect ammo values in demos.
DescriptionI pick up a RL in the demo. The ammo counter displays "2/ 50", but when watching the demo it displays "4/ 50".
Steps To Reproduce
Additional InformationDemo recorded with 3417.
TagsNo tags attached.
Relationships
Attached Files? 2012.03.28_12.56.55_doom2.cld (28,165) 2012-03-28 11:04
/tracker/file_download.php?file_id=478&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-03-28 11:04unknownnaNew Issue
2012-03-28 11:04unknownnaFile Added: 2012.03.28_12.56.55_doom2.cld
2012-03-28 11:04unknownnaStatusnew => confirmed
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2012-09-01 17:24DuskAssigned To => Dusk
2012-09-01 17:24DuskStatusconfirmed => assigned
2012-09-01 17:24DuskNote Added: 0004556
2012-09-01 17:39DuskNote Added: 0004557
2012-09-01 17:39DuskStatusassigned => needs review
2012-09-02 15:15Torr SamahoNote Added: 0004572
2012-09-02 15:16Torr SamahoStatusneeds review => feedback
2012-09-02 15:18DuskStatusfeedback => assigned
2012-09-16 07:43Torr SamahoNote Added: 0004683
2012-09-16 07:44Torr SamahoStatusassigned => needs testing
2012-09-23 17:19WatermelonNote Added: 0004757
2012-09-23 18:30Torr SamahoNote Added: 0004764
2012-09-23 20:46unknownnaNote Added: 0004783
2012-09-23 21:54DuskStatusneeds testing => resolved
2012-09-23 21:54DuskFixed in Version => 1.1
2012-09-23 21:54DuskResolutionopen => fixed
2018-09-30 21:24Blzut3Statusresolved => closed

Notes
(0004556)
Dusk   
2012-09-01 17:24   
Confirmed in 1.0
(0004557)
Dusk   
2012-09-01 17:39   
Heh, too easy P:
The a_weapons.cpp code lacked demo checks almost altogether. I guess this might fix some other weapon/demo bugs as well.
Fixed: Clients appeared to get double ammo from weapons while playing demos.
.. unless I'm missing something here and the demo checks were left out for a reason?
(0004572)
Torr Samaho   
2012-09-02 15:15   
Many of the demo checks were left out for a reason: All the blocks containing CLIENTCOMMANDS_WeaponSelect should never be called when playing back a demo.

I think your change in AWeapon::PickupForAmmo and the first change in AWeapon::AttachToOwner are correct though.
(0004683)
Torr Samaho   
2012-09-16 07:43   
Since it's been a while and the necessary adjustments are straight forward, I went ahead and revised the patch myself.
(0004757)
Watermelon   
2012-09-23 17:19   
Should I get the latest build from bitbucket to test this?
(0004764)
Torr Samaho   
2012-09-23 18:30   
You can use this binary to test this.
(0004783)
unknownna   
2012-09-23 20:46   
This works properly now.