MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000733Zandronum[All Projects] Bugpublic2012-03-28 11:032018-09-30 23:10
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target Version2.0Fixed in Version2.0 
Summary0000733: software 3d floors implementation broke lava surface texture
DescriptionWhen I was testing the latest beta build in the Grandvoid jumpmaze server I found out a bug with the lava texture in map 37, which happens also offline.

Just load the demo with this command:

./skulltag -iwad doom2.wad -file jumpmaze2_v6a.pk3 -warp 37 -playdemo texturebug.lmp

Before the lava texture appeared correctly in all the areas. Apparently now it's attached to the deep surface.
The curious thing happens in the last area: some parts of the lava are rendered correctly, but the others not.

I was able to reproduce that in the changeset d6d769c4f5ed + the missing r_3dfloors.cpp/h, but not in the previous one.

Is it a map error?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000487closed  Stronghold "DecorationShip" displayed through ceilings/walls in the software renderer 
Attached Filespng Screenshot_Doom_20120328_121103.png (88,450) 2012-03-28 11:03
/tracker/file_download.php?file_id=477&type=bug
png

png Screenshot_Doom_20120328_121639.png (74,984) 2012-03-28 11:04
/tracker/file_download.php?file_id=479&type=bug
png

? texturebug.lmp (12,280) 2012-03-28 11:05
/tracker/file_download.php?file_id=480&type=bug
? jumpmaze_bug_test_01.wad (172,054) 2012-03-29 23:26
/tracker/file_download.php?file_id=502&type=bug
? lava_example.wad (9,276) 2014-12-31 21:38
/tracker/file_download.php?file_id=1355&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-03-28 11:03Edward-sanNew Issue
2012-03-28 11:03Edward-sanFile Added: Screenshot_Doom_20120328_121103.png
2012-03-28 11:04Edward-sanFile Added: Screenshot_Doom_20120328_121639.png
2012-03-28 11:05Edward-sanFile Added: texturebug.lmp
2012-03-28 11:08Edward-sanNote Added: 0002958
2012-03-28 11:09Edward-sanNote Edited: 0002958bug_revision_view_page.php?bugnote_id=2958#r1513
2012-03-28 11:10unknownnaRelationship addedrelated to 0000487
2012-03-29 23:26unknownnaNote Added: 0003023
2012-03-29 23:26unknownnaFile Added: jumpmaze_bug_test_01.wad
2012-03-29 23:27unknownnaStatusnew => confirmed
2012-03-29 23:54Edward-sanNote Added: 0003024
2012-04-03 00:00Edward-sanNote Added: 0003117
2012-04-27 11:54Edward-sanNote Added: 0003470
2012-06-02 11:12Torr SamahoNote Added: 0003662
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2012-07-31 19:26Torr SamahoStatusconfirmed => acknowledged
2012-07-31 19:26Torr SamahoResolutionopen => backport later
2014-12-07 18:51Torr SamahoNote Added: 0011042
2014-12-07 18:51Torr SamahoAssigned To => Torr Samaho
2014-12-07 18:51Torr SamahoStatusacknowledged => needs testing
2014-12-07 18:55cobaltTarget Version => 2.0
2014-12-07 18:55cobaltDescription Updatedbug_revision_view_page.php?rev_id=6120#r6120
2014-12-07 18:55cobaltNote Added: 0011043
2014-12-07 18:56DuskNote Edited: 0011043bug_revision_view_page.php?bugnote_id=11043#r6122
2014-12-07 18:58DuskNote Edited: 0011043bug_revision_view_page.php?bugnote_id=11043#r6123
2014-12-07 18:58DuskNote Edited: 0011043bug_revision_view_page.php?bugnote_id=11043#r6124
2014-12-31 16:22Edward-sanNote Added: 0011158
2014-12-31 16:35Edward-sanNote Edited: 0011158bug_revision_view_page.php?bugnote_id=11158#r6217
2014-12-31 17:23Edward-sanNote Edited: 0011158bug_revision_view_page.php?bugnote_id=11158#r6218
2014-12-31 17:23Edward-sanNote Edited: 0011158bug_revision_view_page.php?bugnote_id=11158#r6219
2014-12-31 17:28Edward-sanNote Edited: 0011158bug_revision_view_page.php?bugnote_id=11158#r6220
2014-12-31 21:17Edward-sanNote Edited: 0011158bug_revision_view_page.php?bugnote_id=11158#r6221
2014-12-31 21:38Edward-sanFile Added: lava_example.wad
2014-12-31 21:39Edward-sanNote Edited: 0011158bug_revision_view_page.php?bugnote_id=11158#r6222
2015-01-01 18:13ArcoNote Added: 0011172
2015-01-01 18:13ArcoStatusneeds testing => resolved
2015-01-01 18:13ArcoFixed in Version => 2.0
2015-01-01 18:13ArcoResolutionbackport later => fixed
2015-01-01 18:26Edward-sanNote Added: 0011180
2015-01-01 18:27Edward-sanNote Edited: 0011180bug_revision_view_page.php?bugnote_id=11180#r6230
2015-01-01 18:27Edward-sanNote Edited: 0011180bug_revision_view_page.php?bugnote_id=11180#r6231
2018-09-30 23:10Blzut3Statusresolved => closed

Notes
(0002958)
Edward-san   
2012-03-28 11:08   
(edited on: 2012-03-28 11:09)
Also, it's appreciated if someone can make an example wad from this, because I'd like to test it with zdoom latest svn.
(0003023)
unknownna   
2012-03-29 23:26   
It took me a while to create the example WAD, but nevertheless, here it is (MAP01). It's a ZDoom issue since it's broken in the latest SVN build (3491) as well.
(0003024)
Edward-san   
2012-03-29 23:54   
Done.
(0003117)
Edward-san   
2012-04-03 00:00   
Sorry to ask you again, unknownna, but can you make also an example wad based on the first example wad with a new area based on the information I added here:'http://forum.zdoom.org/viewtopic.php?f=2&t=32385#p614227 [^]' ?
Also, can you add in the same wad the area shown in the second screenshot here? That's because imho this weird behaviour is more interesting than the one shown in the previous screenshot.
(0003470)
Edward-san   
2012-04-27 11:54   
Fixed:'http://zdoom.org/Changelog/3600/files [^]' but I'm not sure how it can be backported to skulltag.
(0003662)
Torr Samaho   
2012-06-02 11:12   
This backport requires numerous other backports that go back to at least ZDoom revision 1600. I will have a look whether it's feasible to do these backports or not later, but first we need to get the first Zandronum beta build out.
(0011042)
Torr Samaho   
2014-12-07 18:51   
It was feasible to backport the fix now, so I did.
(0011043)
cobalt   
2014-12-07 18:55   
(edited on: 2014-12-07 18:58)
Issue addressed by commit 5b5b95b: out of sequence fix backport from ZDoom revision 3600: - Fixed: sector_t::GetHeightSec() was too aggressive about not returning heightsec.
Committed by Benjamin Berkels [Torr Samaho] on Sunday 07 December 2014 19:45:10

Changes in files:
 src/p_sectors.cpp | 26 ++++++++++++++++++++++++++
 src/r_defs.h | 10 ++--------
 2 files changed, 28 insertions(+), 8 deletions(-)
(0011158)
Edward-san   
2014-12-31 16:22   
(edited on: 2014-12-31 21:39)
Actually, the fix is partially complete, because if you load the example wad with latest zandronum 2.0 beta, you'll see the surface darkened. I'll check if it happens in that zdoom commit containing the fix.

[edit]weird, it doesn't happen with that zdoom commit...

[edit2]okay, I tested the revision before the backport, and I'm sure that during the long backport period, something broke the transfer brightness... should I make a new bug report?

[edit3]after hours of compiling and fixing compiling errors, I found that the issue started from d8339813af1c . I used lava_example.wad , attached here, to determine this.
(0011172)
Arco   
2015-01-01 18:13   
Issue fixed in r150101-1703.
(0011180)
Edward-san   
2015-01-01 18:26   
(edited on: 2015-01-01 18:27)
Well, reported the problem in comment'http://zandronum.com/tracker/view.php?id=733#c11158 [^]' over ticket 0002041 .