MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000699Zandronum[All Projects] Suggestionpublic2012-03-01 20:012018-09-30 23:20
ReporterStrikerMan780 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version2.0Fixed in Version2.0 
Summary0000699: Backport Game Music Emu Library from ZDoom
DescriptionWould it be at all possible to backport support for more emulated music formats from ZDoom? (SPC, NSF, VGM, etc)

'http://zdoom.org/wiki/Music_format [^]'
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
child of 0001490closed Torr Samaho Backport ZDoom 2.5.0 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-01 20:01StrikerMan780New Issue
2012-03-01 21:18TIHanNote Added: 0002727
2012-03-01 21:36StrikerMan780Note Added: 0002728
2012-03-01 21:36StrikerMan780Note Edited: 0002728bug_revision_view_page.php?bugnote_id=2728#r1392
2012-03-01 21:37StrikerMan780Note Edited: 0002728bug_revision_view_page.php?bugnote_id=2728#r1393
2012-03-11 01:45Torr SamahoNote Added: 0002777
2012-03-11 04:00StrikerMan780Note Added: 0002784
2012-03-11 04:02StrikerMan780Note Edited: 0002784bug_revision_view_page.php?bugnote_id=2784#r1441
2012-03-11 04:55StrikerMan780Note Edited: 0002784bug_revision_view_page.php?bugnote_id=2784#r1442
2012-07-09 20:04StrikerMan780Note Edited: 0002784bug_revision_view_page.php?bugnote_id=2784#r2147
2012-10-17 17:26StrikerMan780Note Added: 0005134
2013-01-31 02:04StrikerMan780Note Added: 0005882
2013-01-31 02:04StrikerMan780Note Edited: 0005882bug_revision_view_page.php?bugnote_id=5882#r3213
2013-01-31 02:05StrikerMan780Note Edited: 0005882bug_revision_view_page.php?bugnote_id=5882#r3214
2013-01-31 21:35StrikerMan780Note Added: 0005896
2013-01-31 21:36StrikerMan780Note Edited: 0005896bug_revision_view_page.php?bugnote_id=5896#r3218
2013-01-31 21:38StrikerMan780Note Edited: 0005896bug_revision_view_page.php?bugnote_id=5896#r3219
2013-02-02 08:29Torr SamahoNote Added: 0005910
2013-02-02 08:46StrikerMan780Note Added: 0005912
2013-09-08 11:28Torr SamahoRelationship addedchild of 0001490
2013-09-08 11:29DuskTarget Version => 2.0
2013-10-06 19:07ArcoNote Added: 0007335
2013-10-06 20:07StrikerMan780Note Added: 0007337
2013-10-08 20:03ArcoStatusnew => resolved
2013-10-08 20:03ArcoFixed in Version => 2.0-beta
2013-10-08 20:03ArcoResolutionopen => fixed
2013-10-08 20:03ArcoAssigned To => Arco
2013-10-08 20:18Blzut3Assigned ToArco =>
2013-10-08 20:18Blzut3Fixed in Version2.0-beta => 2.0
2013-10-22 17:01DuskStatusresolved => assigned
2013-10-22 17:01DuskAssigned To => Torr Samaho
2013-10-22 17:02DuskStatusassigned => resolved
2018-09-30 23:20Blzut3Statusresolved => closed

Notes
(0002727)
TIHan   
2012-03-01 21:18   
IMO, we should just wait till Torr starts updating the ZDoom base after 98e is released, unless there is something critical that needs backporting.
(0002728)
StrikerMan780   
2012-03-01 21:36   
(edited on: 2012-03-01 21:37)
Now, how long will we need to wait before 98e is released, and more importantly, how long will it take for another version after that to come? I don't want to be stuck relying on beta builds for the rest of my life. (As I have been for a very long time now... :\)

I just wish to have this rather simplistic feature backported for the fact I'm working on an gameplay & aesthetic expansion to run on top of UDM3, in which one of its features is replacing the music with their original counterparts. (Ie, The midi of Sonic 2's Aquatic Zone, is replaced with the actual version from the Genesis(VGM File). This would avoid needing to use MP3s, which would end up bloating the file size to gargantuan levels.)
(0002777)
Torr Samaho   
2012-03-11 01:45   
> Now, how long will we need to wait before 98e is released, and more importantly, how long will it take for another version after that to come?

Well, 98e is long overdue...

> I just wish to have this rather simplistic feature backported

You call it rather simplistic but did you actually check whether it is trivial to backport it to Skulltag's older ZDoom code base?
(0002784)
StrikerMan780   
2012-03-11 04:00   
(edited on: 2012-07-09 20:04)
Has ZDoom gone through any major sound system changes since ST's ZDoom revision? The library being used, is actually based on the snes_spc library being used in Skulltag now as it is. In fact, it's an expansion on it, and is made by the same author. (Blargg)

So shouldn't it, in theory, be a matter of switching from one to the other?

'http://zdoom.org/Changelog/1631/files [^]'

'http://forum.zdoom.org/viewtopic.php?f=18&t=22155&hilit=VGM+Music [^]'

'http://forum.zdoom.org/viewtopic.php?f=7&t=22367&hilit=VGM+Music [^]'
(0005134)
StrikerMan780   
2012-10-17 17:26   
I figure I'll bring this back from the dead considering I'm working on this project now -'http://zandronum.com/forum/showthread.php?tid=1330 [^]'
(0005882)
StrikerMan780   
2013-01-31 02:04   
(edited on: 2013-01-31 02:05)
I backported this myself. My Bitbucket fork can be found here:'https://bitbucket.org/jordon_moss/zandronum_striker_experimental/commits/all [^]'

I've tested it, it compiles correctly, and works correctly in-game.

Not bad for my first serious dive into C++, let alone Zandronum's Source.
(0005896)
StrikerMan780   
2013-01-31 21:35   
(edited on: 2013-01-31 21:38)
Fixed the missing files in my commit. I created a pull request on bitbucket. The VCProj and SLN files are for VC Studio 2008. Up to you to incorporate those. They work properly though.

'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/9/backported-gme-libraries-fixed-missing/diff [^]'
(0005910)
Torr Samaho   
2013-02-02 08:29   
I'm sorry, but apparently I made my general backport policy visible enough.
(0005912)
StrikerMan780   
2013-02-02 08:46   
fuck.
(0007335)
Arco   
2013-10-06 19:07   
v2.0 has confirmed that the feature is working. Thanks goes to Striker for testing this.
(0007337)
StrikerMan780   
2013-10-06 20:07   
Yeah, seems to work perfectly so far.