Notes |
|
(0007474)
|
Konar6
|
2013-10-27 11:12
|
|
|
|
(0007476)
|
Dusk
|
2013-10-27 12:16
(edited on: 2013-10-27 12:18) |
|
Your diff does not seem to update the maplist on the clients if the server changes it. Might need several SVC2_ entries here, one for each manipulation command..
Also I think
Quote
extern std::vector<MAPROTATIONENTRY_t> g_MapRotationEntries;
should be replaced with a function in maprotation.cpp which returns a const-reference of the entries, something like:
const std::vector<MAPROTATIONENTRY_t>& MAPROTATION_GetAllEntries( void )
{
return g_MapRotationEntries;
}
Then make g_MapRotationEntries static. It should probably be a std::deque too because insertmap can be used to add entries at the beginning.
|
|
|
|
tested using 3.1-alpha-r211026-1439 on local windows and tspg linux servers, using various amounts of addmap, delmap, insertmap, map specific player counts, map rotation enabled/disabled, random map rotation enabled/disabled, a client present during maplist changes, and a client connecting after maplist changes, and maplist worked just fine for both clients |
|
|
|
Thanks for checking! I'll mark this as resolved then. |
|