MantisBT - Zandronum
View Issue Details
0000649Zandronum[All Projects] Suggestionpublic2012-01-09 05:022021-10-30 18:13
Qent 
Kaminsky 
normalfeatureN/A
resolvedfixed 
MicrosoftWindowsXP/Vista/7
98d 
3.1-beta 
0000649: Let maplist be used by clients
Currently maplist executed from a client always comes up empty. Instead, it should do the same as rcon maplist.
console
has duplicate 0001524closed  Make server maplist viewable by client. 
Issue History
2012-01-09 05:02QentNew Issue
2013-10-27 11:12Konar6Note Added: 0007474
2013-10-27 12:12DuskRelationship addedhas duplicate 0001524
2013-10-27 12:16DuskNote Added: 0007476
2013-10-27 12:17DuskNote Edited: 0007476bug_revision_view_page.php?bugnote_id=7476#r4169
2013-10-27 12:18DuskNote Edited: 0007476bug_revision_view_page.php?bugnote_id=7476#r4170
2014-06-15 14:40WatermelonStatusnew => feedback
2021-10-29 07:58WaTaKiDNote Added: 0021797
2021-10-30 18:13KaminskyNote Added: 0021799
2021-10-30 18:13KaminskyStatusfeedback => resolved
2021-10-30 18:13KaminskyFixed in Version => 3.1-beta
2021-10-30 18:13KaminskyResolutionopen => fixed
2021-10-30 18:13KaminskyAssigned To => Kaminsky

Notes
(0007474)
Konar6   
2013-10-27 11:12   
'http://sickedwick.net/k6/3d05db6986f39f5ca2cd490ed9b20c8d/00000055.txt [^]'
(0007476)
Dusk   
2013-10-27 12:16   
(edited on: 2013-10-27 12:18)
Your diff does not seem to update the maplist on the clients if the server changes it. Might need several SVC2_ entries here, one for each manipulation command..

Also I think
Quote

extern std::vector<MAPROTATIONENTRY_t> g_MapRotationEntries;


should be replaced with a function in maprotation.cpp which returns a const-reference of the entries, something like:
const std::vector<MAPROTATIONENTRY_t>& MAPROTATION_GetAllEntries( void )
{
    return g_MapRotationEntries;
}


Then make g_MapRotationEntries static. It should probably be a std::deque too because insertmap can be used to add entries at the beginning.

(0021797)
WaTaKiD   
2021-10-29 07:58   
tested using 3.1-alpha-r211026-1439 on local windows and tspg linux servers, using various amounts of addmap, delmap, insertmap, map specific player counts, map rotation enabled/disabled, random map rotation enabled/disabled, a client present during maplist changes, and a client connecting after maplist changes, and maplist worked just fine for both clients
(0021799)
Kaminsky   
2021-10-30 18:13   
Thanks for checking! I'll mark this as resolved then.