MantisBT - Doomseeker
View Issue Details
0000621Doomseeker[All Projects] Suggestionpublic2011-11-11 20:222018-09-29 14:37
Zalewa 
Zalewa 
normalminorN/A
closedfixed 
 
1.11.1 
0000621: Improve the way config dialog box validates the config data
Currently, when Doomseeker detects invalid information in the config dialog box, the validation is performed after user presses OK and then a custom error information is displayed.

I propose to make following changes to validation mechanism:
[list]
[*] Validation should occur immediatelly after the data is inserted, or when user leaves the current config page, or when user presses either "OK" or "Apply" buttons.
[*] Validation should produce either errors or warnings. Errors will disallow user to save the configuration. Warnings will give an option to ignore them.
[*] Errors should be produced wherever Doomseeker can be 100% sure that the inserted data is incorrect.
[*] Warnings should be produced wherever inserted data might be incorrect. For example: a warning should be issued if user points a path in one of the game's configuration to a binary with odd name. For example user might specify that Skulltag's executable is "/bin/bash", which is most likely an error, but we can't say for sure that is not what was intended.
[*] Once an error/warning is issued, config box should immediately switch to the offending config page and visibly mark the offending variable with an icon. Hovering a mouse cursor over that icon should display a tooltip describing the error.
[/list]

Additional features:
[list]
[*] Validation could also occur when the configuration box is opened. This would help to detect potential configuration errors that were caused by external events. For example: removing a directory from filesystem will now render that directory invalid in WAD paths.
[/list]
No tags attached.
Issue History
2011-11-11 20:22ZalewaNew Issue
2011-11-11 20:23ZalewaDescription Updatedbug_revision_view_page.php?rev_id=1189#r1189
2011-11-11 20:23ZalewaDescription Updatedbug_revision_view_page.php?rev_id=1190#r1190
2016-11-12 10:47ZalewaAssigned To => Zalewa
2016-11-12 10:47ZalewaStatusnew => assigned
2017-01-01 15:40ZalewaNote Added: 0016583
2017-01-01 15:40ZalewaStatusassigned => needs review
2017-01-01 16:06ZalewaNote Edited: 0016583bug_revision_view_page.php?bugnote_id=16583#r10011
2017-01-08 14:18ZalewaNote Added: 0016625
2017-01-08 14:18ZalewaStatusneeds review => needs testing
2017-07-03 17:38ZalewaStatusneeds testing => resolved
2017-07-03 17:38ZalewaFixed in Version => 1.1
2017-07-03 17:38ZalewaResolutionopen => fixed
2018-09-29 14:24WubTheCaptainStatusresolved => closed
2018-09-29 14:37WubTheCaptainTarget Version => 1.1

Notes
(0016583)
Zalewa   
2017-01-01 15:40   
(edited on: 2017-01-01 16:06)
Done in this commits:

1.'https://bitbucket.org/Doomseeker/doomseeker/commits/6017ac76b1f74fabb95bc0c2c03344e5acb15e4b [^]'
2.'https://bitbucket.org/Doomseeker/doomseeker/commits/a003c89ee46647c8d5edbd374a770fa6ef250eef [^]'

(0016625)
Zalewa   
2017-01-08 14:18   
Update available on beta auto-update channel.