MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000619Doomseeker[All Projects] Bugpublic2011-11-11 09:462018-09-29 14:48
ReporterZalewa 
Assigned ToBlzut3 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.7 Beta 
Target Version0.8 BetaFixed in Version0.8 Beta 
Summary0000619: Problem with properly detecting working directory for server executable.
DescriptionPC:
'http://www.skulltag.com/forum/viewtopic.php?f=172&t=30035 [^]'

The same kind of problem also exists on Mac:
'http://www.skulltag.com/forum/viewtopic.php?f=172&t=29542 [^]'
Steps To ReproduceThe problem may be more complex but one known way to reproduce is to:
- Do not define path to the server executable in the configuration window.
- Attempt to start a server by manually selecting the server executable in Create Server dialog.
Additional InformationSolution(s):
- Working directory for servers will now always be extracted from the executable's path. Please note that working directory for client binaries will still be extracted from configuration. Skulltag Testing Binaries make use of that.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-11 09:46ZalewaNew Issue
2011-11-11 09:46ZalewaStatusnew => assigned
2011-11-11 09:46ZalewaAssigned To => Zalewa
2011-11-11 18:09Blzut3Note Added: 0002296
2011-11-11 18:18ZalewaNote Added: 0002297
2011-11-11 19:45ZalewaAdditional Information Updatedbug_revision_view_page.php?rev_id=1187#r1187
2011-11-11 20:42ZalewaNote Added: 0002298
2011-11-11 22:02ZalewaAssigned ToZalewa => Blzut3
2011-11-11 22:04ZalewaNote Added: 0002299
2011-11-12 02:37Blzut3Note Added: 0002300
2011-12-31 19:12Blzut3Note Added: 0002334
2011-12-31 19:12Blzut3Statusassigned => resolved
2011-12-31 19:12Blzut3Fixed in Version => 0.8 Beta
2011-12-31 19:12Blzut3Resolutionopen => fixed
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2018-09-29 14:48WubTheCaptainStatusresolved => closed

Notes
(0002296)
Blzut3   
2011-11-11 18:09   
Isn't the working directory already using the executable's path (Binaries::serverWorkingDirectory)? My only guess on the issue is that canonicalPath() is returning an empty string in some cases (the docs say this would be when the file doesn't exist). Perhaps we should be using absolutePath() instead? Hard to tell since we don't know exactly how those having the issue have Doomseeker configured.
(0002297)
Zalewa   
2011-11-11 18:18   
About "Binaries::serverWorkingDirectory()" - I don't think that this was a very good solution to begin with. When you consider "what does one expect" when selecting the server executable from the Create Server dialog, you come to conclusion that the game should use files from the directory you just chose, not from the one that is configured somewhere elsewhere. As an alternative we could allow users to specify working directory on their own but IMO that is not a good idea because most of them will wonder what this does and only more problems will ensue.

Now I believe that Binaries::serverWorkingDirectory() should be removed altogether. VGA's problem (on the PC) is related to that.

On the "canonicalPath()":
Yes, I remember reading that this actually resolves the path on the filesystem. This may cause some problems. I agree we need more feedback on this, first.
(0002298)
Zalewa   
2011-11-11 20:42   
Oh! I realize now what VGA did! He added Skulltag path to the list where you specify WAD paths...
(0002299)
Zalewa   
2011-11-11 22:04   
I think I did all I could on the PC side. Please investigate what's going on on Mac.
(0002300)
Blzut3   
2011-11-12 02:37   
Fixed some compilation issues and then uploaded a new build to the svn site. Everything still works for me so we have to wait for EatmeChowdown to provide feedback or assume it's fixed.
(0002334)
Blzut3   
2011-12-31 19:12   
I'm going to go ahead and assume it's fixed since EarmeChowdown's post seems to indicate it's working.