MantisBT - Zandronum
View Issue Details
0000495Zandronum[All Projects] Suggestionpublic2011-06-14 19:392018-09-30 22:10
DuckReconMajor 
Dusk 
normalminorN/A
closedfixed 
 
3.03.0 
0000495: 'Use' key to join game instead of 'Space'
Instead of having the join menu hardcoded to the space bar, could it be set to whatever is bound as "use"? This would allow players to use the space bar for movement when spectating.
No tags attached.
Issue History
2011-06-14 19:39DuckReconMajorNew Issue
2011-09-19 15:18DevonNote Added: 0002176
2011-09-19 20:10DuckReconMajorNote Added: 0002180
2011-09-20 15:21DevonNote Added: 0002186
2011-09-20 20:09HypnotoadNote Added: 0002191
2011-09-20 20:10HypnotoadNote Edited: 0002191bug_revision_view_page.php?bugnote_id=2191#r1140
2011-09-21 13:19Edward-sanNote Added: 0002201
2011-10-01 12:53QentNote Added: 0002216
2011-10-09 00:32cq75Note Added: 0002228
2011-10-09 00:50DuckReconMajorNote Added: 0002231
2014-06-11 16:16WatermelonNote Added: 0009066
2014-06-11 16:16WatermelonStatusnew => feedback
2014-06-14 13:20DuckReconMajorNote Added: 0009282
2014-06-14 13:20DuckReconMajorStatusfeedback => new
2015-05-24 23:28Edward-sanNote Added: 0012374
2015-05-24 23:28Edward-sanAssigned To => Edward-san
2015-05-24 23:28Edward-sanStatusnew => needs review
2015-05-24 23:28Edward-sanTarget Version => 3.0
2015-05-24 23:38Edward-sanNote Edited: 0012374bug_revision_view_page.php?bugnote_id=12374#r7145
2015-11-17 03:42Ru5tK1ngNote Added: 0013834
2015-11-17 03:42Ru5tK1ngStatusneeds review => feedback
2015-11-17 10:23Edward-sanNote Added: 0013836
2015-11-17 15:53Edward-sanNote Added: 0013838
2015-11-17 15:53Edward-sanStatusfeedback => needs review
2016-02-23 20:36DuskAssigned ToEdward-san => Dusk
2016-02-23 20:36DuskStatusneeds review => assigned
2016-02-23 21:05DuskNote Added: 0014481
2016-02-23 21:05DuskStatusassigned => needs review
2016-02-27 18:00cobaltStatusneeds review => needs testing
2016-02-27 18:00cobaltNote Added: 0014507
2016-03-01 21:40Ru5tK1ngNote Added: 0014526
2016-03-01 21:41Ru5tK1ngStatusneeds testing => resolved
2016-03-01 21:41Ru5tK1ngResolutionopen => fixed
2016-03-01 21:41Ru5tK1ngFixed in Version => 3.0
2018-09-30 22:10Blzut3Statusresolved => closed

Notes
(0002176)
Devon   
2011-09-19 15:18   
What's the point? Seems like a waste of time for the developers imo :S
(0002180)
DuckReconMajor   
2011-09-19 20:10   
When spectating, usually the player will use "jump" key to raise altitude and get a better view of what's going on. If the player's jump key is Space, this is not possible.
(0002186)
Devon   
2011-09-20 15:21   
Your jump key is space?! Urrr okay.. I see your point
(0002191)
Hypnotoad   
2011-09-20 20:09   
(edited on: 2011-09-20 20:10)
I use space for jump too, a lot of other ports use the use key for joining instead of space, it would be nice to use the jump key to navigate while spectating. Pretty minor but I still support it.

(0002201)
Edward-san   
2011-09-21 13:19   
Shouldn't be bad if it's customizable.
(0002216)
Qent   
2011-10-01 12:53   
Oh wait.... I have strafe and use doublebound to mouse2, so use would be just as bad.
(0002228)
cq75   
2011-10-09 00:32   
You could solve this problem by making a new bind for joining the game instead of using space or use.
(0002231)
DuckReconMajor   
2011-10-09 00:50   
Yeah I think that's probably better. Should/can I edit the issue?
(0009066)
Watermelon   
2014-06-11 16:16   
Does this happen in 2.0?
(0009282)
DuckReconMajor   
2014-06-14 13:20   
Yes it does
(0012374)
Edward-san   
2015-05-24 23:28   
(edited on: 2015-05-24 23:38)
I made the 'join' key customizable with these changesets.

(0013834)
Ru5tK1ng   
2015-11-17 03:42   
Is it safe to assume the changesets weren't merged? I don't see a 'join' key in the "customize controls" options and that bitbucket link is dead.
(0013836)
Edward-san   
2015-11-17 10:23   
Indeed, it was lost when the old sandbox repository was deleted. I recovered it from my local repository and reuploaded here.
(0013838)
Edward-san   
2015-11-17 15:53   
Made a new pull request here, contains also a change to the spectator string to mention the new key for joining.
(0014481)
Dusk   
2016-02-23 21:05   
I kind of hijacked the pull request and updated it.
(0014507)
cobalt   
2016-02-27 18:00   
Issue addressed by commit a2d1bd36a43d: The 'Join the game' command key used by spectators is now customizable in the 'Customize Controls' menu (addresses 495).
Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/g_game.cpp | 30 ++++++++++++++++++++++++++++--
 src/g_game.h | 4 ++++
 src/menu/menu.h | 2 --
 src/menu/multiplayermenu.cpp | 14 +++++++++++++-
 src/scoreboard.cpp | 16 +++++++++++++++-
 wadsrc/static/menudef.txt | 8 ++++++++
 7 files changed, 69 insertions(+), 6 deletions(-)

(0014526)
Ru5tK1ng   
2016-03-01 21:40   
Tested this out with the latest build and joining can be set with a custom key in the menu.