MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0004513 | Zandronum | [All Projects] Bug | public | 2025-04-20 17:38 | 2025-04-25 16:40 |
|
| Reporter | unknownna | |
| Assigned To | Kaminsky | |
| Priority | normal | Severity | text | Reproducibility | always |
| Status | resolved | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 3.2 | |
| Target Version | | Fixed in Version | 3.2 | |
|
| Summary | 0004513: [3.2] Final score message in CTF only displays subtext |
| Description | While testing the fix for 0004508, I noticed that the final capture message in CTF no longer displays the main message, it only displays the subtext. See the attached screenshot.
From looking at my pipeline build folder, this issue started to pop up very recently from the rephrasing of the multi-team tie on the scoreboard and large frag messages. |
| Steps To Reproduce | 1. zandronum -host -file countdown_deathcount_02.wad +ctf 1 +pointlimit 1 +sv_maprotation 1 +addmap map01
2. Connect 2 clients to the server and join both teams.
3. Capture a flag and score. Only the subtext is displayed. |
| Additional Information | Link to example wad:'https://zandronum.com/tracker/file_download.php?file_id=3225&type=bug [^]' |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  Screenshot_Doom_20250420_190547.png (69,285) 2025-04-20 17:38
https://zandronum.com/tracker/file_download.php?file_id=3246&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2025-04-20 17:38 | unknownna | New Issue | |
| 2025-04-20 17:38 | unknownna | File Added: Screenshot_Doom_20250420_190547.png | |
| 2025-04-20 17:39 | unknownna | Additional Information Updated | bug_revision_view_page.php?rev_id=14556#r14556 |
| 2025-04-22 17:08 | Kaminsky | Note Added: 0024491 | |
| 2025-04-22 17:57 | unknownna | Note Added: 0024492 | |
| 2025-04-22 17:57 | unknownna | Status | new => feedback |
| 2025-04-22 18:42 | Kaminsky | Note View State: 0024492: private | |
| 2025-04-22 18:43 | Kaminsky | Note View State: 0024492: public | |
| 2025-04-22 18:45 | Kaminsky | Note Added: 0024493 | |
| 2025-04-22 18:55 | unknownna | Note Added: 0024494 | |
| 2025-04-22 18:55 | unknownna | Status | feedback => new |
| 2025-04-23 21:57 | Kaminsky | Note Added: 0024497 | |
| 2025-04-23 21:57 | Kaminsky | Assigned To | => Kaminsky |
| 2025-04-23 21:57 | Kaminsky | Status | new => assigned |
| 2025-04-23 21:57 | Kaminsky | Product Version | => 3.2 |
| 2025-04-23 23:53 | unknownna | Note Added: 0024498 | |
| 2025-04-24 16:27 | unknownna | Note Edited: 0024498 | bug_revision_view_page.php?bugnote_id=24498#r14560 |
| 2025-04-25 13:59 | Kaminsky | Note Added: 0024501 | |
| 2025-04-25 13:59 | Kaminsky | Status | assigned => needs review |
| 2025-04-25 16:39 | unknownna | Note Added: 0024508 | |
| 2025-04-25 16:39 | unknownna | Status | needs review => resolved |
| 2025-04-25 16:39 | unknownna | Fixed in Version | => 3.2 |
| 2025-04-25 16:39 | unknownna | Resolution | open => fixed |
|
Notes |
|
|
|
This is actually a regression of:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/cca65a684e8718e309afb185e4d28997e57065e9 [^]'
Instead of restoring the original behaviour of showing the "x team scores" message at the top of the screen, I can keep the c
"x wins" message that now appears in the middle of the screen and draw the subtext in the same way as when a team scores in team possession (e.g. "final score by: x and y").
This way, the appearance of the win message in CTF, 1-Flag CTF, and Skulltag is consistent with that of other game modes, as well as when the time expires. It'll also be easier to read and know when the game's finished, and I won't need to write such hacky code to restore the old behaviour. What do you think? |
|
|
|
|
I see, and thanks for the clarification.
To be honest, I'm personally not too fond of the aesthetics of the huge and over-scaled score messages in the other team modes and was actually eventually going to make suggestion tickets to make the score messages (at least in a potentially re-worked possession mode) slightly smaller to match the CTF messages better.
Does it look good to change it up? Maybe it would, the only way to figure it out is to try. I think I personally wouldn't like it.
However, is it not possible to keep both the old score message with its subtext, and also include the new center win message? At least I think that would look better and feel familiar without changing it up too much. |
|
|
|
|
Quote from unknownna
To be honest, I'm personally not too fond of the aesthetics of the huge and over-scaled score messages in the other team modes and was actually eventually going to make suggestion tickets to make the score messages (at least in a potentially re-worked possession mode) slightly smaller to match the CTF messages better.
I see. I'll just restore the old score message for 3.2 and see what else can be done after its release. The game mode system also needs a huge refactor someday.
Quote from unknownna
However, is it not possible to keep both the old score message with its subtext, and also include the new center win message?
It's possible to restore the old score message, it's more so that I'll probably need to add overspecialized code to handle it. It won't be possible to display both the score and win messages at the same time, though, because they both use the same HudMessage index; one will replace the other. |
|
|
|
|
|
I see, fair enough. Sad that it's not possible to do both messages currently. Will it ever be able to handle both someday, maybe with the refactoring? I agree that a center win message looks good and consistent with the other modes though. |
|
|
|
|
|
|
|
(0024498)
|
|
unknownna
|
2025-04-23 23:53
(edited on: 2025-04-24 16:27) |
|
It seems to have restored the old score message for the final score, in addition to keeping the newer message order from 0004498.
The big central message only appears when the timelimit runs out and a team is forced to win.
However, if somebody scores during sudden death, the old score message is still missing and only the subtext appears. This also happens in 3.1 though.
In any case, the fix seems to work.
It's probably better to let the issue above remain as-is if it's not fixable due to the shared HudMessage index since it's been that way forever. It can be changed eventually when the mode gets a proper clean-up sometime in the future.
|
|
|
|
|
I went ahead and opened the merge request for this, based on your feedback:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/320 [^]'
Thanks for checking!
Quote from unknownna
It's probably better to let the issue above remain as-is if it's not fixable due to the shared HudMessage index since it's been that way forever. It can be changed eventually when the mode gets a proper clean-up sometime in the future.
I agree. It's going to be risky to try fixing this now, and since it's not actually a regression, it's not urgent to do anything about it. I'd rather wait until 3.2 is released and then refactor the game mode system before trying to fix it. |
|
|
|
|
Agreed, so this can probably be marked as resolved since it was already tested. Good work!
I'll make a note of the sudden death / draw game HudMessage index issue with the score messages, and bring it up again in the future when the mode potentially gets refactored. |
|