MantisBT - Zandronum
View Issue Details
0004401Zandronum[All Projects] Suggestionpublic2024-08-27 18:542024-09-17 20:56
unknownna 
Kaminsky 
normaltweakN/A
resolvedfixed 
 
3.23.2 
0004401: Minor change to small text under large frag messages in (Team)LMS
Since "opponents" was changed to "enemies", then maybe the small print under the large frag messages should say "enemies" too.

st_hud.cpp, line 1214-1216:
// [AK] If there are any opponents left, display that instead of the place string.
        if ( ulMenLeftStanding > 0 )
            message.Format( "%d opponent%s left standing", static_cast<unsigned int>( ulMenLeftStanding ), ulMenLeftStanding != 1 ? "s" : "" );
Maybe the "fragged by" message in TeamLMS should also display enemies or allies left. It's perhaps more necessary to see enemies or allies left when you die instead of the team score, especially if sv_maxlives is higher. But I'm not sure, up to you.
No tags attached.
png Screenshot_Doom_20240827_203705.png (56,165) 2024-08-27 18:54
https://zandronum.com/tracker/file_download.php?file_id=3104&type=bug
png

png Screenshot_Doom_20240827_203854.png (39,453) 2024-08-27 18:55
https://zandronum.com/tracker/file_download.php?file_id=3105&type=bug
png
Issue History
2024-08-27 18:54unknownnaNew Issue
2024-08-27 18:54unknownnaFile Added: Screenshot_Doom_20240827_203705.png
2024-08-27 18:55unknownnaFile Added: Screenshot_Doom_20240827_203854.png
2024-09-02 20:17KaminskyNote Added: 0023994
2024-09-02 20:17KaminskyAssigned To => Kaminsky
2024-09-02 20:17KaminskyStatusnew => needs review
2024-09-02 20:17KaminskyTarget Version => 3.2
2024-09-05 12:34unknownnaNote Added: 0024001
2024-09-05 12:34unknownnaStatusneeds review => feedback
2024-09-05 15:27KaminskyNote Added: 0024007
2024-09-05 16:04KaminskyNote Edited: 0024007bug_revision_view_page.php?bugnote_id=24007#r14372
2024-09-05 16:04KaminskyStatusfeedback => needs review
2024-09-05 19:20unknownnaNote Added: 0024013
2024-09-17 15:09KaminskyNote Added: 0024036
2024-09-17 15:09KaminskyStatusneeds review => needs testing
2024-09-17 20:56unknownnaNote Added: 0024041
2024-09-17 20:56unknownnaStatusneeds testing => resolved
2024-09-17 20:56unknownnaFixed in Version => 3.2
2024-09-17 20:56unknownnaResolutionopen => fixed

Notes
(0023994)
Kaminsky   
2024-09-02 20:17   
I changed the wording of the subtext to "enemies" here:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/183 [^]' and to make the word stand out better, I added colouring and used dark red. It doesn't seem too important to change how or when the "enemies left" message appears, or whether it should also show how many allies are left. I think it's okay if it only appears when you frag an enemy in (T)LMS.
(0024001)
unknownna   
2024-09-05 12:34   
Although the text change is good, I have to say the colored "enemy" subtext feels a bit distracting after playing with it. If would probably be best to leave it a regular gray. At least that's the impression I got after testing it.

And are we absolutely certain we don't want to print "allies left standing" in the subtext when fragged during a teamLMS game?
(0024007)
Kaminsky   
2024-09-05 15:27   
(edited on: 2024-09-05 16:04)
Quote from "unknownna"
I have to say the colored "enemy" subtext feels a bit distracting after playing with it. If would probably be best to leave it a regular gray. At least that's the impression I got after testing it.


I figured that colourizing the text would've made it easier to read the subtext without it being too distracting, but if you believe that it is, then I can remove it.

EDIT: I removed the colour and updated the merge request.

Quote from "unknownna"
And are we absolutely certain we don't want to print "allies left standing" in the subtext when fragged during a teamLMS game?


Large frag messages have existed in Skulltag and Zandronum for a long time, but I never noticed anyone complain about them not printing how many allies are left in (T)LMS. I would also like to get 3.2 wrapped up very soon, so I rather not spend more time trying to address what seems like a very trivial issue to me. Changing the wording from "opponents" to "enemies" so that it's consistent with the rest of the HUD was a reasonable suggestion.

(0024013)
unknownna   
2024-09-05 19:20   
I tested the newer merge request, and I think it's probably a bit better with it being gray even if it looks more boring, because it sticks out less when there's a lot of action going on in front of you and you're trying to frag others while avoiding being fragged. I hope you think it's ok also.

Quote from Kaminsky
I would also like to get 3.2 wrapped up very soon, so I rather not spend more time trying to address what seems like a very trivial issue to me. Changing the wording from "opponents" to "enemies" so that it's consistent with the rest of the HUD was a reasonable suggestion.


Fair enough, no problem. It's important that we agree on what works best.
(0024036)
Kaminsky   
2024-09-17 15:09   
Since'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/5003cbe3559bdc21e175cb86d414a10f2702e970 [^]' has been pushed into the repository and everything seems to be working as intended, I assume that this ticket can be marked as resolved now, right?
(0024041)
unknownna   
2024-09-17 20:56   
Yes, of course. Thanks.