MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0004382 | Zandronum | [All Projects] Bug | public | 2024-08-11 19:02 | 2025-01-16 17:46 |
|
| Reporter | unknownna | |
| Assigned To | Kaminsky | |
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | resolved | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 3.1 | |
| Target Version | 3.2 | Fixed in Version | 3.2 | |
|
| Summary | 0004382: Chat_Sound sound preference doesn't work in Doom 1, and some other minor issues |
| Description | * Setting Chat_Sound to "Doom 2" in Ultimate Doom doesn't play any sounds since the sound doesn't exist in the iwad.
* It doesn't use the proper "Doom 1" sound if set to "default" when freedoom1.wad is loaded.
Maybe add a check where this feature is disabled and the menu option is blanked out if Ultimate Doom and shareware Doom is loaded, in addition to the other non-Doom iwads.
Maybe let the FreeDoom stuff work the same as Doom. |
| Steps To Reproduce | |
| Additional Information | * Chat sounds don't play at all in shareware Doom, and it seems to be a ZDoom issue that was never fixed ever. The chat sound does exist in Doom1.wad however. |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  chat_sndtest_01.wad (17,089) 2025-01-14 20:50
https://zandronum.com/tracker/file_download.php?file_id=3181&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-08-11 19:02 | unknownna | New Issue | |
| 2024-08-11 19:04 | unknownna | Additional Information Updated | bug_revision_view_page.php?rev_id=14351#r14351 |
| 2024-08-17 00:17 | unknownna | Note Added: 0023948 | |
| 2024-08-17 00:18 | unknownna | Summary | Chat_Sound sound preference doesn't work in Doom 1, and and PrivateChat_Sound is broken => Chat_Sound sound preference doesn't work in Doom 1, and some other minor issues |
| 2024-08-17 00:18 | unknownna | Description Updated | bug_revision_view_page.php?rev_id=14353#r14353 |
| 2025-01-14 05:43 | Kaminsky | Note Added: 0024196 | |
| 2025-01-14 05:43 | Kaminsky | Assigned To | => Kaminsky |
| 2025-01-14 05:43 | Kaminsky | Status | new => needs testing |
| 2025-01-14 05:43 | Kaminsky | Target Version | => 3.2 |
| 2025-01-14 20:50 | unknownna | Note Added: 0024199 | |
| 2025-01-14 20:50 | unknownna | File Added: chat_sndtest_01.wad | |
| 2025-01-14 20:50 | unknownna | Status | needs testing => feedback |
| 2025-01-15 04:37 | Kaminsky | Note Added: 0024200 | |
| 2025-01-16 17:46 | unknownna | Note Added: 0024202 | |
| 2025-01-16 17:46 | unknownna | Status | feedback => assigned |
| 2025-01-16 17:46 | unknownna | Status | assigned => resolved |
| 2025-01-16 17:46 | unknownna | Resolution | open => fixed |
| 2025-01-16 17:46 | unknownna | Fixed in Version | => 3.2 |
|
Notes |
|
|
|
|
Turns out PrivateChat_Sound is not broken. For some reason I thought it was for team chat, hence the misunderstanding. |
|
|
|
|
I fixed Doom 2's chat sound from being selectable (either in the menu or the console) in Doom 1:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/539a66345ed7b797602444a61f6f938ccdc13071 [^]'
Note that this also fixes options like "Doom 1" or "Doom 2" from appearing in the menu for non-Doom IWADs, like Heretic, Hexen, Strife, etc. For example, in Heretic, the only options should now be "Off", "Default", and "Heretic".
As for the chat sound not working in Shareware Doom or FreeDoom 1, since this was a bug from (G)ZDoom, I had to fix this in GZDoom first, which was then easily transplanted into Zandronum:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/18882281a5920ba56abe1318760619dc1be87eb4 [^]' |
|
|
|
|
This seems to work well, but I've got a question:
Is it really necessary to print a big warning message in the console for Doom 1? Couldn't it just be set to "Doom 1" silently if the user had "Doom 2" selected prior?
Again, pardon my questioning, but I just want to clear it up before marking this as resolved.
And for future reference, since I didn't know this myself, it seems that the "Default" setting uses the chat sound defined in the MAPINFO lump. The test wad uploaded replaces the chat sounds in addition to altering the MAPINO sound definition. |
|
|
|
|
Quote from "unknownna"
Is it really necessary to print a big warning message in the console for Doom 1? Couldn't it just be set to "Doom 1" silently if the user had "Doom 2" selected prior?
If a client wants to use Doom 2's chat sound but then loads Doom 1, I'd prefer being transparent and let the client know that their setting can't work and needs to be adjusted, instead of silently changing it without their knowledge (even if the old value can be restored upon closing the game, provided that they don't change it mid-game). The warning message itself shouldn't be too obstructive that it'd be a problem for clients.
Quote from "unknownna"
And for future reference, since I didn't know this myself, it seems that the "Default" setting uses the chat sound defined in the MAPINFO lump. The test wad uploaded replaces the chat sounds in addition to altering the MAPINO sound definition.
That's correct. Selecting "Default" uses the chat sound defined in the GameInfo block in MAPINFO, which could be different from "misc/chat" (for Doom 2, Heretic, Hexen, Strife, etc.) or "misc/chat2" (for Doom 1 only). |
|
|
|
|
|