MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004368Zandronum[All Projects] Bugpublic2024-08-05 21:562025-03-24 16:31
Reporterunknownna 
Assigned ToKaminsky 
PrioritynormalSeveritytextReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.1 
Target Version3.2Fixed in Version3.2 
Summary0004368: CTF "flag taken/returned" etc. messages do not appear in console offline, in addition to using wrong msgcolors online
Description* The extra messages that are printed in the console do not appear during offline play.
* When the messages appear online, they use the wrong msg1color "obituary" instead of the proper msg2color "critical messages".
Interestingly enough, the message that prints "x scored for the y team!" does use the proper msg2color.
See the attached screenshot.

The inconsistent coloring on the messages might make the console look unnecessarily busy.
Steps To Reproduce
Additional InformationThere's also perhaps a redundant "x flag returned" message after somebody scores.
TagsNo tags attached.
Relationships
related to 0004395closed  Neutralize small print color in CTF flag messages 
Attached Filespng Screenshot_Doom_20240805_235017.png (99,557) 2024-08-05 21:56
https://zandronum.com/tracker/file_download.php?file_id=3077&type=bug
png

png Screenshot_Doom_20250320_134520.png (53,668) 2025-03-20 12:57
https://zandronum.com/tracker/file_download.php?file_id=3194&type=bug
png

png Screenshot_Doom_20250320_215201.png (80,865) 2025-03-20 21:00
https://zandronum.com/tracker/file_download.php?file_id=3196&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-08-05 21:56unknownnaNew Issue
2024-08-05 21:56unknownnaFile Added: Screenshot_Doom_20240805_235017.png
2024-08-05 22:23unknownnaNote Added: 0023903
2024-08-27 10:17unknownnaRelationship addedrelated to 0004395
2025-03-18 18:55KaminskyNote Added: 0024255
2025-03-18 18:55KaminskyAssigned To => Kaminsky
2025-03-18 18:55KaminskyStatusnew => needs review
2025-03-18 18:55KaminskyProduct Version => 3.1
2025-03-18 18:55KaminskyTarget Version => 3.2
2025-03-20 12:57unknownnaNote Added: 0024264
2025-03-20 12:57unknownnaFile Added: Screenshot_Doom_20250320_134520.png
2025-03-20 13:27KaminskyNote Added: 0024266
2025-03-20 21:00unknownnaNote Added: 0024278
2025-03-20 21:00unknownnaFile Added: Screenshot_Doom_20250320_215201.png
2025-03-20 21:41unknownnaNote Edited: 0024278bug_revision_view_page.php?bugnote_id=24278#r14480
2025-03-22 14:24KaminskyNote Added: 0024297
2025-03-23 16:32unknownnaNote Added: 0024302
2025-03-23 20:51unknownnaNote Edited: 0024302bug_revision_view_page.php?bugnote_id=24302#r14493
2025-03-23 21:09unknownnaNote Edited: 0024302bug_revision_view_page.php?bugnote_id=24302#r14494
2025-03-24 16:31unknownnaNote Added: 0024313
2025-03-24 16:31unknownnaStatusneeds review => resolved
2025-03-24 16:31unknownnaFixed in Version => 3.2
2025-03-24 16:31unknownnaResolutionopen => fixed

Notes
(0023903)
unknownna   
2024-08-05 22:23   
* Skulltag mode is also affected by the same issue.
* None of the messages appear at all in OneFlagCTF, not even online.
(0024255)
Kaminsky   
2025-03-18 18:55   
This should be addressed in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/275 [^]'
(0024264)
unknownna   
2025-03-20 12:57   
Thank you, amazing work.

* Would it be a good idea to print "x flag returned automatically." when it auto-returns? It would perhaps clear it up a bit more between player-returns and auto-returns, and be clearer when looking at the server console log.

* The server seems to crash when getting killed while carrying the white flag.

* If a "x flag dropped." message appears immediately after "x has taken the y flag.", the "held by:" portion still remains. The smaller headers remain on different messages that appear without small headers. This behavior is also present in 3.1.
Would it be good to change this behavior, or would it be too abrupt? See the attached screenshot.

I know it might sound nitpicky as usual, but I'm just letting you know my thoughts while testing it.
(0024266)
Kaminsky   
2025-03-20 13:27   
All the points you mentioned above (especially the crash) should be addressed now.
(0024278)
unknownna   
2025-03-20 21:00   
(edited on: 2025-03-20 21:41)
Nice, good work on the fixes.

* The carrier name on the HUD in 1-flag-CTF seems to be missing the proper team coloring. See the attached screenshot. Super Shotgunner is on blue team, yet the name is drawn in white.

* Missing "x flag dropped." message when removing bots that carry flags.
(0024297)
Kaminsky   
2025-03-22 14:24   
The "x flag dropped" message not appearing in online games when a player disconnects should be fixed now. The HUD text colouring in 1-flag CTF will be handled in a separate MR.
(0024302)
unknownna   
2025-03-23 16:32   
(edited on: 2025-03-23 21:09)
* I tested the latest pipeline build, and the "x lost the y flag" appears twice for bots if they are removed while carrying the flag online only.
* The drop message is in reversed order for bots/players when removed/disconnected, they "leave the game" before dropping the flag. This does not happen if a player turns into a spectator or gets fragged.

It's very unrealistic scenarios, but it was just something I noticed while testing it.

Edit:
Tested the latest pipeline build, and it fixed the message order issue, but the double bot message remains. Not sure if the other fix was supposed to take care of it, but just letting you know.

Actually, it might just be some RCON double message.
(0024313)
unknownna   
2025-03-24 16:31   
I noticed you went ahead and fixed the double RCON message. Tested the pipeline build and can confirm it fixed the issue.

All of the issues here are now resolved. Great work as usual. It definitely feels more consistent and clean now compared to before.