MantisBT - Zandronum
View Issue Details
0004337Zandronum[All Projects] Bugpublic2024-06-16 15:482024-08-05 14:10
unknownna 
 
normalminoralways
feedbackopen 
3.1 
 
0004337: Players lose all earned medals when turning into a spectator
Like the title says, if you turn into a spectator during a game, all of your earned medals disappear.
I don't think people wish to lose their medals during a game. The user could be taking a break from the game before returning for instance, and then wish to resume collecting medals. Right now, all medal progress is lost.
No tags attached.
Issue History
2024-06-16 15:48unknownnaNew Issue
2024-07-29 15:00KaminskyNote Added: 0023848
2024-07-29 15:00KaminskyStatusnew => feedback
2024-07-29 15:01KaminskyNote Edited: 0023848bug_revision_view_page.php?bugnote_id=23848#r14322
2024-07-30 01:44unknownnaNote Added: 0023856
2024-07-30 01:44unknownnaStatusfeedback => new
2024-07-30 15:51KaminskyNote Added: 0023863
2024-07-30 15:51KaminskyNote Edited: 0023863bug_revision_view_page.php?bugnote_id=23863#r14327
2024-07-30 15:52KaminskyStatusnew => feedback
2024-08-02 10:32unknownnaNote Added: 0023889
2024-08-02 10:32unknownnaStatusfeedback => new
2024-08-02 10:33unknownnaStatusnew => feedback
2024-08-05 14:10unknownnaNote Edited: 0023889bug_revision_view_page.php?bugnote_id=23889#r14345

Notes
(0023848)
Kaminsky   
2024-07-29 15:00   
(edited on: 2024-07-29 15:01)
Right now, when a player spectates, they lose everything including frags, points, wins, etc., so shouldn't they lose all of their medals too? If players want to keep their medals upon spectating, wouldn't they want to keep the other stats that are lost too? Or at least, it seems logical to keep everything.

The source code also suggests that this is intended, so I wouldn't consider this a bug, but rather a suggestion to change the current behaviour.

(0023856)
unknownna   
2024-07-30 01:44   
The only thing I'm worried about is some potential future medal stats tracking for player profiles. I'd want players turning into specators to keep their medals for tracking, in addition to players with cl_medals 0 earning medals under the hood, so to speak, so they don't miss out on stats.

And is there a reason why players have to lose their stats when turning into a spectator? I can see the case in team-based modes when switching teams, but can't think of anything in regular modes at the moment.
(0023863)
Kaminsky   
2024-07-30 15:51   
Quote from "unknownna"
The only thing I'm worried about is some potential future medal stats tracking for player profiles. I'd want players turning into specators to keep their medals for tracking, in addition to players with cl_medals 0 earning medals under the hood, so to speak, so they don't miss out on stats.


I'm guessing this would be an ACS mod that makes use of the account system and EVENT scripts (e.g. GAMEEVENT_PLAYERMEDALS), right? At least right now, I don't think player profiles would become a hard-coded feature of the port, if I'm understanding this correctly. I've seen stuff like this used for events like FNF back in the day.

Quote from "unknownna"
And is there a reason why players have to lose their stats when turning into a spectator? I can see the case in team-based modes when switching teams, but can't think of anything in regular modes at the moment.


I'm going based on what I clearly see as intended behaviour (i.e. when the player becomes a spectator):

// [BB] Make sure the player loses his frags, wins and points.
if ( NETWORK_InClientMode() == false )
    PLAYER_ResetAllScoreCounters ( pPlayer );

I suspect there's a specific reason for this decision, but I don't know it myself. Though, after trying out a few other FPS games, indeed, the player keeps their stats (e.g. frags/kills, deaths, etc.) if they spectate then re-join and/or change teams.

(0023889)
unknownna   
2024-08-02 10:32   
(edited on: 2024-08-05 14:10)
Quote from Kaminsky
I'm guessing this would be an ACS mod that makes use of the account system and EVENT scripts (e.g. GAMEEVENT_PLAYERMEDALS), right? At least right now, I don't think player profiles would become a hard-coded feature of the port, if I'm understanding this correctly. I've seen stuff like this used for events like FNF back in the day.


I'm actually thinking of some basic hard-coded stuff. It would work well with the account system to give players a sense of progression, and perhaps build some community around it. But I feel this is a discussion best suited for another ticket.

Quote from Kaminsky
I suspect there's a specific reason for this decision, but I don't know it myself. Though, after trying out a few other FPS games, indeed, the player keeps their stats (e.g. frags/kills, deaths, etc.) if they spectate then re-join and/or change teams.


I think some of the stats do have to be kept though when turning into a spectator, especially wins for the duel mode. Would be nice to know why stats are reset. I could see stats being reset in team modes, in order to not confuse others when switching teams.

And from testing more, some stats are technically kept as a true spectator now, such as death counts. You can't see it on the scoreboard at the moment, but when you join the game, the game remembers your former stat.